RE: [Patch] accept any RTSP session id

2016-08-11 Thread Daniel Stenberg
On Thu, 11 Aug 2016, Erik Janssen wrote: Agree, especially on the ground that spaces are such problematic characters. Landed in commit 2c8ccdac14f8. Thanks! I am in sync with the mainline very soon the slate will be clean to finally put my attention to the remaining issue of the libcurl

RE: [Patch] accept any RTSP session id

2016-08-11 Thread Erik Janssen
. Still climbing that hill :) Erik -Original Message- From: Daniel Stenberg [mailto:dan...@haxx.se] Sent: donderdag 11 augustus 2016 13:25 To: Erik Janssen <erik.jans...@axis.com> Cc: libcurl development <curl-library@cool.haxx.se> Subject: RE: [Patch] accept any RTSP session id

RE: [Patch] accept any RTSP session id

2016-08-11 Thread Daniel Stenberg
On Thu, 11 Aug 2016, Erik Janssen wrote: There is a philosophy aspect. Does curl strive to accept valid input only, or does it mean to handle as good as possible (but 'no guarantees') flaky input? My style is the latter We're basically all over the map but we lean towards the later. We

RE: [Patch] accept any RTSP session id

2016-08-11 Thread Erik Janssen
Hi, > Ok, I was sloppy and didn't run the tests before I merged this. It turns out > we have test 569 > that verifies that we don't accept spaces as part of the RTSP session id. > Like this: > > Session:\$extraspaces ignore-this-part---;foo=bar > > So, do you think we should fix

Re: [Patch] accept any RTSP session id

2016-08-11 Thread Daniel Stenberg
On Tue, 9 Aug 2016, Erik Janssen wrote: I propose the following small change to make libcurl work in communication with gstreamer-based RTSP servers. See attached patch against 7.50.1. The original code validates the session id to be in accordance with the RFC. I think it is better not to do

Re: [Patch] accept any RTSP session id

2016-08-10 Thread Daniel Stenberg
On Tue, 9 Aug 2016, Erik Janssen wrote: I propose the following small change to make libcurl work in communication with gstreamer-based RTSP servers. Thanks! Merged in commit e577c43bb5c6 just now. -- / daniel.haxx.se --- List

Re: [Patch] accept any RTSP session id

2016-08-09 Thread Daniel Stenberg
On Tue, 9 Aug 2016, Erik Janssen wrote: The original code validates the session id to be in accordance with the RFC. I think it is better not to do that: Sounds sensible to me. I'm up for merging it unless someone objects. -- / daniel.haxx.se

[Patch] accept any RTSP session id

2016-08-09 Thread Erik Janssen
Hi, I propose the following small change to make libcurl work in communication with gstreamer-based RTSP servers. See attached patch against 7.50.1. The original code validates the session id to be in accordance with the RFC. I think it is better not to do that: - For curl the actual