Re: 7.78.0: configure: tweak nghttp2 library name fix

2021-07-21 Thread Daniel Stenberg via curl-library 

On Wed, 21 Jul 2021, Christian Weisgerber via curl-library wrote:

Similar variable manipulation elsewhere in configure.ac uses sed, so I 
suggest to use the same idiom here:


Thanks, I made a PR out of your patch: https://github.com/curl/curl/pull/7472

--

 / daniel.haxx.se
 | Commercial curl support up to 24x7 is available!
 | Private help, bug fixes, support, ports, new features
 | https://www.wolfssl.com/contact/
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html

7.78.0: configure: tweak nghttp2 library name fix

2021-07-21 Thread Christian Weisgerber via curl-library 
This commit for curl 7.78.0...

configure: fix nghttp2 library name for static builds
https://github.com/curl/curl/commit/29c7cf79e8b44cfe98306a41a766d10e98c13d2b

... introduced a problem by assuming that LIB_H2 does not have any
leading whitespace.  At least OpenBSD's native pkg-config can produce
such whitespace, though:

$ pkg-config --libs-only-l libnghttp2
 -lnghttp2

As a result, the configure check for libnghttp2 will erroneously
fail.

Similar variable manipulation elsewhere in configure.ac uses sed,
so I suggest to use the same idiom here:

--- configure.ac.orig
+++ configure.ac
@@ -2541,7 +2541,7 @@ if test X"$want_h2" != Xno; then
 LDFLAGS="$LDFLAGS $LD_H2"
 CPPFLAGS="$CPPFLAGS $CPP_H2"
 LIBS="$LIB_H2 $LIBS"
-LIB_H2_NAME=${LIB_H2#"-l"}
+LIB_H2_NAME=`echo $LIB_H2 | $SED -e 's/-l//'`
 
 # use nghttp2_session_set_local_window_size to require nghttp2
 # >= 1.12.0

-- 
Christian "naddy" Weisgerber  na...@mips.inka.de
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html