Re: Mem leak in curl_ntlm_msg.c

2013-02-11 Thread Christian Hägele
Am 08.02.2013, 13:55 Uhr, schrieb Gisle Vanem gva...@broadpark.no: 'dup_domain.tbyte_ptr' looks to be freed in Curl_ntlm_sspi_cleanup() via 'ntlm-identity.Domain'. But I see no freeing of 'dup_domain.tchar_ptr'. I didn't have the opportunity to test the code, but as

Re: Mem leak in curl_ntlm_msg.c

2013-02-11 Thread Gisle Vanem
Christian Hägele haeg...@teamviewer.com wrote: I didn't have the opportunity to test the code, but as Really? You should build libcurl with '-DCURLDEBUG', do a set CURL_MEMDEBUG=mem_trace_file, run tests\libtest\libntlmconnect.exe and check leaks with perl tests\memanalyze.pl mem_trace_file.

Re: Mem leak in curl_ntlm_msg.c

2013-02-11 Thread Christian Hägele
Am 11.02.2013, 13:58 Uhr, schrieb Gisle Vanem gva...@broadpark.no: I didn't have the opportunity to test the code, but as Really? You should build libcurl with '-DCURLDEBUG', do a set CURL_MEMDEBUG=mem_trace_file, run tests\libtest\libntlmconnect.exe and check leaks with perl

RE: Mem leak in curl_ntlm_msg.c

2013-02-11 Thread Steve Holme
Hi Guys, On Mon, 11 Feb 2013, Christian Hagele wrote: I think you got me wrong. I don't say that there is no memory leak, but that your change breaks the existing code. I just debugged through the code and made printf-debugging. When you try to print out ntml-identity.Domain in

Mem leak in curl_ntlm_msg.c

2013-02-08 Thread Gisle Vanem
Running tests\libtest\libntlmconnect.exe reveals a 1 byte (!) leak in ./lib/curl_ntlm_msgs.c: perl ..\memanalyze.pl c:memdebug.curl Leak detected: memory still allocated: 1 bytes At 9771e8, there's 1 bytes. allocated by curl_ntlm_msgs.c:399 Snippet from curl_ntlm_msgs.c: /* setup ntlm

Re: Mem leak in curl_ntlm_msg.c

2013-02-08 Thread Daniel Stenberg
On Fri, 8 Feb 2013, Gisle Vanem wrote: Patch: Thanks, merged and pushed! -- / daniel.haxx.se --- List admin: http://cool.haxx.se/list/listinfo/curl-library Etiquette: http://curl.haxx.se/mail/etiquette.html