Re: Nmake install prefix
Hi, I handle it identically to WITH_DEVEL, so I think it may be fine. Created a pull request: https://github.com/curl/curl/pull/4031 Thanks, Thomas Am 16.06.2019 um 12:18 schrieb Rod Widdowson via curl-library: Any Windows developer who would object? Not from here. Looks pretty benign. Some side notes: I can never remember under what circumstances NMAKE inherits environmental variable (with and withour /e) so I cannot work out whether this wouldn't either need some work in Makefile.vc and/or whether you can just doing by condionalizing the setting of DESTDIR on DESTDIR. Also whether it works from the command line as well as in the environment... If this is a supported variable you need to make a suitable change to MakeFile.vc (alongside WITH_DEVEL and so on). Finally as a general code thing I think I'd prefer !IFDEF WITH_PREFIX DIRDIST = $(WITH_PREFIX) !ELSE DIRDIST = ..\builds\$(CONFIG_NAME_LIB)\ !ENDIF Finally, if you take this to Github can someone mark me a reviewer and I'll try to do a test build? I recently stopped getting all github mails for curl since I was getting swamped... R --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
RE: Nmake install prefix
> Any Windows developer who would object? Not from here. Looks pretty benign. Some side notes: I can never remember under what circumstances NMAKE inherits environmental variable (with and withour /e) so I cannot work out whether this wouldn't either need some work in Makefile.vc and/or whether you can just doing by condionalizing the setting of DESTDIR on DESTDIR. Also whether it works from the command line as well as in the environment... If this is a supported variable you need to make a suitable change to MakeFile.vc (alongside WITH_DEVEL and so on). Finally as a general code thing I think I'd prefer !IFDEF WITH_PREFIX DIRDIST = $(WITH_PREFIX) !ELSE DIRDIST = ..\builds\$(CONFIG_NAME_LIB)\ !ENDIF Finally, if you take this to Github can someone mark me a reviewer and I'll try to do a test build? I recently stopped getting all github mails for curl since I was getting swamped... R --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html
Re: Nmake install prefix
On Sat, 15 Jun 2019, Thomas Gamper via curl-library wrote: As I was working on a script to automate the nmake based build of libcurl, I noticed that the installation directory for the built files is hardwired. Would the attached patch, that allows one to supply a install prefix, be considered a worthwile addition to the nmake build system? I don't use this build method myself but this patch seems like small and simple enough that I think we should merge it. Any Windows developer who would object? -- / daniel.haxx.se | Get the best commercial curl support there is - from me | Private help, bug fixes, support, ports, new features | https://www.wolfssl.com/contact/ --- Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library Etiquette: https://curl.haxx.se/mail/etiquette.html