Re: Valgrind Suppress error, in test cases. Warning on new testcases.

[Daniel Stenberg via curl-library]

On Tue, 25 May 2021, Gealber Morales via curl-library wrote:


Here I attached the file *valgrind1196 *which correspond to this test case.
I think the problem is with the *Curl_rand_hex *function, that Valgrind
goes crazy with it.
Maybe I'm not doing it correctly, so any correction is good to know. The
files *valgrind.pm  *and *valgrind.supp*, are in the
*tests* folder.


That looks like a set of false positives in OpenSSL. We don't see those in the 
CI and I don't see them in my dev machines.


It looks like errors we should suppress in Valgrind.


When I add new test cases, for example *test3018*, I'm getting this warning:
*Warning: test3018 not present in tests/data/Makefile.inc*
I checked this file *tests/data/Makefile.inc* is true that the test is not
present in the list of tests, but should I just add it to the list?


Yes. That's the canonical list of all test cases we have so you should add 
your new test files in that list.



I did it but that doesn't seems to be the solution.


You need to rerun autoreconf again so that tests/Makefile gets regenenerated 
and then it detects the file correctly.


--

 / daniel.haxx.se
 | Commercial curl support up to 24x7 is available!
 | Private help, bug fixes, support, ports, new features
 | https://www.wolfssl.com/contact/
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html

Re: Valgrind Suppress error, in test cases. Warning on new testcases.

[Gealber Morales via curl-library]

Here is the valgrind log file.

El mar, 25 de may. de 2021 a la(s) 07:31, Gealber Morales (
gealbermora...@gmail.com) escribió:

> Hello there
> *Have two questions:*
>
> First one
> When running test cases, I'm getting error from Valgrind, let me describe
> the steps and also supplied the Valgrind log for one of the test.
> 1. Position on the folder *tests*
> 2. Run *./runtest.pl  1196, *for example it could be
> another one.
> 3. There's no error related to the test except from Valgrind. I say that
> there's no error from the test because when there's an error two files are
> created in the folder
> *log: check-expected and check-generated. *
>
> Here I attached the file *valgrind1196 *which correspond to this test
> case. I think the problem is with the *Curl_rand_hex *function, that
> Valgrind goes crazy with it.
> Maybe I'm not doing it correctly, so any correction is good to know. The
> files *valgrind.pm  *and *valgrind.supp*, are in the
> *tests* folder.
>
> Second one
> When I add new test cases, for example *test3018*, I'm getting this
> warning:
> *Warning: test3018 not present in tests/data/Makefile.inc*
> I checked this file *tests/data/Makefile.inc* is true that the test is
> not present in the list of tests, but should I just add it to the list? I
> did it but that doesn't seems to be the solution. Any suggestion on how to
> remove this warning?
>
> Greeting and thanks for the patience
>


valgrind1196
Description: Binary data
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html

Valgrind Suppress error, in test cases. Warning on new testcases.

[Gealber Morales via curl-library]

Hello there
*Have two questions:*

First one
When running test cases, I'm getting error from Valgrind, let me describe
the steps and also supplied the Valgrind log for one of the test.
1. Position on the folder *tests*
2. Run *./runtest.pl  1196, *for example it could be
another one.
3. There's no error related to the test except from Valgrind. I say that
there's no error from the test because when there's an error two files are
created in the folder
*log: check-expected and check-generated. *

Here I attached the file *valgrind1196 *which correspond to this test case.
I think the problem is with the *Curl_rand_hex *function, that Valgrind
goes crazy with it.
Maybe I'm not doing it correctly, so any correction is good to know. The
files *valgrind.pm  *and *valgrind.supp*, are in the
*tests* folder.

Second one
When I add new test cases, for example *test3018*, I'm getting this warning:
*Warning: test3018 not present in tests/data/Makefile.inc*
I checked this file *tests/data/Makefile.inc* is true that the test is not
present in the list of tests, but should I just add it to the list? I did
it but that doesn't seems to be the solution. Any suggestion on how to
remove this warning?

Greeting and thanks for the patience
---
Unsubscribe: https://cool.haxx.se/list/listinfo/curl-library
Etiquette:   https://curl.se/mail/etiquette.html