Re: scan-build-11 warnings

2021-05-08 Thread Daniel Stenberg via curl-library
On Sat, 8 May 2021, Patrick Monnerat via curl-library wrote: IMHO, this is not only a false positive, but a scan-build bug. Mabe you can silent it by rephrasing the code. In example: I tried a whole bunch of variations like that without success. Until I moved the entire speed calc logic

Re: scan-build-11 warnings

2021-05-08 Thread Patrick Monnerat via curl-library
On 5/8/21 12:14 PM, Daniel Stenberg via curl-library wrote: Hi friends! I ran scan-build-11 against the current git master curl code and it generates two warnings that I just cannot understand and at the same time I cannot easily silence. We use scan-build in the CI (travis), but that runs

Re: scan-build-11 warnings

2021-05-08 Thread Daniel Stenberg via curl-library
On Sat, 8 May 2021, Daniel Stenberg via curl-library wrote: For all I can tell, these are false positives. Can *you* find an actual problem and fix? The warnings go away when I move the speed logic into a sub function, which also makes the code a little nicer:

scan-build-11 warnings

2021-05-08 Thread Daniel Stenberg via curl-library
Hi friends! I ran scan-build-11 against the current git master curl code and it generates two warnings that I just cannot understand and at the same time I cannot easily silence. We use scan-build in the CI (travis), but that runs an older version that doesn't seem to warn for these issues.