Re: Accidental debug-enabled version

2023-01-12 Thread Daniel Stenberg via curl-library
On Wed, 11 Jan 2023, Dan Fandrich via curl-library wrote: Writing the same thing as the first line of -v output would double the chance it's actually seen. The PR has been updated to this effect now. -- / daniel.haxx.se | Commercial curl support up to 24x7 is available! | Private help, bu

Re: Accidental debug-enabled version

2023-01-12 Thread Daniel Stenberg via curl-library
On Wed, 11 Jan 2023, Kamil Dudka wrote: Unless someone uses `curl -V 2>&1 | grep ...` like curl's autoconf test did it with GCC: https://github.com/curl/curl/commit/curl-7_49_1-45-gb2dcf0347 If they do then they, like us, will learn that it is wrong! =) -- / daniel.haxx.se | Commercial

Re: Accidental debug-enabled version

2023-01-11 Thread Dan Fandrich via curl-library
On Wed, Jan 11, 2023 at 02:24:57PM +0100, Daniel Stenberg via curl-library wrote: > Like this: > > $ curl -V > WARNING: this libcurl is Debug-enabled, do not use in production Writing the same thing as the first line of -v output would double the chance it's actually seen. -- Unsubscribe: https

Re: Accidental debug-enabled version

2023-01-11 Thread Kamil Dudka via curl-library
On Wednesday, January 11, 2023 2:39:47 PM CET Daniel Stenberg via curl-library wrote: > On Wed, 11 Jan 2023, Jeffrey Walton wrote: > > > I would not put it on the first line. Some folks may be parsing the > > first line for a version number using something like: > > > > curl_version=$(curl -V

Re: Accidental debug-enabled version

2023-01-11 Thread Timothe Litt via curl-library
Another option would be that building with  debug creates curl-debug and libcurl-debug (rather than curl and libcurl), which makes it really difficult to unknowingly make this mistake. It also handles libcurl-debug escaping into the wild and being silently loaded by applications.  And in a mul

Re: Accidental debug-enabled version

2023-01-11 Thread Daniel Stenberg via curl-library
On Wed, 11 Jan 2023, Jeffrey Walton wrote: I would not put it on the first line. Some folks may be parsing the first line for a version number using something like: curl_version=$(curl -V | head -n 1 | cut -f 2 -d ' ') Somewhere further down in the stack would probably be a better choice.

Re: Accidental debug-enabled version

2023-01-11 Thread Jeffrey Walton via curl-library
On Wed, Jan 11, 2023 at 8:25 AM Daniel Stenberg via curl-library wrote: > > The other day a user submitted an issue that made it obvious to me that they > had accidentally and unintionally built a debug-enabled libcurl and might have > used that in production unless I had told them about and talke

Accidental debug-enabled version

2023-01-11 Thread Daniel Stenberg via curl-library
Hi team, The other day a user submitted an issue that made it obvious to me that they had accidentally and unintionally built a debug-enabled libcurl and might have used that in production unless I had told them about and talked them out of it. A debug-enabled libcurl has debug and test code