Re: Goal: reduce overall function complexity

2025-05-20 Thread Daniel Stenberg via curl-library
On Wed, 14 May 2025, Dan Fandrich via curl-library wrote: If the current few known-bad offenders are added to a whitelist, it becomes easier to ratchet this number down over time. Here's a first shot that sets the maximum allowed limit to 100, with two functions whitelisted at the moment:

Re: Goal: reduce overall function complexity

2025-05-14 Thread Dan Fandrich via curl-library
On Wed, May 14, 2025 at 11:53:35PM +0200, Daniel Stenberg wrote: > Aggressive! We currently have no less than 326 functions scoring over 15. Out > of 3436, so about > 9.5% of all functions. A graph showing a count or percentage of functions at a few McCabe complexity levels (10, 15, 100) might be

Re: Goal: reduce overall function complexity

2025-05-14 Thread Daniel Stenberg via curl-library
On Wed, 14 May 2025, Daniel Stenberg via curl-library wrote: Right now, the top-10 most complex functions in production code according to this tool are (score, filename, line number, function name): 196 src/tool_operate.c(870): config2setopts I forgot to mention that we have a graph in t

Re: Goal: reduce overall function complexity

2025-05-14 Thread Daniel Stenberg via curl-library
On Wed, 14 May 2025, Dan Fandrich via curl-library wrote: According to Wikipedia, McCabe suggested a limit of 10 and NIST later suggested some situations where 15 might be appropriate. So, 100 seems like a good starting point! Aggressive! We currently have no less than 326 functions scoring o

Re: Goal: reduce overall function complexity

2025-05-14 Thread Dan Fandrich via curl-library
On Wed, May 14, 2025 at 11:28:48PM +0200, Daniel Stenberg via curl-library wrote: > Wouldn't it be cool to set a cap and make a subsequent CI job that turns red > if any single > function in product code is too complex? As a way to make sure we keep the > code clean and > readable. Sounds like