On Sun, Aug 25, 2013 at 03:31:42PM +0200, Maxime Villard wrote:
Hi,
here is a patch for some tweaks in kern/exec_elf.c.
* Typo in a comment
* elf_check_header() already ensures eh.e_phnum MAXPHNUM
How about also moving the check for eh.e_phnum == 0 into elf_check_header?
Eric
On 08/26/13 16:58, Eric Haszlakiewicz wrote:
On Sun, Aug 25, 2013 at 03:31:42PM +0200, Maxime Villard wrote:
Hi,
here is a patch for some tweaks in kern/exec_elf.c.
* Typo in a comment
* elf_check_header() already ensures eh.e_phnum MAXPHNUM
How about also moving the check for
Maxime Villard m...@m00nbsd.net writes:
* Put is_dyn before. It's just a small optimization:
elf_check_header(eh, ET_EXEC) is always called before checking
is_dyn, so if we invert the two things we avoid calling
elf_check_header() twice if is_dyn is ok.
- How often is_dyn is true?
Updating src tree:
P src/distrib/acorn26/instkernel/Makefile
P src/external/gpl3/gcc/dist/gcc/config/mips/netbsd.h
P src/lib/csu/common/crtbegin.c
P src/share/mk/bsd.own.mk
P src/sys/arch/acorn26/conf/INSTALL
P src/sys/arch/hpcarm/hpcarm/locore.S
P src/sys/arch/hpcarm/hpcarm/pxa2x0_hpc_machdep.c