Re: Porting DTrace to ARM

2014-03-05 Thread Ryota Ozaki
Hi, So I've updated my patch: https://gist.github.com/ozaki-r/8535846 The new patch dropped committed changes, followed KNF (hopefully) and did some tweaks. At this point, what I would like to get feedbacks are some changes under sys/arch/arm: - Replace cpu_id with cpuid in sys/arch/arm -

pic.h

2014-03-05 Thread Patrick Welche
I notice # find /usr/src/sys -name pic.h /usr/src/sys/arch/i386/include/pic.h /usr/src/sys/arch/amd64/include/pic.h /usr/src/sys/arch/x86/include/pic.h /usr/src/sys/arch/xen/include/i386/pic.h /usr/src/sys/arch/xen/include/amd64/pic.h /usr/src/sys/arch/xen/include/pic.h but after a build.sh, I

Re: libgomp not protecting local variables: variable length buffer for past few days

2014-03-05 Thread Matthias Scheler
On Tue, Mar 04, 2014 at 10:08:19AM -0800, B Harder wrote: Yes, I have USE_SSP=yes in /etc/mk/conf. cc1: warnings being treated as errors /usr/src/external/gpl3/gcc.old/dist/libgomp/task.c: In function 'GOMP_task': /usr/src/external/gpl3/gcc.old/dist/libgomp/task.c:79:1: error: not

Re: Porting DTrace to ARM

2014-03-05 Thread Matt Thomas
On Mar 5, 2014, at 3:12 AM, Ryota Ozaki ozak...@netbsd.org wrote: - Replace cpu_id with cpuid in sys/arch/arm - Can I commit the change? Why? It's just churn for no reason I can see. - Move INKERNEL and FR_* macros from arm/arm/db_trace.c to arm/include/db_machdep.h to refer them in

Re: Porting DTrace to ARM

2014-03-05 Thread Ryota Ozaki
On Thu, Mar 6, 2014 at 12:48 PM, Matt Thomas m...@3am-software.com wrote: On Mar 5, 2014, at 7:33 PM, Ryota Ozaki ozak...@netbsd.org wrote: On Thu, Mar 6, 2014 at 1:39 AM, Matt Thomas m...@3am-software.com wrote: On Mar 5, 2014, at 3:12 AM, Ryota Ozaki ozak...@netbsd.org wrote: - Replace

Re: Porting DTrace to ARM

2014-03-05 Thread Masao Uebayashi
Ah. I misread that schedstate_percpu uses percpu(9)'s fast path, which doesn't exist... Anyway if it's assumed that cpu is not attached at run-time, assigning struct cpu_data::void *cpu_dtraceinfo at module attachment would be just fine. On Thu, Mar 6, 2014 at 2:08 PM, Matt Thomas

Re: Porting DTrace to ARM

2014-03-05 Thread Ryota Ozaki
On Thu, Mar 6, 2014 at 2:21 PM, Masao Uebayashi uebay...@gmail.com wrote: Ah. I misread that schedstate_percpu uses percpu(9)'s fast path, which doesn't exist... Anyway if it's assumed that cpu is not attached at run-time, assigning struct cpu_data::void *cpu_dtraceinfo at module attachment

Re: Porting DTrace to ARM

2014-03-05 Thread Masao Uebayashi
Well, more type is better. :) See [1]. My question was more like, what happens if CPU can be attached at run-time in the future? Per-CPU initialization operations have to be remembered somewhere. [1] http://mail-index.netbsd.org/tech-kern/2014/03/03/msg016699.html On Thu, Mar 6, 2014 at 3:34