Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 09:00:30PM +, Andrew Doran wrote: > I reproduced it on native x86. It's a bug in the CPU topology code. Now > fixed with revision 1.11 src/sys/kern/subr_cpu.c - sorry about that. I confirm, I now see user activity on all CPUs. Thanks ! -- Manuel Bouyer

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
On Mon, Jan 13, 2020 at 09:17:28PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 07:11:21PM +, Andrew Doran wrote: > > On Mon, Jan 13, 2020 at 07:36:41PM +0100, Manuel Bouyer wrote: > > > > > On Mon, Jan 13, 2020 at 06:33:08PM +, Andrew Doran wrote: > > > > On Mon, Jan 13, 2020

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 07:11:21PM +, Andrew Doran wrote: > On Mon, Jan 13, 2020 at 07:36:41PM +0100, Manuel Bouyer wrote: > > > On Mon, Jan 13, 2020 at 06:33:08PM +, Andrew Doran wrote: > > > On Mon, Jan 13, 2020 at 05:43:51PM +0100, Manuel Bouyer wrote: > > > > > > > On Mon, Jan 13,

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
On Mon, Jan 13, 2020 at 07:36:41PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 06:33:08PM +, Andrew Doran wrote: > > On Mon, Jan 13, 2020 at 05:43:51PM +0100, Manuel Bouyer wrote: > > > > > On Mon, Jan 13, 2020 at 04:59:50PM +0100, Manuel Bouyer wrote: > > > > It also sets rsp and

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 06:33:08PM +, Andrew Doran wrote: > On Mon, Jan 13, 2020 at 05:43:51PM +0100, Manuel Bouyer wrote: > > > On Mon, Jan 13, 2020 at 04:59:50PM +0100, Manuel Bouyer wrote: > > > It also sets rsp and rbp. I think rbp is not set by anything else, at last > > > in the Xen

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
On Mon, Jan 13, 2020 at 05:43:51PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 04:59:50PM +0100, Manuel Bouyer wrote: > > It also sets rsp and rbp. I think rbp is not set by anything else, at last > > in the Xen case. > > The different rbp value would explain why in one case we hit a

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 05:43:51PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 04:59:50PM +0100, Manuel Bouyer wrote: > > It also sets rsp and rbp. I think rbp is not set by anything else, at last > > in the Xen case. > > The different rbp value would explain why in one case we hit a

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 04:59:50PM +0100, Manuel Bouyer wrote: > It also sets rsp and rbp. I think rbp is not set by anything else, at last > in the Xen case. > The different rbp value would explain why in one case we hit a KASSERT() > in lwp_startup later. > But I don't know what pcb_rbp

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 02:49:52PM +, Andrew Doran wrote: > > Now I get a different panic: > > [ 1.000] vcpu0 at hypervisor0 > > [ 1.000] vcpu0: 64 page colors > > [ 1.000] vcpu0: Intel(R) Core(TM)2 Duo CPU E6550 @ 2.33GHz, id > > 0x6fb > > [ 1.000] vcpu0: node 0,

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
On Mon, Jan 13, 2020 at 03:16:05PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 12:02:13PM +, Andrew Doran wrote: > > Ah yes it does, I saw something that made me think it affected x86_64 only. > > I'll make the change on i386 too. > > thanks. > > Now I get a different panic: > [

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 12:02:13PM +, Andrew Doran wrote: > Ah yes it does, I saw something that made me think it affected x86_64 only. > I'll make the change on i386 too. thanks. Now I get a different panic: [ 1.000] vcpu0 at hypervisor0 [ 1.000] vcpu0: 64 page colors [

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
On Mon, Jan 13, 2020 at 12:56:22PM +0100, Manuel Bouyer wrote: > On Mon, Jan 13, 2020 at 11:42:17AM +, Andrew Doran wrote: > > Hi Manuel, > > > > On Mon, Jan 13, 2020 at 10:56:23AM +0100, Manuel Bouyer wrote: > > > Hello, > > > A current Xen domU kernel fails to boot with: > > > [

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
On Mon, Jan 13, 2020 at 11:42:17AM +, Andrew Doran wrote: > Hi Manuel, > > On Mon, Jan 13, 2020 at 10:56:23AM +0100, Manuel Bouyer wrote: > > Hello, > > A current Xen domU kernel fails to boot with: > > [ 1.000] hypervisor0 at mainbus0: Xen version 4.11.3nb1 > > [ 1.000] vcpu0 at

Re: Xen MP panics in cpu_switchto()

2020-01-13 Thread Andrew Doran
Hi Manuel, On Mon, Jan 13, 2020 at 10:56:23AM +0100, Manuel Bouyer wrote: > Hello, > A current Xen domU kernel fails to boot with: > [ 1.000] hypervisor0 at mainbus0: Xen version 4.11.3nb1 > [ 1.000] vcpu0 at hypervisor0 > [ 1.000] vcpu0: Intel(R) Xeon(TM) CPU 3.00GHz, id 0xf64

Xen MP panics in cpu_switchto()

2020-01-13 Thread Manuel Bouyer
Hello, A current Xen domU kernel fails to boot with: [ 1.000] hypervisor0 at mainbus0: Xen version 4.11.3nb1 [ 1.000] vcpu0 at hypervisor0 [ 1.000] vcpu0: Intel(R) Xeon(TM) CPU 3.00GHz, id 0xf64 [ 1.000] vcpu0: node 0, package 0, core 1, smt 1 [ 1.000] vcpu1 at