re: math/cgal and gcc10
> Here (or pkgsrc-users?) seems ok. But my question would be if cgal > documents that it needs a C++11 compiler, in which case this change is > right regardless, or if it's supposed to be ok with C++03, in which case > maybe something else is wrong. the release notes from 2017 say that demos require c++11 now but the library is c++03 itself. i've tested building with this change on netbsd-9 and in current with GCC 10, and it seems fine in both. i'll commit the suggested fix, barring obejctions. thanks. .mrg.
Re: math/cgal and gcc10
On Sun, 25 Apr 2021 at 11:47, Greg Troxel wrote:
>
>
> Chavdar Ivanov writes:
>
> > Hi,
> >
> > Update to gcc10 requires
> >
> > cvs diff -u
> > cvs diff: Diffing .
> > Index: Makefile
> > ===
> > RCS file: /cvsroot/pkgsrc/math/cgal/Makefile,v
> > retrieving revision 1.62
> > diff -u -r1.62 Makefile
> > --- Makefile21 Apr 2021 13:24:12 - 1.62
> > +++ Makefile25 Apr 2021 09:29:10 -
> > @@ -15,7 +15,7 @@
> > LICENSE= gnu-lgpl-v3
> >
> > USE_CMAKE= yes
> > -USE_LANGUAGES= c c++03
> > +USE_LANGUAGES= c c++11
> > CMAKE_ARGS+= -DCGAL_INSTALL_MAN_DIR=${PREFIX}/${PKGMANDIR}/man1
> >
> > REPLACE_SH+= scripts/cgal_create_CMakeLists
> >
> > for math/cgal.
> >
> > I don't know if one should send PRs for this sort of occasional problems.
>
> Here (or pkgsrc-users?) seems ok. But my question would be if cgal
> documents that it needs a C++11 compiler, in which case this change is
> right regardless, or if it's supposed to be ok with C++03, in which case
> maybe something else is wrong.
The error messages before the patch were pretty much straightforward:
...
===> Building for cgal-4.14nb19
[ 2%] Building CXX object src/CGAL/CMakeFiles/CGAL.dir/all_files.cpp.o
In file included from /usr/include/g++/type_traits:35,
from
/usr/pkgsrc/math/cgal/work/.buildlink/include/boost/math/special_functions/math_fwd.hpp:28,
from
/usr/pkgsrc/math/cgal/work/.buildlink/include/boost/math/special_functions/next.hpp:14,
from
/usr/pkgsrc/math/cgal/work/CGAL-4.14/include/CGAL/Bbox_2.h:33,
from
/usr/pkgsrc/math/cgal/work/CGAL-4.14/include/CGAL/Intersections_2/Bbox_2_Line_2.h:30,
from
/usr/pkgsrc/math/cgal/work/CGAL-4.14/src/CGAL/Bbox_2_intersections.cpp:28,
from
/usr/pkgsrc/math/cgal/work/CGAL-4.14/src/CGAL/all_files.cpp:1:
/usr/include/g++/bits/c++0x_warning.h:32:2: error: #error This file
requires compiler and library support for the ISO C++ 2011 standard.
This support must be enabled with the -std=c++11 or -std=gnu++11
compiler options.
Chavdar
--
Re: math/cgal and gcc10
Chavdar Ivanov writes:
> Hi,
>
> Update to gcc10 requires
>
> cvs diff -u
> cvs diff: Diffing .
> Index: Makefile
> ===
> RCS file: /cvsroot/pkgsrc/math/cgal/Makefile,v
> retrieving revision 1.62
> diff -u -r1.62 Makefile
> --- Makefile21 Apr 2021 13:24:12 - 1.62
> +++ Makefile25 Apr 2021 09:29:10 -
> @@ -15,7 +15,7 @@
> LICENSE= gnu-lgpl-v3
>
> USE_CMAKE= yes
> -USE_LANGUAGES= c c++03
> +USE_LANGUAGES= c c++11
> CMAKE_ARGS+= -DCGAL_INSTALL_MAN_DIR=${PREFIX}/${PKGMANDIR}/man1
>
> REPLACE_SH+= scripts/cgal_create_CMakeLists
>
> for math/cgal.
>
> I don't know if one should send PRs for this sort of occasional problems.
Here (or pkgsrc-users?) seems ok. But my question would be if cgal
documents that it needs a C++11 compiler, in which case this change is
right regardless, or if it's supposed to be ok with C++03, in which case
maybe something else is wrong.
signature.asc
Description: PGP signature
math/cgal and gcc10
Hi,
Update to gcc10 requires
cvs diff -u
cvs diff: Diffing .
Index: Makefile
===
RCS file: /cvsroot/pkgsrc/math/cgal/Makefile,v
retrieving revision 1.62
diff -u -r1.62 Makefile
--- Makefile21 Apr 2021 13:24:12 - 1.62
+++ Makefile25 Apr 2021 09:29:10 -
@@ -15,7 +15,7 @@
LICENSE= gnu-lgpl-v3
USE_CMAKE= yes
-USE_LANGUAGES= c c++03
+USE_LANGUAGES= c c++11
CMAKE_ARGS+= -DCGAL_INSTALL_MAN_DIR=${PREFIX}/${PKGMANDIR}/man1
REPLACE_SH+= scripts/cgal_create_CMakeLists
for math/cgal.
I don't know if one should send PRs for this sort of occasional problems.
Chavdar
--
