Thanks, a couple more comments inline.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..e0498f6 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -1155,7 +1155,7 @@ def detect_required_packages(cfg,
>
Review: Approve continuous-integration
PASSED: Continuous integration, rev:b887db1007ed30af5521b20a8fbd95bb31a468c6
https://jenkins.ubuntu.com/server/job/curtin-ci/107/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/107/
SUCCESS:
raharper, I have update the PR with the proposed changes and addressed some
concerns related to the version key on the network config
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..e0498f6 100644
> --- a/curtin/commands/curthooks.py
>
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:bb22f278a3b6dd402f3403e58915d09284da3e99
https://jenkins.ubuntu.com/server/job/curtin-ci/106/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/106/
FAILURE:
Diff comments:
> diff --git a/curtin/commands/apply_net.py b/curtin/commands/apply_net.py
> index ddc5056..8e5596b 100644
> --- a/curtin/commands/apply_net.py
> +++ b/curtin/commands/apply_net.py
> @@ -82,22 +82,23 @@ def apply_net(target, network_state=None,
> network_config=None):
>
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch curtin:master.
--
Review: Approve continuous-integration
--
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/187/
Executed test runs:
ABORTED:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/187/
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch
Review: Approve continuous-integration
--
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing continuous-integration
Autolanding: FAILED
Approved revid is not set in launchpad. This is most likely a launchpad issue
and re-approve should fix it. There is also a chance (although a very small
one) this is a permission problem of the ps-jenkins bot
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:ae20073ecc964eb08e96ac625b441065d4ae56ad
https://jenkins.ubuntu.com/server/job/curtin-ci/105/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/105/
FAILURE:
The proposal to merge ~falcojr/curtin:update-manager-in-docs into curtin:master
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
--
Your team curtin developers is subscribed to branch
The proposal to merge ~legovini/curtin:pin-flake8 into curtin:master has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
--
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing
I think this should land now that paride's branch is approved (once it merges)
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
--
https://code.launchpad.net/~falcojr/curtin/+git/curtin/+merge/383601
Your team curtin developers is subscribed to branch curtin:master.
--
The proposal to merge ~legovini/curtin:pin-flake8 into curtin:master has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
--
Your team curtin developers is subscribed to branch curtin:master.
--
Review: Approve
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe :
Review: Approve
LGTM
--
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
Your team curtin developers is requested to review the proposed merge of
~legovini/curtin:pin-flake8 into curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to :
Review: Approve continuous-integration
PASSED: Continuous integration, rev:74be97f3e9324ec18a5709ea58ce94cb010b3c49
https://jenkins.ubuntu.com/server/job/curtin-ci/104/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/104/
SUCCESS:
The proposal to merge ~legovini/curtin:pin-flake8 into curtin:master has been
updated.
Commit message changed to:
tox: pin flake8 to version and add a tip-flake8 environment
For more details, see:
https://code.launchpad.net/~legovini/curtin/+git/curtin/+merge/383861
--
Your team curtin
23 matches
Mail list logo
