[Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Server Team CI bot
The proposal to merge ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778 -- Your team curtin developers is subscribed to branch cur

Re: [Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Server Team CI bot
Review: Approve continuous-integration -- https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : htt

[Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Chad Smith
The proposal to merge ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778 -- Your team curtin developers is subscribed to bran

Re: [Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Ryan Harper
% ./tools/schema-validate-storage test2.cfg Validating storage config file: test2.cfg Failed validation on: test2.cfg # Validation Errors # 'dm_name' is a required property in test2.cfg { "id": "dm_crypt-0", "key": "ubuntu", "preserve": false, "type": "dm_crypt", "volume": "partition

Re: [Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Ryan Harper
Review: Approve Thanks! -- https://code.launchpad.net/~chad.smith/curtin/+git/curtin/+merge/382778 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.n

Re: [Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Dan Watkins
Review: Approve 2020-04-22 12:28:20 Odd_Bloke Were we just mistakenly up-level when we introduced the schema in the first place? 2020-04-22 12:28:40 blackboxsw Odd_Bloke: yes I think so, and focal is the only place that paid attention 2020-04-22 12:28:41 Odd_Bloke (B

Re: [Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Chad Smith
To test: (on a focal system) cat >broken.yaml

[Curtin-dev] [Merge] ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master

2020-04-22 Thread Chad Smith
Chad Smith has proposed merging ~chad.smith/curtin:fix/json-schema-validation-focal into curtin:master. Commit message: storage: correct declared schema draft version for storage schema python3-jsonschema 3.2 (Ubuntu Focal) pays attention to the $schema version declared in the provided schema wh