The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch curtin:mas
Review: Approve continuous-integration
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/201/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/201/
FAILURE
Merged a fix for the streams url, marking approved to re-run the autolander
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@list
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch curt
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/199/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/199/
FAILURE
Looping failure on arm64
20:49:40 ==
20:49:40 ERROR: test suite for
20:49:40 --
20:49:40 Traceback (most recent call last):
20:49:40 File "/usr/lib/python3/dist
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Approved => Needs review
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch curt
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/198/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/198/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/197/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/197/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/196/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/196/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/195/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/195/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/194/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/194/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/193/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/193/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/192/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/192/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/191/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/191/
FAILURE
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/190/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/190/
FAILURE
Autoland on ARM failed, with this transient issue with image sync:
ValueError: missing files for ftypes: [('boot-initrd',
'/srv/images/focal/arm64/20200514/ga-20.04/generic/boot-initrd'),
('boot-kernel',
'/srv/images/focal/arm64/20200514/ga-20.04/generic/boot-kernel')]
I think it will try agai
Review: Needs Fixing continuous-integration
Autolanding: FAILED
More details in the following jenkins job:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/189/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-autoland-test/nodes=metal-amd64/189/
FAILURE
Review: Approve
thanks LGTM!
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubscribe : https://launchpa
The proposal to merge ~raharper/curtin:fix/replace-grub-shell-helper into
curtin:master has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
--
Your team curtin developers is subscribed to branch curt
Review: Approve continuous-integration
PASSED: Continuous integration, rev:1d3d5c5a4e19be870a70b675bb8cca2e4e133be1
https://jenkins.ubuntu.com/server/job/curtin-ci/112/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/112/
SUCCESS:
https://je
Thanks Chad, I looked into git history, and it turns out that
the docs had not been updated to indicate the change in behavior
we introduced when we added support for reordering uefi menu.
The maas team added that switched to defaulting update_nvram
to True.
I'll update the docs to match the cod
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:c5c397e31002e4edba646fd761094a99008931bb
https://jenkins.ubuntu.com/server/job/curtin-ci/110/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/110/
FAILURE:
https
Review: Needs Fixing
Just one minor nit on the update_nvram defaults being different than each other
(and/or docs) if absent.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..cde45e2 100644
> --- a/curtin/commands/curthooks.py
> +++ b/cu
Review: Approve continuous-integration
PASSED: Continuous integration, rev:4e0d626bba549e4af0399414d00e5650184387ac
https://jenkins.ubuntu.com/server/job/curtin-ci/75/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/75/
SUCCESS:
https://jenk
Thanks Chad, I'll update with some suggested changes.
--
https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/382931
Your team curtin developers is subscribed to branch curtin:master.
--
Mailing list: https://launchpad.net/~curtin-dev
Post to : curtin-dev@lists.launchpad.net
Unsubs
Thanks Chad, I'll update with some suggested changes.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..f705711 100644
> --- a/curtin/commands/curthooks.py
> +++ b/curtin/commands/curthooks.py
> @@ -682,28 +683,6 @@ def setup_grub(cfg, targ
Thanks for this branch Ryan. It looks much better than and more modular now.
I've added a number of comments and questions for you.
Diff comments:
> diff --git a/curtin/commands/curthooks.py b/curtin/commands/curthooks.py
> index 4afe00c..f705711 100644
> --- a/curtin/commands/curthooks.py
> ++
Review: Approve continuous-integration
PASSED: Continuous integration, rev:be4006061ac498ad2dc3eb8d8eccad1abd89c7a4
https://jenkins.ubuntu.com/server/job/curtin-ci/68/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/68/
SUCCESS:
https://jenk
Review: Approve continuous-integration
PASSED: Continuous integration, rev:657a7deeb810beb67aea01f7c41b1f3438e07a20
https://jenkins.ubuntu.com/server/job/curtin-ci/67/
Executed test runs:
SUCCESS:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/67/
SUCCESS:
https://jenk
Review: Needs Fixing continuous-integration
FAILED: Continuous integration, rev:6a40307a78fda86cfce3216bed7667c7529ace4a
https://jenkins.ubuntu.com/server/job/curtin-ci/65/
Executed test runs:
FAILURE:
https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/65/
FAILURE:
https:/
Ryan Harper has proposed merging ~raharper/curtin:fix/replace-grub-shell-helper
into curtin:master.
Commit message:
Replace grub-shell-helper with install_grub command
The install_grub command implemented in shell code inside
helpers/common lacked unittests. We've had some recent and
ongoing ch
33 matches
Mail list logo
