Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

Review: Approve -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curti

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

Nice one Ryan, this looks good. one minor question/suggestion about whether we can always expect a 'type' key from block.get_partition_sfdisk_info and how we should handle it. Otherwise +1 Diff comments: > diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py > index f2bb8

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

Diff comments: > diff --git a/curtin/commands/block_meta.py b/curtin/commands/block_meta.py > index f2bb8da..ff0f2e9 100644 > --- a/curtin/commands/block_meta.py > +++ b/curtin/commands/block_meta.py > @@ -760,7 +760,9 @@ def verify_ptable_flag(devpath, expected_flag, > sfdisk_info=None): >

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

@Chad Yes, each partition entry has a type. -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : h

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

Kicking off a few vmtests -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.

[Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

The proposal to merge ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 -- Your team curtin developers is subscri

[Curtin-dev] [Merge] ~raharper/curtin:fix/multiple-carry-over-param-separators into curtin:master

Ryan Harper has proposed merging ~raharper/curtin:fix/multiple-carry-over-param-separators into curtin:master. Commit message: Handle multiple separators which were found in TestAllindata vmtest TestAllindata specifies additional kernel args and include the '---' separator. vmtest baseclass alre

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

vmtest says yes -- https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 Your team curtin developers is subscribed to branch curtin:master. -- Mailing list: https://launchpad.net/~curtin-dev Post to : curtin-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~curtin-

[Curtin-dev] [Merge] ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master

The proposal to merge ~raharper/curtin:fix/partition-verify-flags-msdos-primary-types into curtin:master has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~raharper/curtin/+git/curtin/+merge/384133 -- Your team curtin developers is subscribed to

Re: [Curtin-dev] [Merge] ~raharper/curtin:fix/multiple-carry-over-param-separators into curtin:master

Review: Approve continuous-integration PASSED: Continuous integration, rev:beafd4b0f34d6e3f56e26a11cc85594d7fa290f5 https://jenkins.ubuntu.com/server/job/curtin-ci/123/ Executed test runs: SUCCESS: https://jenkins.ubuntu.com/server/job/curtin-ci/nodes=metal-amd64/123/ SUCCESS: https://je