Re: [patch] several new features for cygrunsrv

2005-05-22 Thread Corinna Vinschen
Hi Brian, On May 21 18:40, Brian Dessent wrote: Corinna Vinschen wrote: I really like this patch, cool stuff. However, I have two nits. First, your patch adds new options, so it should also add some wording to cygrunsrv.README. Okay, here is a new patch. Thanks :-) *

Re: [patch] several new features for cygrunsrv

2005-05-22 Thread Brian Dessent
Corinna Vinschen wrote: I'm wondering if that's a good idea. Consider a script trying to evaluate `cygrunsrv -L -V' output. It sounds easier to check only for stdout path and stderr path instead for also a third, combined alternative. Okay, I've reverted that change. You won't be able to

Re: [patch] several new features for cygrunsrv

2005-05-21 Thread Brian Dessent
Corinna Vinschen wrote: I really like this patch, cool stuff. However, I have two nits. First, your patch adds new options, so it should also add some wording to cygrunsrv.README. Okay, here is a new patch. * --list outputs one service per line to avoid the awkward quoting issue. * checks

Re: [patch] several new features for cygrunsrv

2005-05-20 Thread Corinna Vinschen
On May 19 20:08, Igor Pechtchanski wrote: On Thu, 19 May 2005, Brian Dessent wrote: Since some services have spaces in their names, it might perhaps be a better idea to output one service name per line (I would even go so far as add a -0/--null option to end lines with '\0', but that's for a

[patch] several new features for cygrunsrv

2005-05-19 Thread Brian Dessent
(I realize this list is technically only for patches on cygwin, but cygrunsrv is close enough...) I've implemented some new features for cygrunsrv that I think might be useful to people. Examples follow. A new command -L / --list can be specified that will list all installed cygrunsrv

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Brian Dessent
Brian Dessent wrote: -controlsToString(DWORD controls) + char *base, *end; + static char buf[34]; + int used = 0, dsiz = strlen (delim); Crap, that is a mistake. buf[34] should be something more generous like 128 or 256. I had it set small to test to make sure it couldn't overflow and

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Corinna Vinschen
Hi Brian, I really like this patch, cool stuff. However, I have two nits. First, your patch adds new options, so it should also add some wording to cygrunsrv.README. On May 19 12:25, Brian Dessent wrote: for S in `cygrunsrv -L`; do cygrunsrv -E $S; done If a service name contains spaces it

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Brian Dessent
Corinna Vinschen wrote: I really like this patch, cool stuff. However, I have two nits. First, your patch adds new options, so it should also add some wording to cygrunsrv.README. On May 19 12:25, Brian Dessent wrote: for S in `cygrunsrv -L`; do cygrunsrv -E $S; done If a service

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Corinna Vinschen
On May 19 14:38, Brian Dessent wrote: Do you think the idea of having cygcheck include the --list --verbose output is worthwhile? I'll see to doing that if it's agreeable. Definitely. cygcheck mustn't rely on cygrunsrv being available, but if it is, it's -L -V output is valuable system config

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Christopher Faylor
On Thu, May 19, 2005 at 11:43:14PM +0200, Corinna Vinschen wrote: On May 19 14:38, Brian Dessent wrote: Do you think the idea of having cygcheck include the --list --verbose output is worthwhile? I'll see to doing that if it's agreeable. Definitely. cygcheck mustn't rely on cygrunsrv being

Re: [patch] several new features for cygrunsrv

2005-05-19 Thread Igor Pechtchanski
On Thu, 19 May 2005, Brian Dessent wrote: (I realize this list is technically only for patches on cygwin, but cygrunsrv is close enough...) Replying to the main Cygwin list. I've implemented some new features for cygrunsrv that I think might be useful to people. Examples follow. First