Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-20 Thread Corinna Vinschen
On Aug 19 19:31, Pedro Izecksohn wrote: > ChangeLog entry: > > 2010-08-19 Pedro Izecksohn > > * endian.h [_BSD_SOURCE || ! _POSIX_SOURCE] (htobe16, htobe32) > (htobe64, be16toh, be32toh, be64toh, htole16, htole32, htole64) > (le16toh, le32toh, le64toh): Macros defined. > >

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-19 Thread Pedro Izecksohn
ChangeLog entry: 2010-08-19 Pedro Izecksohn * endian.h [_BSD_SOURCE || ! _POSIX_SOURCE] (htobe16, htobe32) (htobe64, be16toh, be32toh, be64toh, htole16, htole32, htole64) (le16toh, le32toh, le64toh): Macros defined. I modified endian.h again: *** /usr/include/endi

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-18 Thread Corinna Vinschen
On Aug 17 22:44, Pedro Izecksohn wrote: > --- Corinna Vinschen wrote: > > > > For this patch, given that it is just a bunch of rather obvious > > defines, I don't think we have to treat the patch as significant. > > I do not think that these macros are obvious. I think that I was > there when th

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-17 Thread Pedro Izecksohn
--- Corinna Vinschen wrote: > > For this patch, given that it is just a bunch of rather obvious > defines, I don't think we have to treat the patch as significant. I do not think that these macros are obvious. I think that I was there when these macros were first implemented at 1987: I talked wi

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-17 Thread Corinna Vinschen
Pedro, first of all, did you read http://cygwin.com/contrib.html? Especially the "Before you get started" section. For this patch, given that it is just a bunch of rather obvious defines, I don't think we have to treat the patch as significant. However, please don't use _BSD_SOURCE. The newli

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-16 Thread Pedro Izecksohn
As this thread went nowhere, I searched for the BSD code: http://svn.freebsd.org/viewvc/base/stable/8/sys/sys/endian.h?revision=199583&view=markup It uses x to represent the variable as I did; but it also casts the variable. I think that casting is not desirable because I like to see warnin

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-14 Thread Pedro Izecksohn
--- I wrote: >> The x glyph represents the different ways to represent the same number: >> ... >> I thought to use (i) of integer, but its glyph does not remember the >> proverb about Rome. --- Corinna Vinschen asked: > You mean "What have the Romans ever done for us?"   "All roads lead to Rome."

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-14 Thread Corinna Vinschen
On Aug 13 19:11, Pedro Izecksohn wrote: > I thought to use (i) of integer, but its glyph does not remember the > proverb about Rome. You mean "What have the Romans ever done for us?" Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Project Co-Leader

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-13 Thread Pedro Izecksohn
> Umm - did you copy straight from glibc's endian.h?  That's a no-no; > cygwin generally doesn't want to borrow LGPL sources to avoid any > licensing questions (borrowing from BSD is okay, on the other hand). > You would have to implement things from scratch from a documentation > page, or copy fro

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-13 Thread Pedro Izecksohn
--- Eric Blake wrote: > > Umm - did you copy straight from glibc's endian.h?  That's a no-no; > cygwin generally doesn't want to borrow LGPL sources to avoid any > licensing questions (borrowing from BSD is okay, on the other hand). > You would have to implement things from scratch from a document

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-13 Thread Eric Blake
On 08/12/2010 06:35 PM, Pedro Izecksohn wrote: > --- I wrote: >> Defines macros for to convert the endianness of 16, 32 and 64 bits >> integer types. >> >> diff -c /usr/include/endian.orig.h /usr/include/endian.h > > My previous diff is wrong. The right one follows: OK, that documents _what_ your

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-12 Thread Pedro Izecksohn
--- I wrote: > Defines macros for to convert the endianness of 16, 32 and 64 bits > integer types. > > diff -c /usr/include/endian.orig.h /usr/include/endian.h My previous diff is wrong. The right one follows: *** /usr/include/endian.orig.h Mon Apr 12 14:09:58 2010 --- /usr/include/endian.h

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-12 Thread Pedro Izecksohn
--- Eric Blake wrote: > Christopher Faylor wrote: >> I wrote: >>>  I hope this list accepts attachments. >> >> It does but the list mind-reading gizmo is on the fritz. > > Translation - a ChangeLog entry justifying your changes, a diff in > unified or context format (-u or -c) rather than the defau

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-12 Thread Eric Blake
On 08/12/2010 04:58 PM, Christopher Faylor wrote: > On Thu, Aug 12, 2010 at 07:56:31PM -0300, Pedro Izecksohn wrote: >> I hope this list accepts attachments. > > It does but the list mind-reading gizmo is on the fritz. Translation - a ChangeLog entry justifying your changes, a diff in unified or

Re: diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-12 Thread Christopher Faylor
On Thu, Aug 12, 2010 at 07:56:31PM -0300, Pedro Izecksohn wrote: > I hope this list accepts attachments. It does but the list mind-reading gizmo is on the fritz. -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://

diff /usr/include/endian.orig.h /usr/include/endian.h > endian.h.diff

2010-08-12 Thread Pedro Izecksohn
I hope this list accepts attachments. endian.h.diff Description: Binary data -- Problem reports: http://cygwin.com/problems.html FAQ: http://cygwin.com/faq/ Documentation: http://cygwin.com/docs.html Unsubscribe info: http://cygwin.com/ml/#unsubscribe-simple