AW: Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Boris Schaeling
> -Ursprüngliche Nachricht- > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag > von Corinna Vinschen > Gesendet: Freitag, 15. März 2002 23:28 > An: [EMAIL PROTECTED] > Betreff: Re: Latest poll() hangs again (was Re: poll() bugs and patch) > [...] >

Re: Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Corinna Vinschen
On Fri, Mar 15, 2002 at 04:33:21PM -0500, Chris Faylor wrote: > On Fri, Mar 15, 2002 at 10:19:40PM +0100, Corinna Vinschen wrote: > >On Fri, Mar 15, 2002 at 03:01:21PM -0500, Jason Tishler wrote: > >> Please revert this patch or modify it so that poll() does not hang. > > > >I don't think revertin

RE: Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Robert Collins
> -Original Message- > From: Christopher Faylor > Sent: Saturday, March 16, 2002 8:33 AM > How does linux handle these cases? FWIW: According to Jason's http://sources.redhat.com/ml/cygwin-patches/2001-q3/msg00109.html email, Redhat 7.1 handled it identically to the way his patch did.

Re: Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Christopher Faylor
On Fri, Mar 15, 2002 at 10:19:40PM +0100, Corinna Vinschen wrote: >On Fri, Mar 15, 2002 at 03:01:21PM -0500, Jason Tishler wrote: >> On Thu, Mar 14, 2002 at 01:15:54PM +0100, Corinna Vinschen wrote: >> > Thanks for the patch. I've applied it with some changes. >> >> I was concerned when I first

Re: Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Corinna Vinschen
On Fri, Mar 15, 2002 at 03:01:21PM -0500, Jason Tishler wrote: > On Thu, Mar 14, 2002 at 01:15:54PM +0100, Corinna Vinschen wrote: > > Thanks for the patch. I've applied it with some changes. > > I was concerned when I first saw this patch. Unfortunately, I just > tried it and my concerns were

Latest poll() hangs again (was Re: poll() bugs and patch)

2002-03-15 Thread Jason Tishler
On Thu, Mar 14, 2002 at 01:15:54PM +0100, Corinna Vinschen wrote: > Thanks for the patch. I've applied it with some changes. I was concerned when I first saw this patch. Unfortunately, I just tried it and my concerns were realized. This patch causes poll() to hang again when only an invalid fi

AW: poll() bugs and patch

2002-03-14 Thread Boris Schaeling
> -Ursprüngliche Nachricht- > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag > von Corinna Vinschen > Gesendet: Donnerstag, 14. März 2002 13:16 > An: cygwin > Betreff: Re: poll() bugs and patch > [...] > Thanks for the patch. I've applied it

Re: poll() bugs and patch

2002-03-14 Thread Corinna Vinschen
On Wed, Mar 13, 2002 at 10:20:30PM +0100, Boris Schaeling wrote: > > Ok with me. However, I'll not take that patch w/o a ChangeLog entry. > > Please create one, Boris. > > Here they are: > - change.log > - poll.patch > - newpoll.cc (new implementation) > - polltest.c (testcase) Thanks for the p

AW: poll() bugs and patch

2002-03-13 Thread Boris Schaeling
> -Ursprüngliche Nachricht- > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag > von Corinna Vinschen > Gesendet: Mittwoch, 13. März 2002 18:14 > An: [EMAIL PROTECTED] > Betreff: Re: poll() bugs and patch > [...] > > Actually, I'm inclined

Re: poll() bugs and patch

2002-03-13 Thread Corinna Vinschen
On Wed, Mar 13, 2002 at 11:39:24AM -0500, Chris Faylor wrote: > On Wed, Mar 13, 2002 at 04:36:41PM +0100, Corinna Vinschen wrote: > >Uhm, I'm still not sure about this. Perhaps Chris can enlighten > >us. You're not the first one asking... > > Actually, I'm inclined to just let this one in. The

Re: poll() bugs and patch

2002-03-13 Thread Christopher Faylor
On Wed, Mar 13, 2002 at 04:36:41PM +0100, Corinna Vinschen wrote: >Uhm, I'm still not sure about this. Perhaps Chris can enlighten >us. You're not the first one asking... Actually, I'm inclined to just let this one in. There isn't a lot of new code, it's mainly just rearranged. FWIW, faxing i

Re: poll() bugs and patch

2002-03-13 Thread Corinna Vinschen
On Wed, Mar 13, 2002 at 04:28:24PM +0100, Boris Schaeling wrote: > > -Ursprüngliche Nachricht- > > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag > > von Corinna Vinschen > > Gesendet: Mittwoch, 13. März 2002 15:06 > > An: [EMAIL PROTECTED] &g

AW: poll() bugs and patch

2002-03-13 Thread Boris Schaeling
> -Ursprüngliche Nachricht- > Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag > von Corinna Vinschen > Gesendet: Mittwoch, 13. März 2002 15:06 > An: [EMAIL PROTECTED] > Betreff: Re: poll() bugs and patch > [...] > Thanks for the patch but tha

Re: poll() bugs and patch

2002-03-13 Thread Corinna Vinschen
On Wed, Mar 13, 2002 at 02:30:35PM +0100, Boris Schaeling wrote: > There are several bugs in poll(): > - poll() must return 0 if no descriptor is ready and the timer expires. It > works correctly if all descriptors are non-negative. Otherwise poll() > returns the count of negative descriptors whic

poll() bugs and patch

2002-03-13 Thread Boris Schaeling
There are several bugs in poll(): - poll() must return 0 if no descriptor is ready and the timer expires. It works correctly if all descriptors are non-negative. Otherwise poll() returns the count of negative descriptors which is wrong. - The implementation of poll() must call cygwin_select() even