Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-14 Thread Corinna Vinschen
On Jan 13 20:07, Thomas Waldmann wrote: > On 01/13/2017 07:18 PM, Thomas Waldmann wrote: > > It was a bug in our code that was triggered frequently by the small > > cygwin pipe buffer size of only 64kiB. > > > > borgbackup fix/workaround see there: > > > >

Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-13 Thread Thomas Waldmann
On 01/13/2017 07:18 PM, Thomas Waldmann wrote: > It was a bug in our code that was triggered frequently by the small > cygwin pipe buffer size of only 64kiB. > > borgbackup fix/workaround see there: > > https://github.com/borgbackup/borg/pull/2032 > > It (almost?) never happened on other OSes,

Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-13 Thread Thomas Waldmann
It was a bug in our code that was triggered frequently by the small cygwin pipe buffer size of only 64kiB. borgbackup fix/workaround see there: https://github.com/borgbackup/borg/pull/2032 It (almost?) never happened on other OSes, due to their bigger buffers. Note: It would be nice to have

Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-12 Thread Thomas Waldmann
>> https://github.com/borgbackup/borg/issues/1268 > > Are your pipe handles in open in binary mode or text mode? You should > always ensure they are in binary mode. That was my first idea also. https://github.com/borgbackup/borg/blob/1.0.9/borg/remote.py#L188 this is the place where the ssh

Re: borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-12 Thread cyg Simple
On 1/10/2017 10:47 PM, Thomas Waldmann wrote: > Hi, > > borgbackup uses a RPC protocol via a ssh pipe to implement client/server > communication. > > borg client --pipe-- ssh --tcp-- sshd --pipe-- borg serve > > This works very reliable, we have tests running on linux, freebsd, > netbsd,

borgbackup test fail on cygwin (only) - cygwin pipe issues?

2017-01-10 Thread Thomas Waldmann
Hi, borgbackup uses a RPC protocol via a ssh pipe to implement client/server communication. borg client --pipe-- ssh --tcp-- sshd --pipe-- borg serve This works very reliable, we have tests running on linux, freebsd, netbsd, openbsd, OS X. It even works on win10 linux subsystem. But on Cygwin,