Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Takashi Yano via Cygwin-patches
On Wed, 26 Aug 2020 19:33:45 +0200 Corinna Vinschen wrote: > On Aug 26 09:30, Johannes Schindelin wrote: > > Hi Corinna, > > > > On Wed, 26 Aug 2020, Corinna Vinschen wrote: > > > > > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > > > When Cygwin sets console titles on Win10

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Corinna Vinschen
On Aug 26 09:30, Johannes Schindelin wrote: > Hi Corinna, > > On Wed, 26 Aug 2020, Corinna Vinschen wrote: > > > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > > When Cygwin sets console titles on Win10 (has_con_24bit_colors > > > !con_is_legacy), > > > `WriteConsoleA` is used and causes

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Johannes Schindelin
Hi Corinna, On Wed, 26 Aug 2020, Corinna Vinschen wrote: > On Aug 26 16:43, 宫大汉 via Cygwin-patches wrote: > > When Cygwin sets console titles on Win10 (has_con_24bit_colors > > !con_is_legacy), > > `WriteConsoleA` is used and causes an error if: > > 1. the environment variable of `LANG` is

Re: [Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread Corinna Vinschen
34f52a53a2e6b7f560b0e8810b9f672ebb3ad24 Mon Sep 17 00:00:00 2001 > From: Dahan Gong Date: Fri, 31 Jul 2020 22:06:54 +0800 > Subject: [PATCH] Fix incorrect code page in console title > > > `WriteConsoleA` always follows the current code page of a console window, so > it's not suit

[Patch] Fix incorrect code page when setting console title on Win10

2020-08-26 Thread 宫大汉 via Cygwin-patches
When Cygwin sets console titles on Win10 (has_con_24bit_colors !con_is_legacy), `WriteConsoleA` is used and causes an error if: 1. the environment variable of `LANG` is `***.UTF-8` 2. and the code page of console.exe is not UTF-8 1. e.g. on my Computer, it's GB2312, for Chinese text I've done

Re: Console title

2003-06-14 Thread Micha Nelissen
Hi, This makes the set title go after the current title, instead of replacing it. You need to enable hardstatus support in termcap to be able to notice the difference. In particular the entries 'hs', 'fs', 'ts' and 'ds' are needed. See 'man screen'. You have offered no justification for

Re: console title

2002-11-14 Thread Hironori SAKAMOTO
I'm sorry again. I forgot that some charsets like ISO-8859 have character \377. When a window title of cygwin console is displayed with escape sequence (\033]0;title\007), it can't be displayed if it includes non-ASCII characters (\200..\0377). Is the following patch acceptable ? ---

Re: console title

2002-11-14 Thread Christopher Faylor
On Thu, Nov 14, 2002 at 11:46:23PM +0900, Hironori SAKAMOTO wrote: Sorry, I made a mistake. When a window title of cygwin console is displayed with escape sequence (\033]0;title\007), it can't be displayed if it includes non-ASCII characters (\200..\0377). Is the following patch acceptable ?

Re: console title

2002-11-14 Thread Igor Pechtchanski
On Thu, 14 Nov 2002, Christopher Faylor wrote: On Thu, Nov 14, 2002 at 11:46:23PM +0900, Hironori SAKAMOTO wrote: Sorry, I made a mistake. When a window title of cygwin console is displayed with escape sequence (\033]0;title\007), it can't be displayed if it includes non-ASCII

Re: console title

2002-11-14 Thread Christopher Faylor
On Thu, Nov 14, 2002 at 12:52:04PM -0500, Igor Pechtchanski wrote: Are characters signed, or unsigned? Take a look at the source: http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/winsup/cygwin/fhandler_console.cc?rev=1.95cvsroot=src cgf --- fhandler_console.cc.orig Thu Nov 14 14:51:30 2002

Re: console title

2002-11-14 Thread Igor Pechtchanski
Ouch. I actually did before I sent the message... The source uses plain char declaration. The signedness of that, IIRC, depends on the compile-time gcc flags, or gcc defaults. Hence the question. Igor On Thu, 14 Nov 2002, Christopher Faylor wrote: On Thu, Nov 14, 2002 at 12:52:04PM

console title

2002-11-13 Thread Hironori SAKAMOTO
Hello, When a window title of cygwin console is displayed with escape sequence (\033]0;title\007), it can't be displayed if it includes non-ASCII characters (\200..\0377). Is the following patch acceptable ? --- fhandler_console.cc.origThu Nov 14 14:51:30 2002 +++ fhandler_console.cc Thu