Re: [PATCH setup v2 0/2] Improve the handling of command line package selection

2018-06-10 Thread Jon Turney
On 07/06/2018 18:37, Ken Brown wrote: Suppose an installed package A gets updated because of the "--packages A" command line option. If A requires a version of package B higher than the installed version, then B will also need to be updated. Moreover, if the "--upgrade-also" option hasn't been

Re: setup: uninstalling an orphaned package

2018-06-10 Thread Jon Turney
On 27/03/2018 20:04, Ken Brown wrote: On 3/26/2018 1:55 PM, Ken Brown wrote: In ChooserPage::applyCommandLinePackageSelection() we have the following code:    bool wanted    = pkg.isManuallyWanted();    bool deleted   = pkg.isManuallyDeleted();    bool basemisc  =

Re: [PATCH setup 1/3] Make sure that the IniDBBuilderPackage destructor is called when needed

2018-06-10 Thread Jon Turney
On 17/03/2018 14:59, Ken Brown wrote: The IniDBBuilderPackage destructor contains code that is intended to be run after each setup.ini file is processed. But the IniDBBuilderPackage variables in do_local_ini() and do_remote_ini were declared outside the loop that processed the files. Move the