Re: [PATCH cygport] Add customization support for announce command

2024-05-01 Thread Christian Franke via Cygwin-apps
Adam Dinwoodie via Cygwin-apps wrote: On Tue, Apr 30, 2024 at 12:27:35PM +0200, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 10/03/2024 16:33, Christian Franke via Cygwin-apps wrote: +    /bin/bash -c "cd ${top} || exit 1 +${HOMEPAGE+HOMEPAGE=${HOMEPAGE@Q}} +P=${P@Q}; PF

Re: [PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-05-01 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-04-30 15:07, Christian Franke via Cygwin-apps wrote: Brian Inglis via Cygwin-apps wrote: On 2024-04-30 11:45, Christian Franke via Cygwin-apps wrote: The new script uses the SPDX webpages to create the license file. I didn't find a usable single

Re: [PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-04-30 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-04-30 11:45, Christian Franke via Cygwin-apps wrote: ... Attached. The new script uses the SPDX webpages to create the license file. I didn't find a usable single license list at https://github.com/spdx What about: https://spdx.github.io

[PATCH cygport] Add check of SPDX expression provided by LICENSE variable

2024-04-30 Thread Christian Franke via Cygwin-apps
Jon Turney via Cygwin-apps wrote (thread "[PATCH cygport] Add repro-finish command"): ... PS: I have a local script which checks SPDX Identifiers and expressions. Any interest to add this to cygport and then check LICENSE settings? Oh, yes please. That sounds like a good idea. Attached.

Re: [PATCH cygport] Add customization support for announce command

2024-04-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 10/03/2024 16:33, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due

Re: [PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-04-28 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: _FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 13.2.1 test release. Silently falls back to level 2 if level 3 is unsupported (older headers or gcc) or to level 0 if unsupported at all (C++, clang

Re: [ITP] afflib 3.7.20-1

2024-03-22 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: marco atzeri wrote: On Wed, Mar 6, 2024 at 11:26 PM Christian Franke via Cygwin-apps  wrote: ... Should I also rename libtsk to libtsk19 in the planned sleutkit-*-2 package which will add afflib support ? yes please The original package is only a few days old and has

Re: [ITP] afflib 3.7.20-1

2024-03-21 Thread Christian Franke via Cygwin-apps
On Wed, 6 Mar 2024 23:26:05 +0100, Christian Franke wrote: Jon Turney wrote: ... be added only when needed for new not backward compatible releases. The upstream afflib project is mostly idling, so I don't expect any new major lib versions in the near future. If course, I could rename it

[ITP] mandoc 1.14.6-1

2024-03-11 Thread Christian Franke via Cygwin-apps
I would like to contribute mandoc. Also present in Debian, Fedora, Ubuntu, ... and as the default man page formatter on *BSD. Useful to check man pages for compatibility with *BSD systems. The build is reproducible without the need to export SOURCE_DATE_EPOCH. SUMMARY="BSD mandoc compiler

[PATCH cygport] Add repro-finish command

2024-03-11 Thread Christian Franke via Cygwin-apps
Thanks for accepting the repro-check patch. A minor enhancement is attached. The function is in pkg_pkg.cygpart instead of pkg_cleanup.cygpart because then it is easier to keep it in sync with the other __repro_* functions. PS: I have a local script which checks SPDX Identifiers and

Re: [PATCH cygport] Add customization support for announce command

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 23/02/2024 11:23, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due to the hard-coded email submission. The attached patch adds more flexibility

Re: [PATCH cygport] dodoc: Skip a file if a compressed version already exists

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 01/03/2024 13:13, Christian Franke via Cygwin-apps wrote: It IMO makes sense to compress large and rarely viewed doc files like change logs. This seems to be common practice on Debian etc. With current cygport, the following results in ChangeLog and ChangeLog.gz

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 26/02/2024 19:53, Christian Franke via Cygwin-apps wrote: Would it not make more sense to just re-export it if set? If the cygport file decides to set but not export it, there is possibly no need to do it. An example is smartmontools.cygport which passes

[ITP] bmake 20240301-1

2024-03-09 Thread Christian Franke via Cygwin-apps
I would like to contribute bmake. Also present in Debian, Fedora, FreeBSD, Ubuntu, ... I occasionally use it to check whether Makefiles are compatible with non-GNU versions of make. SUMMARY="Portable version of the NetBSD 'make' utility" DESCRIPTION="\ bmake is a portable version of the

Re: [ITP] afflib 3.7.20-1

2024-03-08 Thread Christian Franke via Cygwin-apps
marco atzeri wrote: On Wed, Mar 6, 2024 at 11:26 PM Christian Franke via Cygwin-apps wrote: Jon Turney wrote: On 06/03/2024 15:39, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package do

Re: [ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 06/03/2024 15:39, Christian Franke via Cygwin-apps wrote: Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package doesn't include the soversion, i.e. why not libafflib0? Libtsk and libafflib are my first li

Re: [ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: Thanks! libafflib_CONTENTS=" usr/bin/cygafflib-*.dll Any reason why this package doesn't include the soversion, i.e. why not libafflib0? Libtsk and libafflib are my first library packages, so I'm not sure what the policy is. My recent package libtsk has been

[ITP] afflib 3.7.20-1

2024-03-06 Thread Christian Franke via Cygwin-apps
I would like to contribute afflib. Also present in Debian, Fedora, Ubuntu, ... but package naming differs: Debian/Ubuntu: afflib-tools, libafflib0v5, libafflib-dev Fedora: afftools, afflib, afflib-devel It is indented to enable afflib format support for the next version of the sleuthkit

Re: [ITP] sleuthkit 4.12.1

2024-03-02 Thread Christian Franke via Cygwin-apps
Hi Marco, Marco Atzeri via Cygwin-apps wrote: On 02/03/2024 13:05, Christian Franke via Cygwin-apps wrote: I would like to contribute sleuthkit. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Tools for analysis of volume and filesystem data" DESCRIPTION="The

[ITP] sleuthkit 4.12.1

2024-03-02 Thread Christian Franke via Cygwin-apps
I would like to contribute sleuthkit. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Tools for analysis of volume and filesystem data" DESCRIPTION="The Sleuth Kit (TSK) is a collection of command line tools for disk images.  It allows to analyze volume and filesystem data, examine disk

Re: [PATCH cygport] Add repro-check command

2024-03-01 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: This could be used to check whether a package is possibly reproducible. Then it could make sense to add a reasonable SOURCE_DATE_EPOCH value to the cygport file. Example: $ export SOURCE_DATE_EPOCH=$(date +%s) $ cygport project.cygport all repro-check ... *** Info:

[PATCH cygport] dodoc: Skip a file if a compressed version already exists

2024-03-01 Thread Christian Franke via Cygwin-apps
It IMO makes sense to compress large and rarely viewed doc files like change logs. This seems to be common practice on Debian etc. With current cygport, the following results in ChangeLog and ChangeLog.gz in the docdir: src_install() {   ...   dodoc ChangeLog   gzip -9 -n

Re: [PATCH cygport] Set TZ=UTC if SOURCE_DATE_EPOCH is used

2024-02-28 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: Further tests of 'repro-check' patch revealed that the "origsrc/*" timestamps in patch files contain the local timezone offset. This would be no longer needed for patch files if "Modify origsrc timestamp in patch files if SOURCE_DATE_EPOCH is used" would be applied.

[PATCH cygport] Modify origsrc timestamp in patch files if SOURCE_DATE_EPOCH is used

2024-02-28 Thread Christian Franke via Cygwin-apps
Found during testing of 'repro-check' patch with getent-2.18.90-5 source package. This patch also removes the requirement to set TZ=UTC before patches are generated. -- Regards, Christian From 342ff5113499a83b2ffda441ddc80b4952b400f8 Mon Sep 17 00:00:00 2001 From: Christian Franke Date:

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-26 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 16/02/2024 12:29, Christian Franke via Cygwin-apps wrote: Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not exported. What is the valid range here? The range accepted by 'date -d @EPOCH ...', later used to adjust

[PATCH cygport] Fix variable expansion in error message of embedded SMTP perl script

2024-02-23 Thread Christian Franke via Cygwin-apps
Harmless bug ... -- Regards, Christian From b1074f4cfe549c852be7fa59d85d312c9579cf0d Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 23 Feb 2024 13:04:21 +0100 Subject: [PATCH] Fix variable expansion in error message of embedded SMTP perl script --- lib/pkg_upload.cygpart | 2 +-

Re: [PATCH cygport] Add customization support for announce command

2024-02-23 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due to the hard-coded email submission. The attached patch adds more flexibility. The patch is on top of the "Use correct wording if only one package is announced"

Re: [PATCH cygport] Use correct wording if only one package is announced

2024-02-23 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2024-02-21 07:25, Christian Franke via Cygwin-apps wrote: Change variable name from $s to $has or $s_have as variable $s usually implies only the plural letter s or nothing; e.g. ... +    local has="s have" + +    [ $pkg_count != 1 ] ||

[PATCH cygport] Add customization support for announce command

2024-02-21 Thread Christian Franke via Cygwin-apps
The email generated by the cygport announce command is useful, but actual use cases are somewhat limited due to the hard-coded email submission. The attached patch adds more flexibility. The patch is on top of the "Use correct wording if only one package is announced" patch. Examples for

[PATCH cygport] Use correct wording if only one package is announced

2024-02-21 Thread Christian Franke via Cygwin-apps
Only cosmetic ... -- Regards, Christian From f1381ebc872f3b099c257677e2b8d5bf2451bb23 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Wed, 21 Feb 2024 13:35:14 +0100 Subject: [PATCH] Use correct wording if only one package is announced --- lib/pkg_upload.cygpart | 5 - 1 file

[PATCH cygport] Set TZ=UTC if SOURCE_DATE_EPOCH is used

2024-02-20 Thread Christian Franke via Cygwin-apps
Further tests of 'repro-check' patch revealed that the "origsrc/*" timestamps in patch files contain the local timezone offset. The attached patch is on top of the "Add more checks of SOURCE_DATE_EPOCH" patch. It could also be applied independently but then requires conflict resolution due to

[PATCH cygport] Add repro-check command

2024-02-18 Thread Christian Franke via Cygwin-apps
This could be used to check whether a package is possibly reproducible. Then it could make sense to add a reasonable SOURCE_DATE_EPOCH value to the cygport file. Example: $ export SOURCE_DATE_EPOCH=$(date +%s) $ cygport project.cygport all repro-check ... *** Info: Build reproducibility test

[ITP] f3 8.0

2024-02-17 Thread Christian Franke via Cygwin-apps
I would like to contribute f3. Also present in Debian, Fedora, Ubuntu, ... SUMMARY="Test real flash memory capacity" DESCRIPTION="f3 is a simple tool that tests flash cards capacity and performance to see if they live up to claimed specifications. It fills the device with pseudorandom data and

[PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-16 Thread Christian Franke via Cygwin-apps
From b04c8f5e9becd6e91095e2add551f72870c9e869 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 16 Feb 2024 13:16:06 +0100 Subject: [PATCH] Add more checks of SOURCE_DATE_EPOCH Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not

Re: [PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-02-04 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 02/02/2024 16:13, Christian Franke via Cygwin-apps wrote: _FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 13.2.1 test release. Silently falls back to level 2 if level 3 is unsupported (older headers or gcc) or to level 0 if unsupported at all (C

[PATCH cygport] Increase _FORTIFY_SOURCE level from 2 to 3 in CFLAGS

2024-02-02 Thread Christian Franke via Cygwin-apps
_FORTIFY_SOURCE=3 is supported by Cygwin 3.5.0 headers and Cygwin gcc 13.2.1 test release. Silently falls back to level 2 if level 3 is unsupported (older headers or gcc) or to level 0 if unsupported at all (C++, clang). -- Regards, Christian From 1a32375682d0e5ff6b80a47de70d3d9cfe0f0780

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-10-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 28/08/2023 16:12, Christian Franke via Cygwin-apps wrote: Christian Franke wrote: A small step towards reproducible packaging... Thanks very much for this. Sorry for taking so long to look at it. No problem. A few questions and suggestions interspersed

Re: cygport may not create debug info if top directory contains a symlink

2023-10-30 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 20/09/2023 11:58, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-18 04:41, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote

[PATCH rebase] Fix handling of unset PE checksums

2023-10-09 Thread Christian Franke via Cygwin-apps
Tests with non-Cygwin executables show that other toolchains (LLVM LLD, MS link without /RELEASE option) leave the PE checksum field as zero. Peflags+rebase 4.6.6 still work correctly then, but rebase prints a misleading warning 'Checksum update failed' in this case. With the attached patch, a

Re: cygport may not create debug info if top directory contains a symlink

2023-09-20 Thread Christian Franke via Cygwin-apps
Brian Inglis wrote: On 2023-09-18 04:41, Christian Franke via Cygwin-apps wrote: Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote: Found during tests of busybox package: If the path of the top build directory

Re: cygport may not create debug info if top directory contains a symlink

2023-09-18 Thread Christian Franke via Cygwin-apps
Brian Inglis wrote: On 2023-09-17 08:01, Jon Turney via Cygwin-apps wrote: On 16/09/2023 15:17, Christian Franke via Cygwin wrote: Found during tests of busybox package: If the path of the top build directory contains a symlink and the project's build scripts normalize pathnames, no debug

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-29 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: If the build-path changes, more files differ (cygcheck.exe, ldd.exe, cygserver.exe) because __FILE__ is used and expands to an absolute path name. This could be fixed by adding -fmacro-prefix and/or -ffile-prefix arguments

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-28 Thread Christian Franke via Cygwin-apps
Christian Franke wrote: A small step towards reproducible packaging... Currently only tested with upcoming smartmontools package - contains only exe, man, doc files (no dll, lib, ...). Multiple cygport runs produce binary identical distribution tarballs if SOURCE_DATE_EPOCH (from the past)

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-24 Thread Christian Franke via Cygwin-apps
ASSI via Cygwin-apps wrote: Christian Franke via Cygwin-apps writes: If binutils, gzip and tar also would support this, the patch would be empty :-) GZip has -n though ... For gzip I decided to keep the timestamp and use (the GNU version of) touch instead. and GNU tar --mtime

Re: [PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-24 Thread Christian Franke via Cygwin-apps
Brian Inglis via Cygwin-apps wrote: On 2023-08-23 11:39, Christian Franke via Cygwin-apps wrote: A small step towards reproducible packaging... Currently only tested with upcoming smartmontools package - contains only exe, man, doc files (no dll, lib, ...). Multiple cygport runs produce

[PATCH cygport] Add initial support for SOURCE_DATE_EPOCH

2023-08-23 Thread Christian Franke via Cygwin-apps
A small step towards reproducible packaging... Currently only tested with upcoming smartmontools package - contains only exe, man, doc files (no dll, lib, ...). Multiple cygport runs produce binary identical distribution tarballs if SOURCE_DATE_EPOCH (from the past) is specified in the

Re: [PATCH rebase 1/2] Always update the file checksum in the PE header

2023-08-15 Thread Christian Franke via Cygwin-apps
Corinna Vinschen wrote: On Aug 12 14:26, Christian Franke via Cygwin-apps wrote: This patch is still experimental, but tested with all /bin/cyg*.dll from my installation. Does that mean I shouldn't apply it for now, or do you want me to apply it but not create a new release yet? Meantime I

[PATCH rebase 2/2] rebase: Don't update the PE header timestamp unless -t is used

2023-08-12 Thread Christian Franke via Cygwin-apps
This changes existing behavior but a new option --keep-timestamp is IMO not needed. -- Regards, Christian From 1c13ccb047ebfbcd2f239bedcd50a128fec659e9 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 12 Aug 2023 14:17:04 +0200 Subject: [PATCH] rebase: Don't update the PE header

[PATCH rebase 1/2] Always update the file checksum in the PE header

2023-08-12 Thread Christian Franke via Cygwin-apps
This patch is still experimental, but tested with all /bin/cyg*.dll from my installation. -- Regards, Christian From 53663d46c2c989e665143b33c0614b416fd1c666 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Sat, 12 Aug 2023 14:13:43 +0200 Subject: [PATCH] Always update the file checksum

Re: [PATCH rebase] rebase: Add -c, --checksum option

2023-08-08 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 08/08/2023 11:10, Christian Franke via Cygwin-apps wrote: Last patch for now. Left for later: ReBaseImage64() unconditionally updates the timestamp in the file header. Just for clarity: does this mean that rebasing as it is currently implemented leaves the PE file

[PATCH rebase] rebase: Add -c, --checksum option

2023-08-08 Thread Christian Franke via Cygwin-apps
Last patch for now. Left for later: ReBaseImage64() unconditionally updates the timestamp in the file header. -- Regards, Christian From 3973a92cf11056521552d9d3f87efe8e721e8c31 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 8 Aug 2023 12:04:25 +0200 Subject: [PATCH] rebase: Add

[PATCH rebase] Add missing pechecksum.* to SRC_DISTFILES

2023-08-08 Thread Christian Franke via Cygwin-apps
Missed yesterday, sorry. -- Regards, Christian From 84065da466d9501d0522af8860ea829ee51c12f5 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 8 Aug 2023 10:52:14 +0200 Subject: [PATCH] Add missing pechecksum.* to SRC_DISTFILES Signed-off-by: Christian Franke --- Makefile.in | 3

Re: [PATCH rebase] peflags: Fix ULONG range checks

2023-08-08 Thread Christian Franke via Cygwin-apps
Corinna Vinschen wrote: On Aug 8 10:06, Christian Franke via Cygwin-apps wrote: Corinna Vinschen via Cygwin-apps wrote: Hi Christian, On Aug 7 16:07, Christian Franke via Cygwin-apps wrote: Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian

Re: [PATCH rebase] peflags: Fix ULONG range checks

2023-08-08 Thread Christian Franke via Cygwin-apps
Corinna Vinschen via Cygwin-apps wrote: Hi Christian, On Aug 7 16:07, Christian Franke via Cygwin-apps wrote: Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian ... diff --git a/peflags.c b/peflags.c index 93eaa0b..d98b121 100644

[PATCH rebase 2/2] peflags: Add -k, --checksum option

2023-08-07 Thread Christian Franke via Cygwin-apps
This patch is on top of the --timestamp patch. Could not be applied to current HEAD without conflicts. -- Regards, Christian From 9ecaf86bff5d229bf5b2a1ba1ff4674526fc1b68 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 7 Aug 2023 15:52:14 +0200 Subject: [PATCH] peflags: Add -k,

[PATCH rebase 1/2] peflags: Add -p, --timestamp option

2023-08-07 Thread Christian Franke via Cygwin-apps
Running 'peflags -p /bin/*.exe' with the patch applied suggests that objcopy/strip recently changed behavior and no longer set timestamps to 0. Related: https://sourceware.org/bugzilla/show_bug.cgi?id=30702 -- Regards, Christian From 68d42574e4b7bbc0659708ce801b6cd25b88dc11 Mon Sep 17

[PATCH rebase] peflags: Fix ULONG range checks

2023-08-07 Thread Christian Franke via Cygwin-apps
Minor issue found during tests of the upcoming 'peflags --timestamp' patch. -- Regards, Christian From 9da405da78e92dc8263239e25365bee3167f185e Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Mon, 7 Aug 2023 13:42:50 +0200 Subject: [PATCH] peflags: Fix ULONG range checks Don't use

Re: [PATCH setup] Keyboard accelerator for keep or skip

2023-07-31 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 25/04/2023 18:00, Christian Franke via Cygwin-apps wrote: Use case: Easily prevent update of multiple packages in the "Pending" view, in particular useful if "Test" is selected. Sorry for the delay in looking at this.  Obviously needed. N.P. Please apply. Done.

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-27 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: ... Using std::set_intersection() on values from std::map() here is probably a mistake. It's simple to write, but the performance is not good. A faster alternative which avoids set_intersection calls in a loop is possibly to use one large data structure which maps

[PATCH setup] Keyboard accelerator for keep or skip

2023-04-25 Thread Christian Franke via Cygwin-apps
Use case: Easily prevent update of multiple packages in the "Pending" view, in particular useful if "Test" is selected. -- Regards, Christian From 05d9c72f07cf754dc6172a998b2e0991034d363f Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Tue, 25 Apr 2023 18:42:18 +0200 Subject: [PATCH]

Re: [PATCH setup 2/2] Detect filename collisions between packages

2023-04-24 Thread Christian Franke via Cygwin-apps
Jon Turney via Cygwin-apps wrote: Detect filename collisions between packages Don't check filenames under /etc/postinstall/ for collisions Report when filename collisions exist Add option '--collisions' to enable IMO a useful enhancement. Notes: Reading file catalog from a package is

Re: [PATCH setup] Add tooltip for Ctrl+I/R/U accelerator keys

2023-02-02 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 22/11/2022 16:00, Christian Franke wrote: This is a first try to make these keys more obvious as requested on the Cygwin ML. A more complex approach would be to mention only the keys which actually would change the current package state. Thanks for this patch. So, I

Re: [PATCH setup] Ignore reinstall requests if version is not accessible

2022-12-16 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 11/12/2022 15:11, Christian Franke via Cygwin-apps wrote: This prevents accidental package loss if reinstall is run from local directory but the package is no longer cached. Thanks.  This seems right, so please apply. Done. Could you please also review "[PATCH

[PATCH setup] Ignore reinstall requests if version is not accessible

2022-12-11 Thread Christian Franke via Cygwin-apps
This prevents accidental package loss if reinstall is run from local directory but the package is no longer cached. Possible further improvement: Do not offer "Reinstall" in the popup menu in this case. -- Regards, Christian From 054697c297a3e21ee5e63f51b27431640cab5cde Mon Sep 17 00:00:00