Re: Advice needed on ffcall packaging

On 2/21/2018 12:43 AM, Brian Inglis wrote: On 2018-02-20 11:41, Yaakov Selkowitz wrote: NAME=ffcall ... PKG_NAMES="libffcall0 libffcall-devel" libffcall0_CONTENTS=... libffcall_devel_OBSOLETES="ffcall" libffcall_devel_CONTENTS=... Does this generate the ("virtual") package setup entry for: @

Re: Advice needed on ffcall packaging

On 2/20/2018 1:41 PM, Yaakov Selkowitz wrote: On 2018-02-20 09:47, Ken Brown wrote: A few years ago I adopted ffcall (32-bit only) in order to keep it from disappearing from the distro: The latest upstream release builds on 64-bit Cygwin, so I'd like to update the package, and I'd like to find

Advice needed on ffcall packaging

A few years ago I adopted ffcall (32-bit only) in order to keep it from disappearing from the distro: https://sourceware.org/ml/cygwin-apps/2015-07/msg00092.html The latest upstream release builds on 64-bit Cygwin, so I'd like to update the package, and I'd like to find a sensible way of

Re: setup 2.887 release candidate - please test

be worth worrying about why. Ken From c860c1ce6045d6c42f0207f5977a269cbf48c53e Mon Sep 17 00:00:00 2001 From: Ken Brown <kbr...@cornell.edu> Date: Wed, 14 Feb 2018 17:48:44 -0500 Subject: [PATCH] Avoid crash if a source package is installed If a source package is installed, setup crashe

Re: stunnel 5.44 build fails

On 1/29/2018 3:32 PM, Andrew Schulman wrote: Prior to stunnel 5.42, I could build stunnel in Cygport with no src_compile function, just CYGCONF=--disable-fips Beginning with stunnel 5.42, the build fails with errors about "possibly undefined macro" AC_MSG_NOTICE and AC_DEFINE: I don't know

Re: [PATCH setup libsolv, v2] Let the user review added dependencies

On 1/24/2018 10:25 PM, Ken Brown wrote: On 1/24/2018 3:30 PM, Jon Turney wrote: On 22/01/2018 17:37, Ken Brown wrote: If the solver found no problems but added packages to resolve dependencies, ask the user whether they want to review the added packages before proceeding. If they answer Yes

Re: setup with experimental libsolv-based dependency solving

On 1/18/2018 2:15 PM, Jon Turney wrote: On 23/11/2017 18:08, Jon Turney wrote: I'm interested in opinion on what else is needed, before this can be released as 2.885 I think we're in pretty good shape except for the issue of letting the user see what's about to be done before we do it. My

[PATCH setup libsolv, v2] Let the user review added dependencies

If the solver found no problems but added packages to resolve dependencies, ask the user whether they want to review the added packages before proceeding. If they answer Yes, go back to the chooser with the 'Pending' view selected. The implementation adds several new members to the PrereqChecker

Re: setup libsolv UI: Silently install dependencies?

On 1/15/2018 12:31 PM, Ken Brown wrote: On 1/9/2018 8:32 AM, Jon Turney wrote: I'm not sure it's ideal to make a text report of this, though. Displaying it in the chooser somehow seems a better fit. (i.e. after you've made your selections, you get something like the "pending&

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/15/2018 2:01 PM, Jon Turney wrote: On 13/01/2018 19:56, Ken Brown wrote: On 1/13/2018 9:14 AM, Jon Turney wrote: On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work

Re: setup libsolv UI: Silently install dependencies?

thing easy. Ken From d183ee53ff0471f22fe2412381e8507e4c109b1e Mon Sep 17 00:00:00 2001 From: Ken Brown <kbr...@cornell.edu> Date: Mon, 15 Jan 2018 12:18:30 -0500 Subject: [PATCH] Let the user review added dependencies If the solver finds no problems but added packages to resolve dependencie

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/13/2018 8:52 PM, Brian Inglis wrote: On 2018-01-13 17:00, Ken Brown wrote: On 1/13/2018 5:55 PM, Ken Brown wrote: On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/13/2018 5:55 PM, Ken Brown wrote: On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the default solutions.  I'm not sure we want to "strongly recommend" the defaul

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/13/2018 4:29 PM, Brian Inglis wrote: On 2018-01-13 12:56, Ken Brown wrote: 2. We should probably remove, or at least reword, the dire warning about accepting the default solutions.  I'm not sure we want to "strongly recommend" the default solution over the other solution(s).  I

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/13/2018 9:14 AM, Jon Turney wrote: On 09/01/2018 15:49, Ken Brown wrote: On 1/9/2018 10:37 AM, Ken Brown wrote: I just did a quick test, trying to uninstall B in the situation above, and it didn't work as expected.  Even though "Uninstall A" was the first solution, A

harfbuzz bug

Hi Yaakov, FYI, I just had occasion to build harfbuzz 1.7.4 in connection with upstream TeX Live, and it needed a small tweak. I've filed a bug report here: https://github.com/harfbuzz/harfbuzz/issues/693 Ken

[PATCH setup v3] Query the user if a corrupt local file is found

Also reorganize package validation. Move the size-validation code in download.cc and the hash-validation code in install.cc into new member functions of the packagesource class. Add a bool member 'validated' to the class to make sure that the checking is done only once. Change

Re: [PATCH setup v2] Query the user if a corrupt local file is found

On 1/9/2018 5:25 PM, Ken Brown wrote: Also reorganize package validation. Move the size-validation code in download.cc and the hash-validation code in install.cc into new member functions of the packagesource class. Add a bool member 'validated' to the class to make sure that the checking

[PATCH setup v2] Query the user if a corrupt local file is found

Also reorganize package validation. Move the size-validation code in download.cc and the hash-validation code in install.cc into new member functions of the packagesource class. Add a bool member 'validated' to the class to make sure that the checking is done only once. Change

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/9/2018 10:37 AM, Ken Brown wrote: On 1/9/2018 8:25 AM, Jon Turney wrote: On 24/12/2017 15:00, Ken Brown wrote: On 12/13/2017 5:31 PM, Ken Brown wrote: On 12/13/2017 1:05 PM, Achim Gratz wrote: Ken Brown writes: 1. Uninstall A. 2. Don't uninstall B. On the surface, it would seem

Re: setup libsolv UI: Silently install dependencies?

On 1/9/2018 8:32 AM, Jon Turney wrote: On 05/01/2018 16:04, Ken Brown wrote: On 1/5/2018 10:48 AM, Jon Turney wrote: On 24/12/2017 23:23, Ken Brown wrote: Currently the libsolv version of setup silently installs added dependencies.  The user gets a chance to review them first only if libsolv

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 1/9/2018 8:25 AM, Jon Turney wrote: On 24/12/2017 15:00, Ken Brown wrote: On 12/13/2017 5:31 PM, Ken Brown wrote: On 12/13/2017 1:05 PM, Achim Gratz wrote: Ken Brown writes: 1. Uninstall A. 2. Don't uninstall B. On the surface, it would seem that libsolv chose 2 by default, because

Re: [PATCH setup] Query the user if a corrupt local file is found

On 1/5/2018 10:00 AM, Jon Turney wrote: On 16/12/2017 18:37, Ken Brown wrote: If a corrupt file is found in one of the selected mirror site directories, offer to delete it instead of making this a fatal error. Do this only on the first call to check_for cached().  If the corrupt file is still

Re: setup libsolv UI: Silently install dependencies?

On 1/5/2018 10:48 AM, Jon Turney wrote: On 24/12/2017 23:23, Ken Brown wrote: Currently the libsolv version of setup silently installs added dependencies.  The user gets a chance to review them first only if libsolv finds problems and has to display the prerequisite page. I'm not sure

Re: [PATCH setup] Make sure that fatal error messages are visible

On 12/21/2017 5:55 PM, Ken Brown wrote: On 12/20/2017 12:09 PM, Ken Brown wrote: On 12/20/2017 11:19 AM, Jon Turney wrote: On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup appeared

Re: setup libsolv UI: Silently install dependencies?

On 12/24/2017 6:23 PM, Ken Brown wrote: Currently the libsolv version of setup silently installs added dependencies.  The user gets a chance to review them first only if libsolv finds problems and has to display the prerequisite page. I'm not sure if this was a deliberate design decision

setup libsolv UI: Silently install dependencies?

the option. One possibility is a checkbox on the chooser page, which then gets saved in setup.rc as a user option. Are there other suggestions? Ken From e3c5d8ac0970d8a6bcb870aff2e6fe0e00ab5b44 Mon Sep 17 00:00:00 2001 From: Ken Brown <kbr...@cornell.edu> Date: Sun, 24 Dec 2017 16:05:33 -0500 S

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 12/13/2017 5:31 PM, Ken Brown wrote: On 12/13/2017 1:05 PM, Achim Gratz wrote: Ken Brown writes: 1. Uninstall A. 2. Don't uninstall B. On the surface, it would seem that libsolv chose 2 by default, because it returned an empty transaction list.  This was reflected in the log and was also

Re: [PATCH setup] Make sure that fatal error messages are visible

On 12/20/2017 12:09 PM, Ken Brown wrote: On 12/20/2017 11:19 AM, Jon Turney wrote: On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup appeared to hang. Fix this by giving fatal error

Re: [PATCH setup] Make sure that fatal error messages are visible

On 12/20/2017 10:02 PM, Brian Inglis wrote: On 2017-12-20 10:09, Ken Brown wrote: On 12/20/2017 11:19 AM, Jon Turney wrote: On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup

Re: [PATCH setup] Make sure that fatal error messages are visible

On 12/20/2017 11:19 AM, Jon Turney wrote: On 19/12/2017 00:53, Ken Brown wrote: The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup appeared to hang. Fix this by giving fatal error message boxes type MB_SETFOREGROUND

Re: [PATCH setup] Throw exceptions instead of exiting with error codes

On 12/20/2017 11:06 AM, Jon Turney wrote: On 19/12/2017 17:20, Ken Brown wrote: ---   Exception.h |  1 +   PickView.cc | 11 +++   choose.cc   |  7 +--   3 files changed, 13 insertions(+), 6 deletions(-) Yeah, silently dying seems like a bad idea. Hmmm... does this not need

[PATCH setup] Throw exceptions instead of exiting with error codes

--- Exception.h | 1 + PickView.cc | 11 +++ choose.cc | 7 +-- 3 files changed, 13 insertions(+), 6 deletions(-) diff --git a/Exception.h b/Exception.h index 7b16612..15a145e 100644 --- a/Exception.h +++ b/Exception.h @@ -36,6 +36,7 @@ private: #define APPERR_CORRUPT_PACKAGE 1

[PATCH setup] Make sure that fatal error messages are visible

The message box produced by TOPLEVEL_CATCH could be hidden by whatever window was previously being displayed, so that setup appeared to hang. Fix this by giving fatal error message boxes type MB_SETFOREGROUND. --- msg.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/msg.cc

Re: [PATCH setup] Query the user if a corrupt local file is found

On 12/18/2017 1:40 PM, Ken Brown wrote: On 12/16/2017 1:37 PM, Ken Brown wrote: If a corrupt file is found in one of the selected mirror site directories, offer to delete it instead of making this a fatal error. Do this only on the first call to check_for cached().  If the corrupt file is still

Re: [PATCH setup] Query the user if a corrupt local file is found

On 12/16/2017 1:37 PM, Ken Brown wrote: If a corrupt file is found in one of the selected mirror site directories, offer to delete it instead of making this a fatal error. Do this only on the first call to check_for cached(). If the corrupt file is still there on the second call

[PATCH setup] Query the user if a corrupt local file is found

If a corrupt file is found in one of the selected mirror site directories, offer to delete it instead of making this a fatal error. Do this only on the first call to check_for cached(). If the corrupt file is still there on the second call, then the deletion failed, and the user will have to fix

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 12/13/2017 1:05 PM, Achim Gratz wrote: Ken Brown writes: 1. Uninstall A. 2. Don't uninstall B. On the surface, it would seem that libsolv chose 2 by default, because it returned an empty transaction list. This was reflected in the log and was also clear when I selected 'Back'. I don't

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 12/5/2017 9:32 AM, Jon Turney wrote: It seems we're missing something to actually apply the default solution, so "accept default solutions" makes no changes, at the moment. (looks like we have to do this ourselves with solver_take_solution() ?) I've just looked at this again, and I'm not

setup libsolv: getting rid of ".any"

Jon, I've been trying to think of a way to get rid of the suffix ".any" that gets appended to package names. I think users will be confused by this when they see it in log files and, more importantly, in problem reports. The only thing I can come up with is patching libsolv so that

[PATCH setup draft 4/4] If signature validation is turned off, check 'release:' tag

If we aren't doing signature validation, look instead for "release: cygwin" in the setup.ini files. If this fails for an official mirror, reject the mirror. If it fails for a purported private mirror, silently change the status of the site to "user site" and put a note in the log file. This

[PATCH setup draft 0/4] Improve setup.ini validation

whether mirrors or not. Finally, sites specified on the command line are initially assumed to be mirrors until we can perform the above checks. [1] https://sourceware.org/ml/cygwin-apps/2017-12/msg00051.html Ken Brown (4): Allow validation of signatures using the cygwin key only Insist on cygwi

[PATCH setup draft 3/4] Try cygwin signing key for private mirrors

If validation with the cygwin signing key fails for a purported private mirror, retry with other supplied keys. If this succeeds, silently change the status of the site to "user site" and put a note in the log file. This change will take effect on the next setup run or if the user selects

[PATCH setup draft 2/4] Insist on cygwin signing key for official mirrors

If a mirror comes from mirrors.lst, validate the signature using the cygwin signing key only. --- ini.cc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ini.cc b/ini.cc index 18ab2e3..4be8263 100644 --- a/ini.cc +++ b/ini.cc @@ -292,8 +292,12 @@ do_remote_ini (HWND owner)

Re: [PATCH setup v4 0/6] Distinguish between user URLs and cygwin mirrors in UI

On 12/10/2017 12:49 PM, Ken Brown wrote: TODO: Implement a way of validating purported mirrors. For example, we could make sure they are signed with the cygwin signing key. Or if the user has used the -X option to turn off signature checking, we could make sure that setup.ini contains "re

[PATCH setup v4 5/6] Display full URLs of user sites and private mirrors

--- site.cc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/site.cc b/site.cc index 44cd114..a1a5e3f 100644 --- a/site.cc +++ b/site.cc @@ -207,6 +207,12 @@ site_list_type::site_list_type (const string &_url, idx = 0; } while (idx > 0); key += url; + if (!from_mirrors_lst)

[PATCH setup v4 3/6] Create new page UserSitePage for user URLs

nChecked (IDC_ALLOW_USER_URL); if (!allow_user_url) selected_usersite_list.clear (); + CheckControlsAndDisableAccordingly (); } break; } diff --git a/usersite.cc b/usersite.cc new file mode 100644 index 000..91cabe7 --- /d

[PATCH setup v4 6/6] Display area and location of official mirrors

From: Brian Inglis Mirrors from mirrors.lst have area and location info, which we now display and add to the sort key. For private mirrors, continue to display only the (full) URL, but make them sort last. Change site_list_type::operator== to compare URLs

[PATCH setup v4 1/6] Use the IDD_SITE dialog for cygwin.com mirrors only

Change wording in the dialog template to make it clear that this dialog is intended for mirrors only. Add a checkbox IDC_ALLOW_USER_URL; checking this sets a new boolean variable allow_user_url. In a future commit, this will enable a new page where the user can enter URLs for non-mirror package

[PATCH setup v4 0/6] Distinguish between user URLs and cygwin mirrors in UI

ian Inglis (1): Display area and location of official mirrors Ken Brown (5): Use the IDD_SITE dialog for cygwin.com mirrors only Use SitePage for cygwin.com mirrors only Create new page UserSitePage for user URLs Keep the mirror list sorted properly Display full URLs of user sites a

[PATCH setup v4 4/6] Keep the mirror list sorted properly

When site.cc:load_site_list() added a mirror whose URL was already in the list, it put the new entry in the same position as the old. Remove the old entry and merge the new one instead. --- site.cc | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/site.cc b/site.cc index

[PATCH setup v4 2/6] Use SitePage for cygwin.com mirrors only

Add a bool member 'site_list_type::is_mirror' to indicate whether a site is a mirror (possibly private) rather than a user URL (corresponding to a non-mirror package repo). Display only mirrors in the site chooser listbox. Rename several SiteList variables to indicate that they now contain only

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

On 12/8/2017 10:48 AM, Jon Turney wrote: On 07/12/2017 20:46, Ken Brown wrote: On 12/7/2017 1:35 PM, Jon Turney wrote: On 05/12/2017 17:32, Ken Brown wrote: On 12/5/2017 11:03 AM, Ken Brown wrote: On 12/5/2017 7:58 AM, Jon Turney wrote: The search textbox on the package chooser page needs

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

On 12/7/2017 11:55 PM, Brian Inglis wrote: On 2017-12-07 13:46, Ken Brown wrote: On 12/7/2017 1:35 PM, Jon Turney wrote: On 05/12/2017 17:32, Ken Brown wrote: On 12/5/2017 11:03 AM, Ken Brown wrote: On 12/5/2017 7:58 AM, Jon Turney wrote: The search textbox on the package chooser page needs

Re: [PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

On 12/7/2017 2:08 PM, Jon Turney wrote: On 07/12/2017 15:07, Ken Brown wrote: On 12/7/2017 8:55 AM, Jon Turney wrote: On 06/12/2017 22:15, Brian Inglis wrote: On 2017-12-06 14:55, Ken Brown wrote: On 12/6/2017 4:07 PM, Brian Inglis wrote: On 2017-12-06 13:45, Ken Brown wrote

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

On 12/7/2017 1:35 PM, Jon Turney wrote: On 05/12/2017 17:32, Ken Brown wrote: On 12/5/2017 11:03 AM, Ken Brown wrote: On 12/5/2017 7:58 AM, Jon Turney wrote: The search textbox on the package chooser page needs the same fix. It's not immediately clear to me how to do this, since I don't

Re: [PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

On 12/7/2017 8:55 AM, Jon Turney wrote: On 06/12/2017 22:15, Brian Inglis wrote: On 2017-12-06 14:55, Ken Brown wrote: On 12/6/2017 4:07 PM, Brian Inglis wrote: On 2017-12-06 13:45, Ken Brown wrote: This is a followup to     https://cygwin.com/ml/cygwin-apps/2011-04/msg00014.html, in which

Re: [PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

On 12/6/2017 4:07 PM, Brian Inglis wrote: On 2017-12-06 13:45, Ken Brown wrote: This is a followup to https://cygwin.com/ml/cygwin-apps/2011-04/msg00014.html, in which Jon suggested splitting site selection into two pages, one for cygwin.com mirrors and one for additional user URLs

[PATCH setup v3 4/6] Display full URLs in the user site list

--- site.cc | 6 ++ 1 file changed, 6 insertions(+) diff --git a/site.cc b/site.cc index accc264..98dd756 100644 --- a/site.cc +++ b/site.cc @@ -187,6 +187,12 @@ site_list_type::site_list_type (const string &_url, idx = 0; } while (idx > 0); key += url; + /* Display the full

[PATCH setup v3 3/6] Create new page UserSitePage for user URLs

ted_usersite_list.clear (); site_list = selected_mirror_list; } + CheckControlsAndDisableAccordingly (); } break; } diff --git a/usersite.cc b/usersite.cc new file mode 100644 index 000..34fc097 --- /dev/null +++ b/usersite.cc @@ -

[PATCH setup v3 6/6] Display area and location of mirrors, and add these to the sort key

From: Brian Inglis Also change site_list_type::operator== to compare URLs rather than keys, since the key no longer depends only on the URL. --- site.cc | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/site.cc b/site.cc index

[PATCH setup v3 0/6] Distinguish between user URLs and cygwin mirrors in UI

the full URL of each site to guarantee that there is no ambiguity. Brian Inglis (1): Display area and location of mirrors, and add these to the sort key Ken Brown (5): Use the IDD_SITE dialog for cygwin.com mirrors only Use SitePage for cygwin.com mirrors only Create new page UserSitePage

[PATCH setup v3 1/6] Use the IDD_SITE dialog for cygwin.com mirrors only

Remove controls related to adding a user URL. Add a checkbox IDC_ALLOW_USER_URL; checking this sets a new boolean variable allow_user_url. --- res.rc | 14 ++ resource.h | 1 + site.cc| 39 --- 3 files changed, 11 insertions(+), 43

[PATCH setup v3 5/6] Keep the mirror list sorted properly

When site.cc:load_site_list() added a mirror whose URL was already in the list, it put the new entry in the same position as the old. Remove the old entry and merge the new one instead. --- site.cc | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/site.cc b/site.cc index

[PATCH setup v3 2/6] Use SitePage for cygwin.com mirrors only

Keep separate lists of mirrors and user URLs. Rename several SiteList variables to indicate that they now contain only mirrors. Introduce a helper function remove_user_urls() to move non-mirrors from the initial list of sites to the list of user URLs. Set the initial state of allow_user_url

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 12/5/2017 9:32 AM, Jon Turney wrote: On 14/09/2017 21:46, Ken Brown wrote: On 9/14/2017 1:26 PM, Achim Gratz wrote: Ken Brown writes: What I've been struggling with, however, is the UI.  But now that I think about it, maybe it isn't that hard.  It's just a matter of doing something

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

On 12/5/2017 11:03 AM, Ken Brown wrote: On 12/5/2017 7:58 AM, Jon Turney wrote: Please apply. Done. The search textbox on the package chooser page needs the same fix. It's not immediately clear to me how to do this, since I don't know what the default pushbutton should be while the user

Re: [PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

On 12/5/2017 7:58 AM, Jon Turney wrote: Please apply. Done. The search textbox on the package chooser page needs the same fix. It's not immediately clear to me how to do this, since I don't know what the default pushbutton should be while the user is typing in the search box. One

Re: [PATCH setup v2 0/5] Distinguish between user URLs and cygwin mirrors in UI

On 12/4/2017 10:18 AM, Ken Brown wrote: This is the same as the previous patch series with one cosmetic improvement: I've now made user URLs sort last, so that the distinction between user URLs and cygwin.com mirrors is visually more clear. Sorry for repeatedly responding to myself, but I

[PATCH setup] Make Enter in the user URL box cause ADD instead of NEXT

--- site.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/site.cc b/site.cc index 641a6bb..64e56a8 100644 --- a/site.cc +++ b/site.cc @@ -759,7 +759,9 @@ bool SitePage::OnMessageCmd (int id, HWND hwndctl, UINT code) { case IDC_EDIT_USER_URL: { - //

[PATCH setup v2 4/5] Display full URL of non-mirrors in the site list

Set displayed_url to full URL in the site_list_type constructor if from_mirrors_lst is false. Modify check_for_user_urls() to change displayed_url back to the short form if a site in all_site_list turns out to be a stale mirror. --- site.cc | 32 +--- 1 file changed,

[PATCH setup v2 3/5] Adjust site list if IDC_ALLOW_USER_URL is unchecked

If the user unchecks the box, remove all sites except for fresh mirrors and selected stale mirrors. Introduce a new function remove_user_urls() to help with this --- site.cc | 35 +++ 1 file changed, 35 insertions(+) diff --git a/site.cc b/site.cc index

[PATCH setup v2 5/5] Make user URLs sort last in the displayed site list

Also fix load_site_list() so that when a mirror replaces an existing entry, the sort order is updated. Change site_list_type::operator== to compare URLs instead of sort keys, since the key of a user URL no longer depends solely on the URL. Introduce a new helper function merge_site(). ---

[PATCH setup v2 1/5] Add checkbox IDC_ALLOW_USER_URL to IDD_SITE dialog

Enable the "User URL" edit box and "Add" button only if IDC_ALLOW_USER_URL is checked. --- res.rc | 15 --- resource.h | 1 + site.cc| 15 +++ 3 files changed, 24 insertions(+), 7 deletions(-) diff --git a/res.rc b/res.rc index a4d7e70..b5dcb3e 100644 ---

[PATCH setup v2 0/5] Distinguish between user URLs and cygwin mirrors in UI

This is the same as the previous patch series with one cosmetic improvement: I've now made user URLs sort last, so that the distinction between user URLs and cygwin.com mirrors is visually more clear. Ken Brown (5): Add checkbox IDC_ALLOW_USER_URL to IDD_SITE dialog Set the initial state

[PATCH setup v2 2/5] Set the initial state of IDC_ALLOW_USER_URL

It starts checked if all_site_list contains a site that is not a cygwin.com mirror. Such a site would have to come from the "last-mirror" user setting, indicating that the user used a non-mirror on the last run. Introduce a new function check_for_user_urls() to help with this. --- site.cc | 26

Re: [PATCH setup 1/4] Add checkbox IDC_ALLOW_USER_URL to IDD_SITE dialog

On 12/3/2017 10:22 AM, Ken Brown wrote: Enable the "User URL" edit box and "Add" button only if IDC_ALLOW_USER_URL is checked. --- res.rc | 15 --- resource.h | 1 + site.cc| 14 ++ 3 files changed, 23 insertions(+), 7 deletions(-)

Re: [PATCH setup 0/4] Distinguish between user URLs and cygwin mirrors in UI

On 12/3/2017 1:06 PM, Brian Inglis wrote: On 2017-12-03 08:22, Ken Brown wrote: This is a followup to https://cygwin.com/ml/cygwin-apps/2011-04/msg00014.html . In that message Jon suggested splitting site selection into two pages, one for cygwin.com mirrors and one for additional user URLs

[PATCH setup 1/4] Add checkbox IDC_ALLOW_USER_URL to IDD_SITE dialog

Enable the "User URL" edit box and "Add" button only if IDC_ALLOW_USER_URL is checked. --- res.rc | 15 --- resource.h | 1 + site.cc| 14 ++ 3 files changed, 23 insertions(+), 7 deletions(-) diff --git a/res.rc b/res.rc index a4d7e70..b5dcb3e 100644 --- a/res.rc

[PATCH setup 3/4] Adjust site list if IDC_ALLOW_USER_URL is unchecked

If the user unchecks the box, remove all sites except for fresh mirrors and selected stale mirrors. Introduce a new function remove_user_urls() to help with this --- site.cc | 35 +++ 1 file changed, 35 insertions(+) diff --git a/site.cc b/site.cc index

[PATCH setup 0/4] Distinguish between user URLs and cygwin mirrors in UI

ked unless the "last-mirror" user setting in setup.rc contains a non-mirror. The button for adding a user URL is disabled unless the box is checked. Ken Brown (4): Add checkbox IDC_ALLOW_USER_URL to IDD_SITE dialog Set the initial state of IDC_ALLOW_USER_URL Adjust site list if IDC_ALLOW_U

[PATCH setup 4/4] Display full URL of non-mirrors in the site list

Set displayed_url to full URL in the site_list_type constructor if from_mirrors_lst is false. Modify check_for_user_urls() to change displayed_url back to the short form if a site in all_site_list turns out to be a stale mirror. --- site.cc | 32 +--- 1 file changed,

[PATCH setup 2/4] Set the initial state of IDC_ALLOW_USER_URL

It starts checked if all_site_list contains a site that is not a cygwin.com mirror. Such a site would have to come from the "last-mirror" user setting, indicating that the user used a non-mirror on the last run. Introduce a new function check_for_user_urls() to help with this. --- site.cc | 26

Re: [PATCH setup 0/3] Fix "extrakeys" issues

On 11/28/2017 9:56 AM, Ken Brown wrote: The "extrakeys" user setting contains saved extra gpg keys. It was introduced in 2009 to replace the use of a file /etc/setup/last-extrakeys. It has apparently never worked right. Here are the issues I've found: - User settings are read a

[PATCH setup 2/3] Change the interpretation of '#' in setup.rc

'#' was treated as a comment character in all circumstances. Since saved gpg keys contain '#', this caused the "extrakeys" user setting to get truncated. Change this so that '#' only indicates a comment if it's the first non-whitespace character in a line. --- UserSettings.cc | 8 1

[PATCH setup 0/3] Fix "extrakeys" issues

attempts to fix all these problems. In the case of '#', the fix is to treat '#' as a comment character only if it's the first non-whitespace character on a line. I don't think this will cause problems for any existing uses of '#', but I haven't done a thorough check of this yet. Ken Brown (3

[PATCH setup 1/3] Fix the reading and writing of the "extrakeys" user setting

ExtraKeysSetting::keybuffer is terminated by LF rather than NUL. So we have to replace NUL by LF after calling UserSettings::get("extrakeys") in the ExtraKeysSetting constructor. Otherwise the last saved key is discarded. Also, bufsize has to be set appropriately before the call to count_keys(),

[PATCH setup 3/3] Remove references to "last-extrakeys"

Extra gpg keys used to be stored in a file /etc/setup/last-extrakeys. These keys are now saved in the "extrakeys" user setting, but there were still references to "last-extrakeys" in comments and in a help string. --- KeysSetting.h | 2 +- crypto.cc | 8 2 files changed, 5

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

On 11/28/2017 7:58 AM, Ken Brown wrote: On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

On 11/27/2017 9:14 PM, Ken Brown wrote: On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys&quo

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

On 11/27/2017 5:19 PM, Ken Brown wrote: On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL.  This led to garbage at the end of the "extrakeys" setting that was written into setu

Re: [PATCH setup] Don't write garbage into the "extrakeys" user setting

On 11/27/2017 4:35 PM, Ken Brown wrote: The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by

[PATCH setup] Don't write garbage into the "extrakeys" user setting

The ExtraKeysSetting destructor called UserSettings::set() on a string that was terminated by LF instead of NUL. This led to garbage at the end of the "extrakeys" setting that was written into setup.rc. Fix this by replacing the final LF by NUL before calling set(). --- KeysSetting.cc | 6

[ITA] lcms2-2.9-1

My cygport file is attached. Package files = D=http://sanibeltranquility.com/cygwin ${D}/x86/release/lcms2/lcms2-2.9-1-src.tar.xz ${D}/x86/release/lcms2/lcms2-2.9-1.hint ${D}/x86/release/lcms2/lcms2-2.9-1.tar.xz ${D}/x86/release/lcms2/lcms2-debuginfo/lcms2-debuginfo-2.9-1.hint

Re: [PATCH] make setup mirror list more like web page not just urls

On 11/24/2017 4:47 PM, Brian Inglis wrote: I am suggesting we split get_site_list to create the setup.rc cached list at the start, flag entries false, So you're throwing away the information that the entries in the cached site list came from mirrors.lst in a previous setup run? merge the

[PATCH setup, v2] site.cc, site.h: code cleanup

Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Add a bool member 'from_mirrors_lst' to the site_list_type class. Use it to distinguish mirrors listed in mirrors.lst from user-added sites. This replaces the (undocumented) use of

Re: [PATCH] make setup mirror list more like web page not just urls

On 11/24/2017 1:23 AM, Brian Inglis wrote: On 2017-11-23 14:07, Ken Brown wrote: On 11/22/2017 11:42 AM, Brian Inglis wrote: On 2017-11-20 15:59, Ken Brown wrote: On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15

Re: [PATCH] make setup mirror list more like web page not just urls

On 11/22/2017 11:42 AM, Brian Inglis wrote: On 2017-11-20 15:59, Ken Brown wrote: On 11/20/2017 4:30 PM, Brian Inglis wrote: On 2017-11-17 06:53, Jon Turney wrote: On 11/17/2017 8:48 AM, Ken Brown wrote: On 15/11/2017 21:35, Brian Inglis wrote: The issue of recognizing a URL that's already

Re: [PATCH setup] site.cc, site.h: code cleanup

On 11/22/2017 12:02 PM, Jon Turney wrote: On 20/11/2017 01:26, Ken Brown wrote: Remove site_list_type::init(), which was introduced to work around a problem with gcc-2.95. Please tell me we're not actually using a placement new for these things :S Add a bool member 'is_official

Re: [PATCH setup 00/14] Use libsolv, solve all our problems... (WIP)

On 11/23/2017 1:10 PM, Jon Turney wrote: On 06/09/2017 03:52, Ken Brown wrote: On 9/5/2017 2:40 PM, Achim Gratz wrote: Jon Turney writes: Yeah, I'm not sure if putting the test packages into a separate repo which is disabled unless explicitly enabled is the right approach. (Instead, perhaps

<    1   2   3   4   5   6   7   8   9   10   >