Re: [PATCH] A setup.exe performance enhancement

2010-12-06 Thread Ken Brown
On 11/26/2010 10:39 AM, Andy Koppe wrote: On 26 November 2010 15:22, Jon TURNEY wrote: I've also uploaded a setup snapshot at [1], I would be much obliged if that received some testing. [1] http://cygwin.com/setup/snapshots/setup-2.738.exe Wow, what a difference. It's so fast that the new

Re: [PATCH] A setup.exe performance enhancement

2010-11-26 Thread Jon TURNEY
On 20/11/2010 09:43, Corinna Vinschen wrote: On Nov 19 14:49, Christopher Faylor wrote: On Fri, Nov 19, 2010 at 04:07:23PM +, Jon TURNEY wrote: Change package_db collection of packages from vector to a map so we can look things up in it quickly This allows packagedb::findBinary() and

Re: [PATCH] A setup.exe performance enhancement

2010-11-26 Thread Andy Koppe
On 26 November 2010 15:22, Jon TURNEY wrote: On 20/11/2010 09:43, Corinna Vinschen wrote: On Nov 19 14:49, Christopher Faylor wrote: On Fri, Nov 19, 2010 at 04:07:23PM +, Jon TURNEY wrote: Change package_db collection of packages from vector to a map so we can look things up in it

Re: [PATCH] A setup.exe performance enhancement

2010-11-20 Thread Corinna Vinschen
On Nov 19 14:49, Christopher Faylor wrote: On Fri, Nov 19, 2010 at 04:07:23PM +, Jon TURNEY wrote: Change package_db collection of packages from vector to a map so we can look things up in it quickly This allows packagedb::findBinary() and packagedb::findSource() to be re-written to

[PATCH] A setup.exe performance enhancement

2010-11-19 Thread Jon TURNEY
setup built with '-g -O0 -pg' flags, 'time ./setup.exe. -X -q' with both a cygwin and a cygport mirror selected, but nothing to install, takes rather a long time: real5m52.001s user0m0.046s sys 0m0.015s start of the the call graph output from gprof: granularity: each sample hit

Re: [PATCH] A setup.exe performance enhancement

2010-11-19 Thread Christopher Faylor
On Fri, Nov 19, 2010 at 04:07:23PM +, Jon TURNEY wrote: Change package_db collection of packages from vector to a map so we can look things up in it quickly This allows packagedb::findBinary() and packagedb::findSource() to be re-written to locate packages by name rather than searching the