Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-17 Thread Dave Korn
On 15/04/2010 09:57, Corinna Vinschen wrote: On Apr 14 18:17, Dave Korn wrote: OK now? I think so, yes. Thank you. Applied, finally. Here's a question. Do you have any idea how much work it would be to convert the packagedb singleton into an ordinary class with an ordinary class

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-15 Thread Corinna Vinschen
On Apr 14 18:17, Dave Korn wrote: On 14/04/2010 15:41, Dave Korn wrote: I'll rewrite the comments now I know exactly what's going on and resend it later. Here: * root.cc (RootPage::OnNext): Don't construct a packagedb here nor do deferred initialisation of static

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-14 Thread Corinna Vinschen
On Apr 14 05:54, Dave Korn wrote: I found out why we never see packages being set to Retrieve in download mode any more. There was a bit of a refactoring accident here: 2008-08-12 Revamp for Cygwin 1.7. * package_db.cc (chosen_db_task): New global variable. *

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-14 Thread Dave Korn
On 14/04/2010 09:21, Corinna Vinschen wrote: [ ... ] I couldn't work out what the original problem referred to might have been Are you sure? Please check again. The original situation which this was supposed to fix is this: - You have an existing installation in C:\cygwin - You want

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-14 Thread Dave Korn
On 14/04/2010 14:30, Dave Korn wrote: On 14/04/2010 09:21, Corinna Vinschen wrote: Are you sure? Please check again. The original situation which this was supposed to fix is this: - You have an existing installation in C:\cygwin - You want to create a new installation in D:\cygwin-new -

Re: [PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-14 Thread Dave Korn
On 14/04/2010 15:41, Dave Korn wrote: I'll rewrite the comments now I know exactly what's going on and resend it later. Here: * root.cc (RootPage::OnNext): Don't construct a packagedb here nor do deferred initialisation of static packagedb::task. * source.cc

[PATCH] Incidental setup.exe patches #3: Simplify packagedb task handling

2010-04-13 Thread Dave Korn
I found out why we never see packages being set to Retrieve in download mode any more. There was a bit of a refactoring accident here: 2008-08-12 Revamp for Cygwin 1.7. * package_db.cc (chosen_db_task): New global variable. * package_db.h (chosen_db_task): Declare.