Re: Patch for generic-build-script

2004-08-13 Thread Igor Pechtchanski
On Fri, 13 Aug 2004, Gerrit P. Haase wrote: > Hello Igor, > > On 12. August 2004, Igor wrote: > > > On Thu, 12 Aug 2004, Robb, Sam wrote: > > [...] > > >> - When compressing info files as part of an install, uses the > >> -exec option of find rather than xargs. > >> > >> Packages that already

Re: Patch for generic-build-script

2004-08-13 Thread Jason Tishler
On Thu, Aug 12, 2004 at 11:41:03PM -0400, Robb, Sam wrote: > > It was actually right there on the xargs man page... ;-) Ok, so > > it's settled -- I'll change your patch to do that instead of the > > -exec option. > > Just curious - is there a reason to prefer xargs vs. -exec? I know > that xarg

Re: Patch for generic-build-script

2004-08-12 Thread Gerrit P. Haase
Hello Igor, On 12. August 2004, Igor wrote: > On Thu, 12 Aug 2004, Robb, Sam wrote: [...] >> - When compressing info files as part of an install, uses the >> -exec option of find rather than xargs. >> >> Packages that already compress info files on install will create >> an info dir, but

RE: Patch for generic-build-script

2004-08-12 Thread Robb, Sam
> It was actually right there on the xargs man page... ;-) Ok, so it's > settled -- I'll change your patch to do that instead of the > -exec option. Just curious - is there a reason to prefer xargs vs. -exec? I know that xargs can be used to avoid shell command line length limits, but are there

RE: Patch for generic-build-script

2004-08-12 Thread Igor Pechtchanski
On Thu, 12 Aug 2004, Robb, Sam wrote: > > Good catch. I'd rather add the '-r' ('--no-run-if-empty') flag to the > > all of the xargs invocations, though. > > Told you I wasn't familiar with xargs :-) I really need to spend some > time and get more comfortable with it. It was actually right ther

RE: Patch for generic-build-script

2004-08-12 Thread Robb, Sam
> Good catch. I'd rather add the '-r' ('--no-run-if-empty') flag to the > all of the xargs invocations, though. Told you I wasn't familiar with xargs :-) I really need to spend some time and get more comfortable with it. > > - When compressing files using gzip as part of an install, adds > >

Re: Patch for generic-build-script

2004-08-12 Thread Igor Pechtchanski
On Thu, 12 Aug 2004, Robb, Sam wrote: > Attached is a suggested patch for the generic-builf-script. I'm > not as familiar with xargs as I should be, so there may be better > ways of implementing some of these changes... Thanks for the patch. Some comments below. > Areas it affects: > > - Adds

Patch for generic-build-script

2004-08-12 Thread Robb, Sam
Attached is a suggested patch for the generic-builf-script. I'm not as familiar with xargs as I should be, so there may be better ways of implementing some of these changes... Areas it affects: - Adds a couple of names to the list of files to be considered documentation (COPYRIGHT, CHANGELOG,

Re: [PATCH] for generic-build-script

2004-06-01 Thread Yaakov Selkowitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Yaakov Selkowitz wrote: | If so, let me propose the attached patch instead. Ping?? -BEGIN PGP SIGNATURE- Version: GnuPG v1.2.4 (Cygwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFAvPeZpiWmPGlmQSMRArU+AKDPSCb2DZvaQc

Re: [PATCH] for generic-build-script

2004-05-20 Thread Igor Pechtchanski
On Thu, 20 May 2004, Gerrit P. Haase wrote: > Hallo Igor, > > Am Mittwoch, 19. Mai 2004 um 19:47 schriebst du: > > > On Wed, 19 May 2004, Christopher Faylor wrote: > > >> On Wed, May 19, 2004 at 03:52:04PM +0200, Gerrit P. Haase wrote: > >> >Hallo cygwin-apps, > >> > > >> >--- generic-build-script

Re: [PATCH] for generic-build-script

2004-05-19 Thread Igor Pechtchanski
On Wed, 19 May 2004, Christopher Faylor wrote: > On Wed, May 19, 2004 at 03:52:04PM +0200, Gerrit P. Haase wrote: > >Hallo cygwin-apps, > > > >--- generic-build-script~ 2004-05-19 15:49:55.827961600 +0200 > >+++ generic-build-script2004-05-19 15:49:41.196923200 +0200 > >@@ -180,7 +18

Re: [PATCH] for generic-build-script

2004-05-19 Thread Yaakov Selkowitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Gerrit P. Haase wrote: | Hallo cygwin-apps, | | --- generic-build-script~ 2004-05-19 15:49:55.827961600 +0200 | +++ generic-build-script2004-05-19 15:49:41.196923200 +0200 | @@ -180,7 +180,7 @@ | fi ;\ |done &&\ |if [ -d ${ins

Re: [PATCH] for generic-build-script

2004-05-19 Thread Christopher Faylor
On Wed, May 19, 2004 at 03:52:04PM +0200, Gerrit P. Haase wrote: >Hallo cygwin-apps, > >--- generic-build-script~ 2004-05-19 15:49:55.827961600 +0200 >+++ generic-build-script2004-05-19 15:49:41.196923200 +0200 >@@ -180,7 +180,7 @@ > fi ;\ > done &&\ > if [ -d ${instdir}${pref

[PATCH] for generic-build-script

2004-05-19 Thread Gerrit P. Haase
Hallo cygwin-apps, --- generic-build-script~ 2004-05-19 15:49:55.827961600 +0200 +++ generic-build-script2004-05-19 15:49:41.196923200 +0200 @@ -180,7 +180,7 @@ fi ;\ done &&\ if [ -d ${instdir}${prefix}/share/info ] ; then \ -find ${instdir}${prefix}/share/info -name

Re: New patch for generic build script

2004-02-24 Thread Igor Pechtchanski
Alan, I was going to say that I'll review the patch later, and offer a few quick comments, but it looks like I did a full patch review, so here goes: (1) WOW, this is a HUGE ChangeLog. Wa-ay too detailed. Most of this stuff should go into comments in the script, if you feel like documenting it

New patch for generic build script (was RE: Pending patches for generic build script)

2004-02-24 Thread Alan Miles
All, I am attaching a new release of the this patch to mitigate below. Igor, please review and advise. Note: I built against 1.19 for the generic-build-script and 1.7 for the generic readme. Change log entry: 2004-02-24 Alan Miles <[EMAIL PROTECTED]> * templates/generic-readme : Chan

Re: New patch for generic-build-script

2004-02-18 Thread Igor Pechtchanski
On Wed, 18 Feb 2004, Yaakov Selkowitz wrote: > Igor Pechtchanski wrote: > > | Yaakov, > | > | This looks good. The only two comments I have are: > | > | 1) You replaced '&&'s by ';' after 'fi's in install() (where they were > | needed), and left the one after 'find' in mkpatch() (where it was not

Re: New patch for generic-build-script

2004-02-18 Thread Yaakov Selkowitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Igor Pechtchanski wrote: | Yaakov, | | This looks good. The only two comments I have are: | | 1) You replaced '&&'s by ';' after 'fi's in install() (where they were | needed), and left the one after 'find' in mkpatch() (where it was not). | This is mi

Re: New patch for generic-build-script

2004-02-18 Thread Igor Pechtchanski
On Wed, 18 Feb 2004, Yaakov Selkowitz wrote: Igor, OK, here's the patch again, along with my ChangeLog. Feel free to edit as necessary. Yaakov 2004-02-17 Yaakov Selkowitz * generic-build-script: Add 'configure', 'make', and 'test' arguments as aliases for 'conf', 'build', and

New patch for generic-build-script

2004-02-17 Thread Yaakov Selkowitz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Igor, OK, here's the patch again, along with my ChangeLog. Feel free to edit as necessary. Yaakov 2004-02-17 Yaakov Selkowitz * generic-build-script: Add 'configure', 'make', and 'test' arguments as aliases for 'conf', 'build', and