Re: [PATCH 3/4] Make io_stream::exists() directory aware

2010-12-17 Thread Corinna Vinschen
On Dec 16 22:49, Peter Rosin wrote: Den 2010-12-16 20:38 skrev Jon TURNEY: On 29/11/2010 11:28, Corinna Vinschen wrote: I would prefer if you would use GetFileAttributesA here, just like the io_stream_file::exists method. This also unifies testing the attributes. Oh, I used _stat()

Re: [PATCH 3/4] Make io_stream::exists() directory aware

2010-12-16 Thread Jon TURNEY
On 29/11/2010 11:28, Corinna Vinschen wrote: On Nov 26 13:48, Jon TURNEY wrote: At the moment io_stream::exists() returns FALSE for file:// paths which refer to an existing directory. Inconsistently, for cygfile:// paths which refer to an existing directory, it returns TRUE. Return a new

Re: [PATCH 3/4] Make io_stream::exists() directory aware

2010-12-16 Thread Peter Rosin
Den 2010-12-16 20:38 skrev Jon TURNEY: On 29/11/2010 11:28, Corinna Vinschen wrote: I would prefer if you would use GetFileAttributesA here, just like the io_stream_file::exists method. This also unifies testing the attributes. Oh, I used _stat() in the !IsWindowsNT() case as MSDN tells me

Re: [PATCH 3/4] Make io_stream::exists() directory aware

2010-11-29 Thread Corinna Vinschen
On Nov 26 13:48, Jon TURNEY wrote: At the moment io_stream::exists() returns FALSE for file:// paths which refer to an existing directory. Inconsistently, for cygfile:// paths which refer to an existing directory, it returns TRUE. Return a new state, IO_STREAM_EXISTS_DIRECTORY, to indicate

[PATCH 3/4] Make io_stream::exists() directory aware

2010-11-26 Thread Jon TURNEY
At the moment io_stream::exists() returns FALSE for file:// paths which refer to an existing directory. Inconsistently, for cygfile:// paths which refer to an existing directory, it returns TRUE. Return a new state, IO_STREAM_EXISTS_DIRECTORY, to indicate if pathname exists as a directory and