Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-03-10 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 26/02/2024 19:53, Christian Franke via Cygwin-apps wrote: Would it not make more sense to just re-export it if set? If the cygport file decides to set but not export it, there is possibly no need to do it. An example is smartmontools.cygport which passes the

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-03-10 Thread Jon Turney via Cygwin-apps
On 26/02/2024 19:53, Christian Franke via Cygwin-apps wrote: Would it not make more sense to just re-export it if set? If the cygport file decides to set but not export it, there is possibly no need to do it. An example is smartmontools.cygport which passes the unexported variable as a

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-26 Thread Christian Franke via Cygwin-apps
Jon Turney wrote: On 16/02/2024 12:29, Christian Franke via Cygwin-apps wrote: Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not exported. What is the valid range here? The range accepted by 'date -d @EPOCH ...', later used to adjust the

Re: [PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-26 Thread Jon Turney via Cygwin-apps
On 16/02/2024 12:29, Christian Franke via Cygwin-apps wrote: Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not exported. What is the valid range here? Would it not make more sense to just re-export it if set? (so that commands like

[PATCH cygport] Add more checks of SOURCE_DATE_EPOCH

2024-02-16 Thread Christian Franke via Cygwin-apps
From b04c8f5e9becd6e91095e2add551f72870c9e869 Mon Sep 17 00:00:00 2001 From: Christian Franke Date: Fri, 16 Feb 2024 13:16:06 +0100 Subject: [PATCH] Add more checks of SOURCE_DATE_EPOCH Fail if it is out of range. Warn if it lies in the future. Inform whether it is set or set but not