Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-07 Thread ASSI via Cygwin-apps
Jon Turney via Cygwin-apps writes: > Yes, I had managed to deduce that much. :) > > Providing a specific instance would save me having to find or invent > one, though. Sorry, I did not have one at hand, all such instances in my stack of packages are either uncompressed files or compressed

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-07 Thread Jon Turney via Cygwin-apps
On 04/08/2023 18:51, ASSI via Cygwin-apps wrote: Jon Turney via Cygwin-apps writes: Do you have an example of a cygport which fails without this fix, so I can add a test for this? Anything with a SRC_URI or PATCH_URI that has .zst suffix but not .tar.zst should suffice. Yes, I had managed

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-07 Thread Jon Turney via Cygwin-apps
On 04/08/2023 19:39, Yasutaka ATARASHI via Cygwin-apps wrote: ASSI via Cygwin-apps writes: That's true for bunzip2 and gunzip, but not for zstd (where the output file can be independently specified). Ah ha. The attached patch recovers to use the `-o` option for `unzstd`. Thanks. I applied

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-04 Thread Yasutaka ATARASHI via Cygwin-apps
ASSI via Cygwin-apps writes: > That's true for bunzip2 and gunzip, but not for zstd (where the output > file can be independently specified). Ah ha. The attached patch recovers to use the `-o` option for `unzstd`. Regards, Yasutaka ATARASHI src_prep_unpack_rev3.patch Description: Binary data

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-04 Thread ASSI via Cygwin-apps
Yasutaka ATARASHI via Cygwin-apps writes: > Yeah, I also wonder why the --keep option is not used for .gz and .bz2. > Now, I recognized the reason. Thanks. > `unpack()` is expected to extract the files to the current working > directory regardless of the specified path of the input. Please see >

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-04 Thread ASSI via Cygwin-apps
Jon Turney via Cygwin-apps writes: > Do you have an example of a cygport which fails without this fix, so I > can add a test for this? Anything with a SRC_URI or PATCH_URI that has .zst suffix but not .tar.zst should suffice. Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-08-04 Thread Yasutaka ATARASHI via Cygwin-apps
Sorry for the late reply. I updated the patch to handle the case of .xz, also, and a bit adjusted the arguments of `check_prog_req`. Jon Turney writes: >Do you have an example of a cygport which fails without this fix, so I >can add a test for this? My motivating example is far from the

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-07-30 Thread ASSI via Cygwin-apps
yak_ex via Cygwin-apps writes: > `unpack()` invokes `unzstd` for a *.zst file as > `unzstd -qo file.zst` > Then, an error occurs as 'stdin is a console, aborting', > because the `-o` option is to specify an output file name. Indeed, sorry for that. > There are some choices to fix it. This patch

Re: [PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-07-30 Thread Jon Turney via Cygwin-apps
On 29/07/2023 21:55, yak_ex via Cygwin-apps wrote: Hi maintainers, This is my first post here. The attached tiny patch fixes incorrect options passed to unzstd in unpack() in lib/src_prep.cygpart. `unpack()` invokes `unzstd` for a *.zst file as `unzstd -qo file.zst` Then, an error occurs as

[PATCH cygport] lib/src_prep.cygpart: Fix incorrect options passed to unzstd in unpack()

2023-07-29 Thread yak_ex via Cygwin-apps
Hi maintainers, This is my first post here. The attached tiny patch fixes incorrect options passed to unzstd in unpack() in lib/src_prep.cygpart. `unpack()` invokes `unzstd` for a *.zst file as `unzstd -qo file.zst` Then, an error occurs as 'stdin is a console, aborting', because the `-o` option