Re: Please, backport compress_gz.cc patch for setup-200206 branch was Re: ntsec patch for setup

2003-03-03 Thread Max Bowsher
Pavel Tsekov wrote: On Fri, 28 Feb 2003, Pavel Tsekov wrote: I also propose this patch to be backported to the 200206 branch. It helps in cases where one does a new install and install a lot of packages. http://sources.redhat.com/cgi-bin/cvsweb.cgi/setup/compress_gz.cc.diff?r1=2.

Re: ntsec patch for setup

2003-02-28 Thread Pavel Tsekov
Here is the same patch modified to be applied on main.cc from setup-200207 branch. On Fri, 10 Jan 2003, Pierre A. Humblet wrote: This is the patch mentioned in the previous e-mail. I seems to work fine on NT and an early version was tested on 2000 (there are differences). Essentially the

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup-200207 branch, otherwise, Max - if you have time could you? Failing that, I'll

Re: ntsec patch for setup

2003-02-28 Thread Pierre A. Humblet
Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup-200207 branch, otherwise, Max - if you have time

RE: ntsec patch for setup

2003-02-28 Thread Morrison, John
Sorry guys, that should have been to the list. From: Pierre A. Humblet [mailto:[EMAIL PROTECTED] Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable.

Re: ntsec patch for setup

2003-02-28 Thread Pavel Tsekov
On Fri, 28 Feb 2003, Pierre A. Humblet wrote: Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the

Re: ntsec patch for setup

2003-02-28 Thread Max Bowsher
Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup-200207 branch, otherwise, Max - if you have time could

Re: ntsec patch for setup

2003-02-28 Thread Pavel Tsekov
On Fri, 28 Feb 2003, Max Bowsher wrote: Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the setup-200207

Re: ntsec patch for setup

2003-02-28 Thread Pierre A. Humblet
Morrison, John wrote: BTW, this script doesn't add any domain users... -c adds the current user, if a domain user. If you are on a domain account at work, please test it, it takes a few seconds. Just did. How does it cope if it can't access the domain? It doesn't even try. It

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 01:32, Max Bowsher wrote: I can commit ASAP, once this issue is talked out, but I think it might be wise to use 200206 for an interim release now, unless Robert is very sure 200207 is OK. 200206. I wasn't thinking for a sec there. Rob -- GPG key available at:

Re: ntsec patch for setup

2003-02-28 Thread Max Bowsher
Robert Collins wrote: On Sat, 2003-03-01 at 01:32, Max Bowsher wrote: I can commit ASAP, once this issue is talked out, but I think it might be wise to use 200206 for an interim release now, unless Robert is very sure 200207 is OK. 200206. I wasn't thinking for a sec there. Right. I've

Re: ntsec patch for setup

2003-02-28 Thread Pavel Tsekov
On Fri, 28 Feb 2003, Pavel Tsekov wrote: 2) gcc2 (not g++2) chokes on some lines in /usr/include/mingw/string.h. I had to patch as below, adding prototypes before the functions declared inline. There are also some complaints about autoload.c. Will see what I can do. The attached patch

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 05:23, Max Bowsher wrote: Robert Collins wrote: On Fri, 2003-02-28 at 22:44, Pavel Tsekov wrote: Here is the same patch modified to be applied on main.cc from setup-200207 branch. This looks reasonable. Pavel, if you have write access, please commit to the

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 02:54, Max Bowsher wrote: I've built setup from 200206 with ntsec patch as backported by Pavel. I ran into other problems: 1) I had to merge these fixes, which enable building of setup with gcc-2. cvs upd -kk -j2.22 -j2.23 Makefile.am cvs upd -kk -j2.84 -j2.85

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Sat, 2003-03-01 at 03:41, Pavel Tsekov wrote: On Fri, 28 Feb 2003, Pavel Tsekov wrote: 2) gcc2 (not g++2) chokes on some lines in /usr/include/mingw/string.h. I had to patch as below, adding prototypes before the functions declared inline. There are also some complaints about

Re: ntsec patch for setup

2003-02-28 Thread Robert Collins
On Tue, 2003-01-21 at 14:00, Pierre A. Humblet wrote: At 10:24 PM 1/19/2003 -, Max Bowsher wrote: I'd suggest something like this: if (isusers) { nsid = usid; log(LOG_TIMESTAMP) Changing gid to Users endLog; } else if (isadmins) nsid = asid; log(LOG_TIMESTAMP)

Re: ntsec patch for setup

2003-02-28 Thread Max Bowsher
Robert Collins wrote: On Sat, 2003-03-01 at 02:54, Max Bowsher wrote: I've built setup from 200206 with ntsec patch as backported by Pavel. I ran into other problems: 1) I had to merge these fixes, which enable building of setup with gcc-2. cvs upd -kk -j2.22 -j2.23 Makefile.am cvs upd -kk

Re: ntsec patch for setup

2003-02-28 Thread Max Bowsher
Robert Collins wrote: On Sat, 2003-03-01 at 03:41, Pavel Tsekov wrote: On Fri, 28 Feb 2003, Pavel Tsekov wrote: 2) gcc2 (not g++2) chokes on some lines in /usr/include/mingw/string.h. I had to patch as below, adding prototypes before the functions declared inline. There are also some

Re: ntsec patch for setup

2003-01-20 Thread Pierre A. Humblet
At 10:24 PM 1/19/2003 -, Max Bowsher wrote: I'd suggest something like this: if (isusers) { nsid = usid; log(LOG_TIMESTAMP) Changing gid to Users endLog; } else if (isadmins) nsid = asid; log(LOG_TIMESTAMP) Changing gid to Administrators endLog; } OK, I will wait for

Re: ntsec patch for setup

2003-01-19 Thread Max Bowsher
Pierre A. Humblet wrote: This is the patch mentioned in the previous e-mail. I seems to work fine on NT and an early version was tested on 2000 (there are differences). Essentially the installed files should be in the Users or Admins groups instead of None. Nothing changes if the user

Re: ntsec patch for setup

2003-01-19 Thread Pierre A. Humblet
At 06:25 PM 1/19/2003 -, Max Bowsher wrote: Pierre A. Humblet wrote: It would probably be nice to add some logging to the success case, so its easier to see that it has actually taken effect. OK. Good idea. I don't mind doing it but you know better what formats to use etc.. to fit with the

Re: ntsec patch for setup

2003-01-19 Thread Robert Collins
On Sat, 2003-01-11 at 14:36, Pierre A. Humblet wrote: This is the patch mentioned in the previous e-mail. I seems to work fine on NT and an early version was tested on 2000 (there are differences). I'll be looking at this shortly - I am for it in principal. Rob -- GPG key available at:

Re: ntsec patch for setup

2003-01-19 Thread Max Bowsher
Pierre A. Humblet wrote: At 06:25 PM 1/19/2003 -, Max Bowsher wrote: Pierre A. Humblet wrote: It would probably be nice to add some logging to the success case, so its easier to see that it has actually taken effect. OK. Good idea. I don't mind doing it but you know better what formats