Re: gbs cleanup patch, 2nd try

2004-10-30 Thread Andrew Schulman
Great. Have you tested whether the -e flag gets propagated inside the functions? Yes, I have now: $ /bin/sh -e ; echo finished /bin/sh -e, status=$? $ echo $- eims $ # the -e flag propagates into subshells: $ tst1() { echo $- ; } $ tst1 eims $ # false result inside a function

Re: gbs cleanup patch, 2nd try

2004-10-30 Thread Andrew Schulman
Sorry, the above is wrong: Sorry again, but please disregard my previous message. I was confused because I was testing some features of /bin/sh -e on Debian. On Debian /bin/sh invokes bash, while on Cygwin it runs ash. It turns out that these two handle subshells with -e differently:

Re: gbs cleanup patch

2004-10-15 Thread Charles Wilson
[EMAIL PROTECTED] wrote: As we discussed a day or two ago, here is a patch that cleans up the following aspects of the generic build script (today's CVS version): - Replaces all instances of 'if [ ! -d xxx ] ; then mkdir -p xxx ; fi' with just 'mkdir -p xxx'. The second form is equivalent but

Re: gbs cleanup patch

2004-10-15 Thread Igor Pechtchanski
On Fri, 15 Oct 2004, Schulman.Andrew wrote: As we discussed a day or two ago, here is a patch that cleans up the following aspects of the generic build script (today's CVS version): Great, thanks, Andrew. Would you mind attaching the patch next time, though, as mailers screw up spacing and

Re: gbs cleanup patch

2004-10-15 Thread Igor Pechtchanski
On Fri, 15 Oct 2004, Charles Wilson wrote: Schulman.Andrew wrote: As we discussed a day or two ago, here is a patch that cleans up the following aspects of the generic build script (today's CVS version): - Replaces all instances of 'if [ ! -d xxx ] ; then mkdir -p xxx ; fi' with just

Re: gbs cleanup patch

2004-10-15 Thread Charles Wilson
Igor Pechtchanski wrote: - you changed the cd $dir find . to find $dir in some places, which I'd be more comfortable changing as a separate step, if at all Oooh, I missed that one. cd $dir find . --- bar.c baz.h find $dir --- $dir/bar.c $dir/baz.h Not good unless the results are