Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]

2003-07-30 Thread Robert Collins
On Tue, 2003-07-29 at 23:40, Max Bowsher wrote: Let's see if this approach is more satisfactory... We're getting close. However, you introduce a regression: currently alocal dir ini failure should just bounce em back to the previous screen IIRC, not exit. Cheers, Rob -- GPG key available at:

Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]

2003-07-30 Thread Max Bowsher
Robert Collins wrote: On Tue, 2003-07-29 at 23:40, Max Bowsher wrote: Let's see if this approach is more satisfactory... We're getting close. However, you introduce a regression: currently alocal dir ini failure should just bounce em back to the previous screen IIRC, not exit. No. First

Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]

2003-07-30 Thread Robert Collins
On Wed, 2003-07-30 at 18:34, Max Bowsher wrote: This is just as well, since currently if IDD_S_LOAD_INI does got posted back to threebar.cc, setup hangs on the progress page, since do_fromcwd does not do what the code in threebar.cc seems to believe it does. So, I'm adding an exit in a very

new snapshot...

2003-07-30 Thread Robert Collins
I've uploaded a new snapshot (-402) It's (obviously) got all the recent changes. It's -also- got persisted user settings for most of the dialogs. Take a look at SourceSettings.* or ConnectionSettings.* - they're /very/ simple. (They could be made simpler, but it just wasn't worth it there n

Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]

2003-07-30 Thread Max Bowsher
Robert Collins wrote: On Wed, 2003-07-30 at 18:34, Max Bowsher wrote: This is just as well, since currently if IDD_S_LOAD_INI does got posted back to threebar.cc, setup hangs on the progress page, since do_fromcwd does not do what the code in threebar.cc seems to believe it does. So, I'm

Pending setup patches (issue 15)

2003-07-30 Thread Max Bowsher
* (Pierre Humblet) 2nd ntsec patch http://sources.redhat.com/ml/cygwin-apps/2003-04/msg00127.html * (Benjamin Riefenstahl) Mouse wheel http://sources.redhat.com/ml/cygwin-apps/2003-05/msg00178.html * (Igor Pechtchanski) __LINE__ __FILE__

Re: new snapshot...

2003-07-30 Thread Max Bowsher
Robert Collins wrote: I've uploaded a new snapshot (-402) ... I'm considering moving that to release ASAP (because it fixes the /slow/ install time for new users), and then letting us spend some with the resizable dialog, working any kinks out. Sounds good, but I think the pending patch list

Re: new snapshot...

2003-07-30 Thread Igor Pechtchanski
On Wed, 30 Jul 2003, Max Bowsher wrote: Robert Collins wrote: I've uploaded a new snapshot (-402) ... I'm considering moving that to release ASAP (because it fixes the /slow/ install time for new users), and then letting us spend some with the resizable dialog, working any kinks out.

Re: new snapshot...

2003-07-30 Thread Max Bowsher
Igor Pechtchanski wrote: Max, Thanks for putting in a good word. :-) I can forward port the patches once they are approved (most changes should be in the line numbers, anyway). If the patches change significantly, I'll post them here for a new approval. Both of your patches currently

Running a little behind

2003-07-30 Thread Elfyn McBratney
Sorry to everyone who is still waiting for updated package status, updated for Cygwin 1.5, etc. I've got family over from Sweden that I haven't seen in a long while and I'm a little pre-occupied...and my nephew has just puked on my shirt... I will try and bring everything up-to-date by

Re: new snapshot...

2003-07-30 Thread Igor Pechtchanski
On Wed, 30 Jul 2003, Max Bowsher wrote: Igor Pechtchanski wrote: Max, Thanks for putting in a good word. :-) I can forward port the patches once they are approved (most changes should be in the line numbers, anyway). If the patches change significantly, I'll post them here for a

Re: [setup PATCH] Rework do_ini [next_dialog removal (2a)]

2003-07-30 Thread Robert Collins
On Wed, 2003-07-30 at 20:08, Max Bowsher wrote: Actually, that TODO is trivial, so I've done it. Also found a bug in my previous patch (one SetActivePageByID (lParam) remained) - fixed. New patch (ini.cc changes are identical to previous patch): Ok, lets do it. Cheers, Rob -- GPG key

Re: Setup.exe: Mouse wheel

2003-07-30 Thread Robert Collins
On Sun, 2003-06-01 at 03:27, Benjamin Riefenstahl wrote: Finally it's not obviously the Right Thing to do. It seems to me we'd want to trap those events and translate them in the rest of the choose event loop, not as a special case. You mean in listview_proc()? I tried that, but the

Re: Pending setup patches (issue 15)

2003-07-30 Thread Max Bowsher
Robert Collins wrote: On Wed, 2003-07-30 at 20:22, Max Bowsher wrote: Both Igors and Pierre's can come in. That's in before the branch? Or in to cvs right now, as is? Max.

Re: Pending setup patches (issue 15)

2003-07-30 Thread Robert Collins
On Thu, 2003-07-31 at 07:54, Max Bowsher wrote: Or in to cvs right now, as is? This one Rob -- GPG key available at: http://members.aardvark.net.au/lifeless/keys.txt. signature.asc Description: This is a digitally signed message part

[setup PATCH] Rework do_download [next_dialog removal (2b)]

2003-07-30 Thread Max Bowsher
And another... +2003-07-30 Max Bowsher [EMAIL PROTECTED] + + * download.cc (do_download_thread): Return bool. Move program flow + logic to threebar.cc. + (do_download_thread_reflector): Put returned bool in lParam. + * threebar.cc: Include msg.h. + (WM_APP_DOWNLOAD_THREAD_COMPLETE): Rework for

Re: Pending setup patches (issue 15)

2003-07-30 Thread Igor Pechtchanski
On 31 Jul 2003, Robert Collins wrote: On Wed, 2003-07-30 at 20:22, Max Bowsher wrote: Both Igors and Pierre's can come in. Cheers, Rob Great. I've just committed both patches. Slight mishap with the commit message on the first one (forgot to change the date in the ChangeLog file), but

Re: Pending setup patches (issue 15)

2003-07-30 Thread Max Bowsher
Igor Pechtchanski wrote: On 31 Jul 2003, Robert Collins wrote: On Wed, 2003-07-30 at 20:22, Max Bowsher wrote: Both Igors and Pierre's can come in. Cheers, Rob Great. I've just committed both patches. Slight mishap with the commit message on the first one (forgot to change the date in

[Ready for test/1.5.1] tar 1.13.25-3

2003-07-30 Thread Christopher Faylor
On Thu, Jul 24, 2003 at 01:47:04AM -0400, Christopher Faylor wrote: Simply recompiled for a cygwin-1.5.0 system. No other changes. Recompiled for cygwin-1.5.1 since tar uses fdopen. cgf

Re: [Ready for test/1.5.0] diffutils 2.8.4-1

2003-07-30 Thread Christopher Faylor
On Thu, Jul 24, 2003 at 01:34:15AM -0400, Christopher Faylor wrote: Simply recompiled for a cygwin-1.5.0 system. No other changes. Recompiled for cygwin-1.5.1 since diffutils uses fdopen. Also bumped to alpha version from FSF web site. No other changes made. Compiled out of the box. cgf

Re: [Ready for test/1.5.*1*] diffutils 2.8.4-1

2003-07-30 Thread Christopher Faylor
On Wed, Jul 30, 2003 at 11:48:45PM -0400, Christopher Faylor wrote: On Thu, Jul 24, 2003 at 01:34:15AM -0400, Christopher Faylor wrote: Simply recompiled for a cygwin-1.5.0 system. No other changes. Recompiled for cygwin-1.5.1 since diffutils uses fdopen. Also bumped to alpha version from FSF