Re: cygport: distinguish between x86 and x86_64

2016-08-24 Thread Achim Gratz
Corinna Vinschen writes: >> What is the official way to conditionalize .cygport files for >> differences in x86 and x86_64 architectures ? > > "${ARCH}" is either "i686" or "x86_64" For tests in the cygport file it is usually easier to use the ARCH_i686 or ARCH_x86_64 variables. Regards, Achim.

Re: [PATCH setup 0/4] Use a pop-up menu to select chooser view filter

2016-08-24 Thread Corinna Vinschen
On Aug 24 15:15, Jon Turney wrote: > Clicking on a button to cycle around alternatives seems bad UI, so instead > allow > a specific filter view to be directly selected with a pop-up menu. > > I'm not sure if this is a great improvement or not, but since I wrote it, > here > it is... Nice

[PATCH setup 4/4] Use a pop-up menu to directly select chooser view filter

2016-08-24 Thread Jon Turney
Rather that cycling through views, popup a menu to choose the view when the view button is clicked Future work: Hopefully this does reduce the average number of clicks needed, but popping-up on mouse button down, rather than mouse button click is perhaps what we really want here, but seems to be

[PATCH setup 0/4] Use a pop-up menu to select chooser view filter

2016-08-24 Thread Jon Turney
Clicking on a button to cycle around alternatives seems bad UI, so instead allow a specific filter view to be directly selected with a pop-up menu. I'm not sure if this is a great improvement or not, but since I wrote it, here it is... Jon Turney (4): Build C++ code with -std=gnu++11

[PATCH setup 1/4] Build C++ code with -std=gnu++11

2016-08-24 Thread Jon Turney
Use BASECXXFLAGS rather then AM_CXXFLAGS to make AM_CFLAGS Rationalize BASECXXFLAGS, adding -Werror and removing -Wno-uninitialized (since the bug preventing it being used is long fixed) Fix a bug detected by -Wuninitialized Build C++ code with -std=gnu++11 -Wno-deprecated-declarations ---

[PATCH setup 2/4] Change PickView::view into an enum

2016-08-24 Thread Jon Turney
Change PickView::view from a class, into an enum Use a C++11 scoped enum so we don't have to change all the uses of it's values. --- PickView.cc | 44 PickView.h | 41 + 2 files changed, 21 insertions(+), 64

[PATCH setup 3/4] Rename PickView::Package to PickView::PackagePending

2016-08-24 Thread Jon Turney
Rename PickView::Package to PickView::PackagePending, as that's what that view is --- PickView.cc | 8 PickView.h | 2 +- choose.cc | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/PickView.cc b/PickView.cc index 588cfec..25d43a2 100644 --- a/PickView.cc +++

Re: cygport: distinguish between x86 and x86_64

2016-08-24 Thread Corinna Vinschen
On Aug 24 10:08, Dr. Volker Zell wrote: > Hi > > What is the official way to conditionalize .cygport files for > differences in x86 and x86_64 architectures ? "${ARCH}" is either "i686" or "x86_64" Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin

cygport: distinguish between x86 and x86_64

2016-08-24 Thread Dr. Volker Zell
Hi What is the official way to conditionalize .cygport files for differences in x86 and x86_64 architectures ? Thanks Volker