Re: units issues

2017-05-23 Thread Brian Inglis
On 2017-05-23 17:55, Doug Henderson wrote: > On 23 May 2017 at 15:49, Brian Inglis wrote: > >> Updating the currencies only when setup is run seems to me to be >> insufficient if users want to use current currency conversions. > > Currencies needs to be split to a different package from

Re: units issues

2017-05-23 Thread Doug Henderson
On 23 May 2017 at 15:49, Brian Inglis wrote: > Updating the currencies only when setup is run seems to me to be > insufficient if users want to use current currency conversions. Currencies needs to be split to a different package from non-currency units. Non-currency units is very static,

Re: units issues

2017-05-23 Thread Brian Inglis
On 2017-05-23 11:28, Achim Gratz wrote: > Brian Inglis writes: >> The easiest approaches to this would be: >> - rename or delete postinstall script which might upset cygcheck or >> setup remove >> - null /usr/share/units/currency.units, as it is required and produces >> an error message if not

Re: calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package

2017-05-23 Thread Ken Brown
On 5/23/2017 12:55 PM, Jon Turney wrote: On 23/05/2017 14:44, Ken Brown wrote: I've created an obsolete package (as discussed starting at https://sourceware.org/ml/cygwin-apps/2017-05/msg00084.html). But mksetupini doesn't like it: mksetupini: package 'texlive-collection-htmlxml' version

[Attn Maintainer] procps-ng

2017-05-23 Thread Achim Gratz
It appears that the procps command is missing the manpage, most likely because Cygwin has its own manpage for ps and got updated more recently. Can you please arrange for a manpage "procps" to coincide with the command name so that the two files no longer collide? Also, it appears that there's

Re: [PATCH setup 08/15] Fix comments and indentation in check_for_cached

2017-05-23 Thread Achim Gratz
Jon Turney writes: > + /* Note that the cache dir is represented by a mirror site of > file://local_dir */ >std::string prefix = "file://" + local_dir + "/"; > - /* FIXME: Nullness check can go away once packagesource is properly > - * std::string-ified, and doesn't use overcomplex

Re: units issues

2017-05-23 Thread Achim Gratz
Brian Inglis writes: > The easiest approaches to this would be: > - rename or delete postinstall script which might upset cygcheck or > setup remove > - null /usr/share/units/currency.units, as it is required and produces > an error message if not available, but if it is empty, everything works.

[PATCH setup 10/10] Remove OR from grammar

2017-05-23 Thread Jon Turney
Unused since removal of complex dependency rules in 60b4f6ca --- inilex.ll | 1 - iniparse.yy | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/inilex.ll b/inilex.ll index b454f0f..13422b1 100644 --- a/inilex.ll +++ b/inilex.ll @@ -141,7 +141,6 @@ B64 [a-zA-Z0-9_-] "<"

[PATCH setup 08/10] Fix infinite recursion in grammar for depends

2017-05-23 Thread Jon Turney
Allowing listseparator to be empty allows an infinite recursion in the versionedpackagelist rule Also make the comment documenting versionedpackageentry is non-empty consistent with all other similar comments Also allow lower-case depends: --- inilex.ll | 2 +- iniparse.yy | 6 +++--- 2 files

[PATCH setup 09/10] Improve error recovery in setup.ini parsing

2017-05-23 Thread Jon Turney
Following the error token with a NL allows the parser to discard tokens until a NL is found to resynchronize, rather than aborting. This doesn't help hugely, as *any* parse errors are considered fatal by do_remote_ini()/do_local_ini() and won't let us proceed. --- iniparse.yy | 2 +- 1 file

Re: calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package

2017-05-23 Thread Jon Turney
On 23/05/2017 14:44, Ken Brown wrote: I've created an obsolete package (as discussed starting at https://sourceware.org/ml/cygwin-apps/2017-05/msg00084.html). But mksetupini doesn't like it: mksetupini: package 'texlive-collection-htmlxml' version '20170520-1' source has no non-empty

[PATCH setup 07/10] Fold build(Install|Source)(MD5|SHA512) into buildPackage(Install|Source)

2017-05-23 Thread Jon Turney
Fold build(Install|Source)(MD5|SHA512) into buildPackage(Install|Source), so the (pathname, size, hash) information from an install: or source: line is all processed together. --- IniDBBuilderPackage.cc | 76 -- IniDBBuilderPackage.h | 20

[PATCH setup 06/10] Fold IniDBBuilderPackage::buildInstallSize() into buildPackageInstall()

2017-05-23 Thread Jon Turney
As mentioned in 5a3799dc, this ripples through into ScanFindVisitor as well. --- IniDBBuilderPackage.cc | 10 +++--- IniDBBuilderPackage.h | 3 +-- ScanFindVisitor.cc | 4 ++-- iniparse.yy| 2 +- 4 files changed, 7 insertions(+), 12 deletions(-) diff --git

[PATCH setup 04/10] Make PrereqChecker::setTrust() a static method

2017-05-23 Thread Jon Turney
Rather than instantiating PrereqChecker just to call an accessor method which changes a static data member, make that method static as well. --- choose.cc | 3 +-- prereq.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/choose.cc b/choose.cc index 4ac5aae..1bc4c0b 100644

[PATCH setup 05/10] Move and rename dumpAndList()

2017-05-23 Thread Jon Turney
--- IniDBBuilderPackage.cc | 4 ++-- Makefile.am| 1 + package_depends.cc | 33 + package_depends.h | 3 +++ package_meta.cc| 2 +- package_version.cc | 18 -- package_version.h | 3 --- 7 files changed, 40

[PATCH setup 02/10] Correctly calculate total data to checksum when using IncludeSource

2017-05-23 Thread Jon Turney
Correctly account for source packages installed due to IncludeSource in the total amount of data to checksum. The fact that this obvious bug is unreported kind of suggests that no-one is actually using this option... --- install.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH setup 03/10] Rename category "Misc" to "Orphaned"

2017-05-23 Thread Jon Turney
Packages which have no category are placed into this category. Since a category is mandatory for all packages in setup.ini, this effectively means packages which are "orphaned" in the sense that they are installed, but don't appear in any setup.ini. Usually it's safe to uninstall such packages

[PATCH setup 01/10] isBinary() should return true for orphaned packages

2017-05-23 Thread Jon Turney
Test added in c23d96d6 is incorrect and results in orphaned packages being omitted from picker. --- package_meta.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package_meta.cc b/package_meta.cc index cffb5b7..b1db191 100644 --- a/package_meta.cc +++ b/package_meta.cc @@

[PATCH setup 00/10] Various setup patches

2017-05-23 Thread Jon Turney
Oh, I think I can see a bit of floor over there! Jon Turney (10): isBinary() should return true for orphaned packages Correctly calculate total data to checksum when using IncludeSource Rename category "Misc" to "Orphaned" Make PrereqChecker::setTrust() a static method Move and rename

calm: mksetupini doesn't allow non-empty source but empty install files for an obsolete package

2017-05-23 Thread Ken Brown
I've created an obsolete package (as discussed starting at https://sourceware.org/ml/cygwin-apps/2017-05/msg00084.html). But mksetupini doesn't like it: mksetupini: package 'texlive-collection-htmlxml' version '20170520-1' source has no non-empty install tarfiles mksetupini: package set has