Re: cygport test has zero exit status on failures

2021-05-19 Thread Achim Gratz
Marco Atzeri via Cygwin-apps writes: >> src_test() { >> cd ${B} >> make check >> } > > This is the default. The actual default is: src_test() { cd ${B} cygtest } …with cygtest defined so that it won't return an error status from make. Regards, Achim. --

Re: cygport test has zero exit status on failures

2021-05-19 Thread Marco Atzeri via Cygwin-apps
On 19.05.2021 18:32, Jason Pyeron wrote: -Original Message- From: Marco Atzeri Sent: Wednesday, May 19, 2021 3:06 AM On 19.05.2021 07:16, ASSI wrote: Jason Pyeron writes: cygport $p finish prep compile inst test pkg So for the pdfgrep that I am going to maintain, is it acceptable

Re: cygport test has zero exit status on failures

2021-05-19 Thread Achim Gratz
Jason Pyeron writes: > So for the pdfgrep that I am going to maintain, is it acceptable that > I want the package to not happen until I address the test failure? You are the maintainer. :-) Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ SD adaptation

RE: cygport test has zero exit status on failures

2021-05-19 Thread Jason Pyeron
> -Original Message- > From: Marco Atzeri > Sent: Wednesday, May 19, 2021 3:06 AM > > On 19.05.2021 07:16, ASSI wrote: > > Jason Pyeron writes: > > > > >> In any case the all or all-test does not execute the test step, so the > >> customization of the src_test does not impact the default

Re: cygport test has zero exit status on failures

2021-05-19 Thread Marco Atzeri via Cygwin-apps
On 19.05.2021 07:16, ASSI wrote: Jason Pyeron writes: In any case the all or all-test does not execute the test step, so the customization of the src_test does not impact the default behaviors. That's beside the point. We were only talking about the test behaviours or at least I was,

Re: cygport test has zero exit status on failures

2021-05-18 Thread ASSI
Jason Pyeron writes: > If I have a CI build for *.cygport - is it expected to have > conditional logic based on which package is being processed? Not necessarily, I understand you were talking about default behaviour and how the current default doesn't match your / your CI's expectation. To

RE: cygport test has zero exit status on failures

2021-05-18 Thread Jason Pyeron
> -Original Message- > From: Achim Gratz > Sent: Tuesday, May 18, 2021 4:16 PM > > Jason Pyeron writes: > > If I put it in ~/.config/cygport.conf it will impact all packages, not > > just the "one". The only place it is limited to applicable package is > > in the package.cygport file, or

Re: cygport test has zero exit status on failures

2021-05-18 Thread Achim Gratz
Jason Pyeron writes: > If I put it in ~/.config/cygport.conf it will impact all packages, not > just the "one". The only place it is limited to applicable package is > in the package.cygport file, or am I missing something? You can always override these settings when starting a build on a CI

RE: cygport test has zero exit status on failures

2021-05-18 Thread Jason Pyeron
> -Original Message- > From: ASSI > Sent: Tuesday, May 18, 2021 12:37 AM > > Jason Pyeron writes: > > What is the historic rationale behind the "OR true" after the make > > check? > > Not historic for the most part, I'd say. Cygport can also do > cross-builds of packages and in those

Re: cygport test has zero exit status on failures

2021-05-17 Thread ASSI
Jason Pyeron writes: > What is the historic rationale behind the "OR true" after the make > check? Not historic for the most part, I'd say. Cygport can also do cross-builds of packages and in those cases the tests will seldomly work (at all or at least partly) unless upstream walked the extra

RE: cygport test has zero exit status on failures

2021-05-17 Thread Jason Pyeron
> -Original Message- > From: ASSI > Sent: Monday, May 10, 2021 1:06 AM > > Jason Pyeron writes: > > Cygport test is not returning a non zero exit status on failure! Is > > this expected? > > Yes, it is using 'make -k' under the hood. Again, if you need to do > something else than what

Re: cygport test has zero exit status on failures

2021-05-09 Thread ASSI
Jason Pyeron writes: > Cygport test is not returning a non zero exit status on failure! Is > this expected? Yes, it is using 'make -k' under the hood. Again, if you need to do something else than what the standard invocation provides, you would generally write your own src_test() function.

cygport test has zero exit status on failures

2021-05-09 Thread Jason Pyeron
Cygport test is not returning a non zero exit status on failure! Is this expected? jenkinsoss-ci-cygwin ~/workspace/oss-cygwin-pdfgrep-2.1.2-x64 $ cygport pdfgrep.cygport test; echo $? >>> Testing pdfgrep-2.1.2-1.x86_64 Making check in src ... WARNING: Couldn't find the global config file. Test