Re: [PATCH setup 2/2] Improve file:// url handling

2018-03-06 Thread Jon Turney
On 28/02/2018 11:51, SZAVAI Gyula wrote: As a repo url, we're accepting * raw windows paths (with both \ and /) c:\cygwin repo \\machine\share\cygwin repo * proper file: urls file:///c:/cygwin%20repo file://machine/share/cygwin%20repo Most non-standard urls accepted by the old code

Re: setup: problems with local install

2018-03-06 Thread Ken Brown
On 3/6/2018 10:18 AM, Jon Turney wrote: (I also note we have also have another 'erase an element from a vector while we are iterating over it' here, so that needs fixing, as well) I think this one might be OK. If I'm not mistaken, pkg.versions.erase(i++) passes a copy of i to erase, and then

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 06/03/2018 15:18, Jon Turney wrote: So yeah, I guess putting some complexity back in accessible() would work, or perhaps the attached?  (This doesn't do the right thing for a few packages, for reasons I'm still looking into...) To be specific it was doing the wrong thing for those few

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 06/03/2018 19:31, Ken Brown wrote: On 3/6/2018 10:18 AM, Jon Turney wrote: (I also note we have also have another 'erase an element from a vector while we are iterating over it' here, so that needs fixing, as well) I think this one might be OK.  If I'm not mistaken,

Re: setup: problems with local install

2018-03-06 Thread Achim Gratz
Ken Brown writes: > I think this one might be OK. If I'm not mistaken, > pkg.versions.erase(i++) passes a copy of i to erase, and then > increments i before erase() has done its work. But I'm no expert on > this. I can't cite chapter and verse right now, but AFAIK iterators over sets are

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 05/03/2018 18:34, Ken Brown wrote: This is a followup to the thread started here:   https://cygwin.com/ml/cygwin/2018-03/msg00027.html There are two problems with installing from a local directory. Thanks very much for looking into these. 2. In several of the views, all packages from

Re: setup: problems with local install

2018-03-06 Thread Jon Turney
On 06/03/2018 02:18, Ken Brown wrote: On 3/5/2018 1:34 PM, Ken Brown wrote: This is a followup to the thread started here:    https://cygwin.com/ml/cygwin/2018-03/msg00027.html There are two problems with installing from a local directory. 1. In the Category view, "No packages found" is