Re: [Patch] readdir_r: fix sense of error-test.

2005-08-28 Thread Christopher Faylor
On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: >(I'm still getting errors on the following testcase after applying >this. (try 0 err=7439xxx)) This is now fixed in CVS, btw. I had a typo in cygwin.din where I had readdir_r = readdir. I discovered this by single stepping into th

Re: [Patch] readdir_r: fix sense of error-test.

2005-08-28 Thread Christopher Faylor
On Sun, Aug 28, 2005 at 11:22:30PM +0200, Bas van Gompel wrote: >Op Sun, 28 Aug 2005 13:16:44 -0400 schreef Christopher Faylor >in <[EMAIL PROTECTED]>: >: On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: >: > If you want to see why this really does not require a copyright- >: > assi

Re: [Patch] readdir_r: fix sense of error-test.

2005-08-28 Thread Bas van Gompel
Op Sun, 28 Aug 2005 13:16:44 -0400 schreef Christopher Faylor in <[EMAIL PROTECTED]>: : On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: : > If you want to see why this really does not require a copyright- : > assignment, view the diff with testsuite/winsup.api/ltp/readdir01.c, : >

[patch] Don't append extra NUL to registry-strings.

2005-08-28 Thread Bas van Gompel
Hi, When RegQueryValueEx returns a string-type, the final NUL is included in the returned size. I suggest dropping it. A ChangeLog-entry? 2005-08-28 Bas van Gompel <[EMAIL PROTECTED]> *fhandler_registry.cc (fhandler_registry::fill_filebuf): Don't keep terminating null-chara

Re: [Patch] readdir_r: fix sense of error-test.

2005-08-28 Thread Christopher Faylor
On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: >If you want to see why this really does not require a copyright- >assignment, view the diff with testsuite/winsup.api/ltp/readdir01.c, >and remove all parts which are just comments. Btw, you can't just grab someone else's source code

Re: [Patch] readdir_r: fix sense of error-test.

2005-08-28 Thread Christopher Faylor
On Sat, Aug 27, 2005 at 09:58:47PM +0200, Bas van Gompel wrote: >2005-08-27 Bas van Gompel <[EMAIL PROTECTED]> > > *dir.cc (readdir_r): Invert sense on error-test. Applied. Thanks. cgf