Re: [PATCH v3 3/3] POSIX Asynchronous I/O support: other files

2018-07-16 Thread Corinna Vinschen
On Jul 15 01:20, Mark Geisert wrote: > Updates to misc files to integrate AIO into the Cygwin source tree. > Much of it has to be done when adding any new syscalls. There are > some updates to limits.h for AIO-specific limits. And some doc mods. > --- > winsup/cygwin/Makefile.in |

Re: [PATCH v3 2/3] POSIX Asynchronous I/O support: fhandler files

2018-07-16 Thread Corinna Vinschen
On Jul 15 01:20, Mark Geisert wrote: > + if (aio) > + status = NtReadFile (prw_handle, aiocb->aio_win_event, NULL, NULL, > + >aio_win_iosb, buf, count, , NULL); > + else > + status = NtReadFile (prw_handle, NULL, NULL, NULL, , buf, count, > +

Re: [PATCH v3 1/3] POSIX Asynchronous I/O support: aio files

2018-07-16 Thread Corinna Vinschen
Hi Mark, this looks good. Inline comments as usual. On Jul 15 01:20, Mark Geisert wrote: > + * (2) no more than AIO_MAX inline AIOs will be in progress at same time. > + * In all other cases queued AIOs will be used. > + * > + * An inline AIO is performed by the calling app's thread as a