Re: [PATCH 2/2] cygheap_pwdgrp: Don't keep old schemes when parsing nsswitch.conf

2020-04-17 Thread Corinna Vinschen
On Apr 17 11:31, David Macek via Cygwin-patches wrote: > The implicit assumption seemed to be that any subsequent occurence of > the same setting in nsswitch.conf is supposed to rewrite the previous > ones completely. This was not the case if the third or any further > schema was previously

Re: [PATCH 1/2] cygheap_pwdgrp: Don't invent undocumented defaults in nsswitch.conf

2020-04-17 Thread Corinna Vinschen
On Apr 17 11:30, David Macek via Cygwin-patches wrote: > --- > winsup/cygwin/uinfo.cc | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc > index 57d90189d3..227faa4248 100644 > --- a/winsup/cygwin/uinfo.cc > +++ b/winsup/cygwin/uinfo.cc

[PATCH 2/2] cygheap_pwdgrp: Don't keep old schemes when parsing nsswitch.conf

2020-04-17 Thread David Macek via Cygwin-patches
The implicit assumption seemed to be that any subsequent occurence of the same setting in nsswitch.conf is supposed to rewrite the previous ones completely. This was not the case if the third or any further schema was previously defined and the last line defined less than that (but at least 2),

[PATCH 1/2] cygheap_pwdgrp: Don't invent undocumented defaults in nsswitch.conf

2020-04-17 Thread David Macek via Cygwin-patches
--- winsup/cygwin/uinfo.cc | 6 -- 1 file changed, 6 deletions(-) diff --git a/winsup/cygwin/uinfo.cc b/winsup/cygwin/uinfo.cc index 57d90189d3..227faa4248 100644 --- a/winsup/cygwin/uinfo.cc +++ b/winsup/cygwin/uinfo.cc @@ -831,12 +831,6 @@ cygheap_pwdgrp::nss_init_line (const char *line)

Re: [PATCH] cygheap_pwdgrp: Handle invalid db_* entries correctly

2020-04-17 Thread Corinna Vinschen
On Apr 16 23:09, David Macek via Cygwin-patches wrote: > If the first scheme in db_* was invalid, the code would think there > were no schemes specified and replace the second scheme with > NSS_SCHEME_DESC. > > Signed-off-by: David Macek > --- > winsup/cygwin/uinfo.cc | 5 - > 1 file