RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Just the suggestion that as all standards support using %#08x to prefix > with 0x (prefix output capitalization follows format letter > capitalization) and would be preferable to hacking the text 0x onto the > format %08X, doing all of the formatting work with the format flags. First off, I am p

Re: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

2022-01-15 Thread Brian Inglis
On 2022-01-15 12:06, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: It is reported by 'configure --help', at the appropriate level (although since enable is the default, I probably should have written '--disable-doc' here). I'm sorry if I'm missing anything, but I updated y'day

Re: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Brian Inglis
Just the suggestion that as all standards support using %#08x to prefix with 0x (prefix output capitalization follows format letter capitalization) and would be preferable to hacking the text 0x onto the format %08X, doing all of the formatting work with the format flags. My awareness and atti

RE: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> It is reported by 'configure --help', at the appropriate level (although > since enable is the default, I probably should have written > '--disable-doc' here). I'm sorry if I'm missing anything, but I updated y'day and this is what I see regarding the doc in configure: $ ./configure --help | g

RE: [EXTERNAL] Re: [PATCH 2/7] Use matching format for NTSTATUS

2022-01-15 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
So? With %X (capital X) the alternate form has the prefix 0X capital, too; and it's really hard to read. IDK what is exactly your point that you are trying to make, is my patch somehow incorrect, or what? Anton Lavrentiev Contractor NIH/NLM/NCBI > -Original Message- > From: Brian Ingl

Re: [PATCH] Cygwin: Conditionally build documentation

2022-01-15 Thread Jon Turney
On 14/01/2022 20:18, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: Add a configure option '--disable-doc' to disable building of the documentation by the 'all' target. Can you please also add --disable-doc to "configure --help"? It took me awhile to figure out which option I should use to skip