Re: [PATCH] Cygwin: Fix configure help for --{en, dis}able-doc option.

2022-01-18 Thread Corinna Vinschen
On Jan 18 19:57, Jon Turney wrote: > Report '--disable-doc' in 'configure --help', as enable is the default. > --- > winsup/configure.ac | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Sure. Thanks, Corinna

Re: [PATCH] Cygwin: resolver: A few fixes for cygwin_query(), part 2

2022-01-18 Thread Corinna Vinschen
On Jan 18 19:07, Anton Lavrentiev via Cygwin-patches wrote: > Make sure Windows ResultSet is free'd when dn_comp failed internally > --- > winsup/cygwin/libc/minires-os-if.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) Great, thanks! I pushed all your resolver patches.

[PATCH] Cygwin: resolver: A few fixes for cygwin_query(), part 2

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
Make sure Windows ResultSet is free'd when dn_comp failed internally --- winsup/cygwin/libc/minires-os-if.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/libc/minires-os-if.c b/winsup/cygwin/libc/minires-os-if.c index 5da1c0c55..c6fde776a 100644 ---

[PATCH 1/2] Cygwin: resolver: Fix to match response ID with request ID

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
In case when the native OS resolver is used (via os_query) the returned response ID is always 0. It should actually match the ID passed in to res_send() in the DNS request header. This patch fixes that --- winsup/cygwin/libc/minires-os-if.c | 6 +- winsup/cygwin/libc/minires.c | 7

[PATCH 2/2] Cygwin: resolver: Targets in SRV DNS responses may not be compressed

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
RFC2782 clearly says so yet it's a common misconception to perform the compression in the violation of the standard. This patch fixes that --- winsup/cygwin/libc/minires-os-if.c | 1 + 1 file changed, 1 insertion(+) diff --git a/winsup/cygwin/libc/minires-os-if.c

Cygwin: resolver: more fixes

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
Proposed are two fixes for more little bugs in the resolver. The first one fixes the ID field returned in the response to match the ID of the request (even in the case when the OS-supplied native resolver is used). The second one is about the standard compliance (when the response is relayed from

[PATCH] Cygwin: resolver: A few fixes for cygwin_query()

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
- Make sure the answer buffer is properly cleared so there is no trailing garbage when the response does not fit entirely in; - Make sure an internal decomp failure gets reported correctly (w/return code -1); - Make sure that the buffer is not overrun when filling out the header. ---

Re: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

2022-01-18 Thread Jon Turney
On 15/01/2022 23:00, Brian Inglis wrote: On 2022-01-15 12:06, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: It is reported by 'configure --help', at the appropriate level (although since enable is the default, I probably should have written '--disable-doc' here). [...] It

Re: [EXTERNAL] Re: [PATCH] Cygwin: Conditionally build documentation

2022-01-18 Thread Jon Turney
On 17/01/2022 19:39, Lavrentiev, Anton (NIH/NLM/NCBI) [C] wrote: It is reported by 'configure --help', at the appropriate level (although since enable is the default, I probably should have written '--disable-doc' here). Can you please make it show as --disable-doc ? It would almost be less

RE: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

2022-01-18 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> Thanks for the description. Would you mind to recreate your patch with > a matching commit message text explaining the debug flag setting? Okay, just did. Anton Lavrentiev Contractor NIH/NLM/NCBI

[PATCH] Cygwin: resolver: Process options forward (not backwards)

2022-01-18 Thread Anton Lavrentiev via Cygwin-patches
Also, make sure the debug setting propagates to the parser of the remainder of /etc/resolv.conf --- winsup/cygwin/libc/minires.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/winsup/cygwin/libc/minires.c b/winsup/cygwin/libc/minires.c index 0cf9efd9b..fdc6087f5

Re: [EXTERNAL] Re: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

2022-01-18 Thread Corinna Vinschen
On Jan 18 13:58, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > > I pushed patches 1 and 3 to 5. I fixed the consitency typo > > throughout. > > Thanks! (and oops :-) > > > Right now, the debug flag gets set in several places throughout the > > code. Given you set the debug

RE: [EXTERNAL] Re: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

2022-01-18 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
> I pushed patches 1 and 3 to 5. I fixed the consitency typo > throughout. Thanks! (and oops :-) > Right now, the debug flag gets set in several places throughout the > code. Given you set the debug flag above, doesn't that mean several > code snippets setting the debug flag later in the code

Re: [PATCH] Cygwin: fhandler_base: Fix double free caused when open() fails.

2022-01-18 Thread Corinna Vinschen
On Jan 18 08:05, Takashi Yano wrote: > - When open fails, archetype stored in archetypes[] is not cleared. > This causes double free when next open fail. This patch fixes the > issue. > > Addresses: > https://cygwin.com/pipermail/cygwin/2022-January/250518.html > --- >

Re: [PATCH] path_conv: do not get confused by a directory with `.lnk` suffix

2022-01-18 Thread Corinna Vinschen
On Jan 17 21:20, Johannes Schindelin wrote: > When trying to create a directory called `xyz` in the presence of a > directory `xyz.lnk`, the Cygwin runtime errors out with an `ENOENT`. > > The root cause is actually a bit deeper: the `symlink_info::check()` > method tries to figure out whether

Re: resolver //Was: [PATCH 3/7] Debug output to show both IP and port # in native b.o., a few little cosmetic improvements for consistency

2022-01-18 Thread Corinna Vinschen
Hi Anton, On Jan 17 18:29, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: > Hi Corinna, > > > Other than that, the remaining patches look good, except, adding a short > > description what patch 7 does to the commit message would be great for > > later readers of the git log. > >

Re: [PATCH 2/5] Cygwin: resolver: Process options forward (not backwards)

2022-01-18 Thread Corinna Vinschen
Hi Anton, I pushed patches 1 and 3 to 5. I fixed the consitency typo throughout. As for this path 2: On Jan 17 13:03, Anton Lavrentiev via Cygwin-patches wrote: > --- > winsup/cygwin/libc/minires.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git