Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

2022-06-30 Thread Ken Brown
On 6/30/2022 11:45 AM, Ken Brown wrote: On 6/27/2022 8:44 AM, Takashi Yano wrote: - With this patch, the empty path (empty element in PATH or PATH is    absent) is treated as the current directory as Linux does. Addresses: https://cygwin.com/pipermail/cygwin/2022-June/251730.html It might be a

Re: [EXTERNAL] Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

2022-06-30 Thread Takashi Yano
On Thu, 30 Jun 2022 18:35:04 + "Lavrentiev, Anton \(NIH/NLM/NCBI\) \[C\] wrote: > >However, use of this feature is deprecated, and POSIX > >notes that a conforming application shall use an explicit > >pathname (e.g., .) to specify the current wor

Re: [EXTERNAL] Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

2022-06-30 Thread Brian Inglis
On 2022-06-30 12:35, Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches wrote: However, use of this feature is deprecated, and POSIX notes that a conforming application shall use an explicit pathname (e.g., .) to specify the current working directory. Since "SHALL" does not mean "MUST

RE: [EXTERNAL] Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

2022-06-30 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via Cygwin-patches
>However, use of this feature is deprecated, and POSIX >notes that a conforming application shall use an explicit >pathname (e.g., .) to specify the current working >directory. Since "SHALL" does not mean "MUST", I think this patch i

Re: [PATCH] Cygwin: poll: Fix a bug on inquiring same fd with different events.

2022-06-30 Thread Ken Brown
On 6/26/2022 9:50 PM, Takashi Yano wrote: - poll() has a bug that it returns event which is not inquired if events are inquired in multiple pollfd entries on the same fd at the same time. This patch fixes the issue. Addresses: https://cygwin.com/pipermail/cygwin/2022-June/251732.html LGTM

Re: [PATCH] Cygwin: spawn: Treat empty path as the current directory.

2022-06-30 Thread Ken Brown
On 6/27/2022 8:44 AM, Takashi Yano wrote: - With this patch, the empty path (empty element in PATH or PATH is absent) is treated as the current directory as Linux does. Addresses: https://cygwin.com/pipermail/cygwin/2022-June/251730.html It might be a good idea to include a comment in the co