Re: [PATCH] Cygwin: pthread: Fix handle leak in pthread_once.

2024-01-24 Thread Corinna Vinschen
On Jan 24 23:48, Takashi Yano wrote: > On Wed, 24 Jan 2024 15:40:22 +0100 > Corinna Vinschen wrote: > > (You don't have to CC me, btw., I only get the same mail twice then > > and I look into this mailing list constantly anyway) > > Perhaps, CC: is added automatically by git send-email if >

Re: [PATCH] Cygwin: pthread: Fix handle leak in pthread_once.

2024-01-24 Thread Takashi Yano
On Wed, 24 Jan 2024 15:40:22 +0100 Corinna Vinschen wrote: > (You don't have to CC me, btw., I only get the same mail twice then > and I look into this mailing list constantly anyway) Perhaps, CC: is added automatically by git send-email if Reviewed-by: exists. I'll try --no-cc option next time.

Re: [PATCH] Cygwin: pthread: Fix handle leak in pthread_once.

2024-01-24 Thread Corinna Vinschen
On Jan 24 22:44, Takashi Yano wrote: > If pthread_once() is called with pthread_once_t initialized using > PTREAD_ONCE_INIT, pthread_once does not release pthread_mutex used > internally. This patch fixes that by calling pthread_mutex_destroy() > in the thread which has called init_routine. > >

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-24 Thread Corinna Vinschen
On Jan 24 13:28, Jon Turney wrote: > On 23/01/2024 14:29, Corinna Vinschen wrote: > > On Jan 23 14:20, Jon Turney wrote: > > > > > Even then this is clearly not totally bullet-proof. Maybe the right thing > > > to > > > do is add a suitable timeout here, so even if we fail to notice the > > >

[PATCH] Cygwin: pthread: Fix handle leak in pthread_once.

2024-01-24 Thread Takashi Yano
If pthread_once() is called with pthread_once_t initialized using PTREAD_ONCE_INIT, pthread_once does not release pthread_mutex used internally. This patch fixes that by calling pthread_mutex_destroy() in the thread which has called init_routine. Reviewed-by: Corinna Vinschen Signed-off-by:

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-24 Thread Jon Turney
On 23/01/2024 14:29, Corinna Vinschen wrote: On Jan 23 14:20, Jon Turney wrote: Even then this is clearly not totally bullet-proof. Maybe the right thing to do is add a suitable timeout here, so even if we fail to notice the DebugActiveProcess() (or there's a custom JIT debugger which just