Re: [1.7] bugs in faccessat

2009-09-08 Thread Christopher Faylor
On Tue, Sep 08, 2009 at 09:16:57PM +0200, Corinna Vinschen wrote: >On Sep 7 16:05, Christopher Faylor wrote: >> On Thu, Sep 03, 2009 at 11:04:38PM +0200, Corinna Vinschen wrote: >> >Thanks for the patches Eric, but, here's a problem. We still have no >> >copyri

Re: [1.7] bugs in faccessat

2009-09-07 Thread Christopher Faylor
On Thu, Sep 03, 2009 at 11:04:38PM +0200, Corinna Vinschen wrote: >On Sep 3 15:18, Christopher Faylor wrote: >> On Thu, Sep 03, 2009 at 01:08:57PM -0600, Eric Blake wrote: >> >-BEGIN PGP SIGNED MESSAGE- >> >Hash: SHA1 >> > >> >According to Er

Re: [1.7] bugs in faccessat

2009-09-03 Thread Christopher Faylor
On Thu, Sep 03, 2009 at 01:08:57PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >According to Eric Blake on 9/3/2009 9:58 AM: >> faccessat has at least two, and probably three bugs. > >Here's a fix for 1 (typo) and 3 (check for EINVAL in more places), but not >for 2 (e

Re: fcntl bug

2009-09-03 Thread Christopher Faylor
On Thu, Sep 03, 2009 at 01:06:58PM -0600, Eric Blake wrote: >> If it is important to you then please provide a patch. > >2009-09-03 Eric Blake > > * dtable.h (OPEN_MAX_MAX): New macro. > * resource.cc (getrlimit) [RLIMIT_NOFILE]: Use it. > * dtable.cc (dtable::extend): Likewise

Re: [PATCH] Update cygport README link

2009-08-24 Thread Christopher Faylor
On Mon, Aug 24, 2009 at 09:43:40PM -0500, Yaakov (Cygwin/X) wrote: >cygport development moved from CVS to SVN some time ago, but setup.html >still points to ViewCVS. > >OK to apply? Yes, but... FYI, this isn't the right list for this type of patch. This is for cygwin source code not cygwin web

Re: winsup build machinery

2009-08-18 Thread Christopher Faylor
On Tue, Aug 18, 2009 at 11:03:33PM -0400, Christopher Faylor wrote: >This isn't appropriate for this list since there are no patches here. >And, redirecting discussion to a subscriber-only list could be pretty >frustrating for all non-subscribers since they will get a bounce if >t

Re: winsup build machinery

2009-08-18 Thread Christopher Faylor
This isn't appropriate for this list since there are no patches here. And, redirecting discussion to a subscriber-only list could be pretty frustrating for all non-subscribers since they will get a bounce if they reply. I've redirected the original discussion to the cygwin list. cgf

Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0

2009-08-10 Thread Christopher Faylor
On Mon, Aug 10, 2009 at 05:36:54PM +0100, Dave Korn wrote: >Christopher Faylor wrote: >>On Mon, Aug 10, 2009 at 05:28:16AM +0100, Dave Korn wrote: >>>My turn to say "ugh"! The wrapper function would translate down to a >>>single 'jmp' if -fno-

Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0

2009-08-10 Thread Christopher Faylor
On Mon, Aug 10, 2009 at 05:28:16AM +0100, Dave Korn wrote: >Christopher Faylor wrote: >> On Mon, Aug 10, 2009 at 04:11:49AM +0100, Dave Korn wrote: >>> * fhandler_tty.cc (process_input): Add dummy return to silence warning. >>> (process_ioctl): Likewise. >&g

Re: [PATCHes] Misc aliasing fixes for building DLL with gcc-4.5.0

2009-08-09 Thread Christopher Faylor
On Mon, Aug 10, 2009 at 04:11:49AM +0100, Dave Korn wrote: > * fhandler_tty.cc (process_input): Add dummy return to silence warning. > (process_ioctl): Likewise. Shouldn't these be defined with __attribute__ ((noreturn))? > * fork.cc (cygfork): New name with friendable C++ linka

Re: [PATCH] Find MinGW in more places

2009-08-09 Thread Christopher Faylor
On Sun, Aug 09, 2009 at 08:42:19PM +0100, Dave Korn wrote: > > Hi gang, > > I often run into this problem when I'm using a compiler that I've installed > in >a non-standard $prefix: the utils/mingw script expects to find the MinGW >sysroot >in the same place the compiler's --print-prog-name=

Re: [PATCH] Fix order of dtors problem.

2009-07-30 Thread Christopher Faylor
On Thu, Jul 30, 2009 at 02:47:06PM +0100, Dave Korn wrote: > > This is the patch I'm currently testing (so far, uneventfully). I thought > I'd >send it here for posterity just in case I get squashed by a falling hippo or >anything over the weekend. > >winsup/cygwin/ChangeLog: > > * globals

Re: [PATCH] Re: 1.7 winbase.h (ilockcmpexch) compile error

2009-07-13 Thread Christopher Faylor
On Mon, Jul 13, 2009 at 10:36:03AM +0100, Dave Korn wrote: >Corinna Vinschen wrote: >> On Jul 12 21:52, Christopher Faylor wrote: > >>> There is a subtle difference in the generated code if you do this: >>> >>> --- winbase.h 7 Jul 2009 21:41:43 -

Re: [PATCH] Re: 1.7 winbase.h (ilockcmpexch) compile error

2009-07-12 Thread Christopher Faylor
On Wed, Jul 08, 2009 at 01:11:53AM +0100, Dave Korn wrote: >Dave Korn wrote: >>It doesn't do anything about the reload failure, which is a bug in >>GCC-3, since the usage is a standard usage supported by the >>documentation. It's possible that it may disappear as a side-effect, >>in which case all

Re: [PATCH] Re: 1.7 winbase.h (ilockcmpexch) compile error

2009-07-07 Thread Christopher Faylor
On Tue, Jul 07, 2009 at 10:55:13PM +0100, Dave Korn wrote: >Christopher Faylor wrote: >> On Tue, Jul 07, 2009 at 10:21:33PM +0100, Dave Korn wrote: > >>> winsup/cygwin/ChangeLog: >>> >>> * winbase.h (ilockexch): Avoid making 'ret' volatil

Re: [PATCH] Re: 1.7 winbase.h (ilockcmpexch) compile error

2009-07-07 Thread Christopher Faylor
On Tue, Jul 07, 2009 at 10:21:33PM +0100, Dave Korn wrote: >Brian Ford wrote: >> I'm trying to build Cygwin 1.7 from CVS to debug an ImageMagick problem on >> server 2008 that causes an access violation in cygwin1.dll. Doe anyone >> know the work around for this issue? >> >> g++ (GCC) 3.4.4 (cygm

Re: [PATCH] Libstdc++ support changes.

2009-07-07 Thread Christopher Faylor
On Tue, Jul 07, 2009 at 06:54:43PM +0100, Dave Korn wrote: >Corinna Vinschen wrote: > >> In the ChangeLogs, >> please use just one space after the colon. > > Sure. > >> At some points you're using different comment types rather freely. > >> Other than that it looks like you tested this a lot so it

Re: [PATCH] Libstdc++ support changes.

2009-07-07 Thread Christopher Faylor
On Tue, Jul 07, 2009 at 07:18:58PM +0200, Corinna Vinschen wrote: >Hi Dave, > >Thanks for doing that stuff! > >On Jul 7 17:22, Dave Korn wrote: >> >> Hi all, >> >> I just got done doing a C/C++/libstdc++-v3 test run against GCC HEAD using >> the Cygwin DLL built with these patches, and eve

Re: AttachConsole broken autoload

2009-07-04 Thread Christopher Faylor
On Sat, Jul 04, 2009 at 01:47:23PM +0100, Dave Korn wrote: > > Got this error when I tried to run with a DLL built from today's CVS HEAD: > >> --- >> bash.exe - Entry Point Not Found >> --- >> The procedure entry point AttachConsole could not be loca

Re: mkstemps

2009-07-03 Thread Christopher Faylor
On Fri, Jul 03, 2009 at 01:19:10PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >According to Christopher Faylor on 7/3/2009 9:17 AM: >> Is there some reason why we're not just using the newlib version of all >> of these functions?

Re: mkstemps

2009-07-03 Thread Christopher Faylor
On Fri, Jul 03, 2009 at 03:01:34PM +0200, Corinna Vinschen wrote: >On Jul 3 06:34, Eric Blake wrote: >> -BEGIN PGP SIGNED MESSAGE- >> Hash: SHA1 >> >> According to Eric Blake on 7/3/2009 6:31 AM: >> > With that vote of confidence, here's the patch (the changes to mktemp.cc, >> > modulo a

Re: [PATCH?] Separate pthread patches, #2 take 2.

2009-06-05 Thread Christopher Faylor
On Fri, Jun 05, 2009 at 03:04:59PM +0100, Dave Korn wrote: >winsup/cygwin/ChangeLog > > * winbase.h (ilockexch): Fix asm constraints. > (ilockcmpexch): Likewise. Thanks for seeing this through. It was obviously a lot of work. cgf

Re: [PATCH?] Separate pthread patches, #2 take 3

2009-06-03 Thread Christopher Faylor
On Thu, Jun 04, 2009 at 04:03:03AM +0100, Dave Korn wrote: >but it's a horrible bit of code. Declaring the memory location as input only, >then clobbering all of memory and potentially confusing the optimisers with >type aliasing casts? It makes me very uneasy. Ok. I'm convinced. Please check

Re: [PATCH?] Separate pthread patches, #2 take 3

2009-06-03 Thread Christopher Faylor
On Thu, Jun 04, 2009 at 12:47:48AM +0100, Dave Korn wrote: >Dave Korn wrote: >> The attached patch implements ilockexch and ilockcmpexch, using the inline >> asm definition from __arch_compare_and_exchange_val_32_acq in >> glibc-2.10.1/sysdeps/i386/i486/bits/atomic.h, trivially expanded inline >

Re: [PATCH] Separate pthread fixes #1

2009-06-03 Thread Christopher Faylor
On Thu, Jun 04, 2009 at 12:11:24AM +0100, Dave Korn wrote: > > The attached patch separates out the uncontroversial change to the >__cygwin_lock* functions. > >winsup/cygwin/ChangeLog > > * thread.cc (__cygwin_lock_lock): Delete racy optimisation. > (__cygwin_lock_unlock): Likewise.

Re: [PATCH] Pthread fixes arising.

2009-06-03 Thread Christopher Faylor
On Wed, Jun 03, 2009 at 07:16:04PM +0100, Dave Korn wrote: >winsup/cygwin/ChangeLog > > * thread.cc (__cygwin_lock_lock): Delete racy optimisation. > (__cygwin_lock_unlock): Likewise. > > * winbase.h (ilockexch): Fix asm constraints. > (ilockcmpexch): Likewise. > > OK f

Re: [PATCH] Re: [1.5] ls -l on /cygdrive/d doesn't work

2009-05-27 Thread Christopher Faylor
On Tue, May 26, 2009 at 12:41:03PM +0200, David Engraf wrote: >I have fixed the error in ntea.cc handling the return value of >NTQueryEaFile. This patch is only needed for the 1.5 release. Maybe this >error should be considered as critical due to uninitialized stack usage >of the variable fea wh

Re: avoid compiler warning with DEBUGGING

2009-05-20 Thread Christopher Faylor
On Wed, May 20, 2009 at 06:51:19AM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >I noticed a complaint about comparing signed and unsigned values, when >compiling with DEBUGGING enabled. net.cc also has a lot of trailing blanks. > >2009-05-20 Eric Blake > > *

Re: sys/socket.h: define SOL_IPV6?

2009-04-26 Thread Christopher Faylor
On Sun, Apr 26, 2009 at 10:22:07PM -0500, Yaakov (Cygwin/X) wrote: >Does it make sense to define SOL_IPV6 now? Patch attached if so. I think it does. I've checked in this patch. I'm sure Corinna will revert it if I am wrong. Thanks. cgf

Re: The Return of Revenge of Son of the Speclib Strikes Back :)

2009-04-18 Thread Christopher Faylor
On Sat, Apr 18, 2009 at 02:53:37PM +0100, Dave Korn wrote: >[ Let's try again in the right place, shall we? ] Now more tempest with even less teapot! >The new speclibs libraries work great, but there's one piece of >unanticipated fallout: the libtool func_win32_libid() tests can no >longer identi

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-13 Thread Christopher Faylor
On Sat, Apr 11, 2009 at 08:48:35PM +0100, Dave Korn wrote: >Christopher Faylor wrote: > >> >> So the answer is "int". > > > Oh, drat. Yes, shoulda changed the type, not the constant. Gah. Like >this, you mean? > > >winsup/cygwin/ChangeLog >

Re: [PATCH] Add libz to dumper.exe link [was Re: Re: speclib vs. -lc trouble.]

2009-04-13 Thread Christopher Faylor
On Mon, Apr 13, 2009 at 08:31:13PM +0100, Dave Korn wrote: >Christopher Faylor wrote: >> On Mon, Apr 13, 2009 at 06:34:04PM +0100, Dave Korn wrote: >>> Christopher Faylor wrote: >>>> I think you can get by with just adding -lz to the ALL_LDFLAGS line and >>>

Re: [PATCH] Add libz to dumper.exe link [was Re: Re: speclib vs. -lc trouble.]

2009-04-13 Thread Christopher Faylor
On Mon, Apr 13, 2009 at 06:34:04PM +0100, Dave Korn wrote: >Christopher Faylor wrote: >>I think you can get by with just adding -lz to the ALL_LDFLAGS line and >>removing the other stuff. The tests for libintl and libbfd are >>supposed to just detect if the appropriate dire

Re: [PATCH] Add libz to dumper.exe link [was Re: Re: speclib vs. -lc trouble.]

2009-04-13 Thread Christopher Faylor
On Mon, Apr 13, 2009 at 05:11:10PM +0100, Dave Korn wrote: > Ok? > >winsup/utils/ChangeLog > > * Makefile.in (libz): New makefile variable. > (build_dumper): Test it was correctly set. > (dumper.exe): Use it. > >Index: winsup/utils/Makefile.in >

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-11 Thread Christopher Faylor
On Sat, Apr 11, 2009 at 07:17:54PM +0100, Dave Korn wrote: >Christopher Faylor wrote: >> On Sat, Apr 11, 2009 at 10:07:36AM +0200, Corinna Vinschen wrote: >>> On Apr 11 04:51, Dave Korn wrote: >>>> Corinna Vinschen wrote: >>>> >>>>> Good poi

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-11 Thread Christopher Faylor
On Sat, Apr 11, 2009 at 10:07:36AM +0200, Corinna Vinschen wrote: >On Apr 11 04:51, Dave Korn wrote: >> Corinna Vinschen wrote: >> >> > Good point, I guess. So, if we all agree on that, I'd suggest to >> > change Dave's patch to the one below. >> >> Two hunks went astray in the adjustment, the

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-07 Thread Christopher Faylor
On Tue, Apr 07, 2009 at 07:24:07PM +0200, Corinna Vinschen wrote: >On Apr 7 11:08, Christopher Faylor wrote: >>Or as in the "WJM" aforementioned sense. > >Sounds like "WJM" matches exactly what my patch does. I've checked it >in. I feel so satisfied. Thanks. cgf

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-07 Thread Christopher Faylor
On Tue, Apr 07, 2009 at 10:57:02AM -0400, Charles Wilson wrote: >Christopher Faylor wrote: >> I don't entirely understand when people think it's ok to make sweeping >> changes for 1.7 and when they think we need to be conservative. > >MHO is that 1.7+gcc4 is alre

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-07 Thread Christopher Faylor
On Tue, Apr 07, 2009 at 01:33:24PM +0100, Dave Korn wrote: >CGF? You asked a couple of questions and then dropped out of the >thread for a couple of days. Have you reached any conclusions? Stomach flu will do that to you... cgf

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-07 Thread Christopher Faylor
On Tue, Apr 07, 2009 at 06:56:53AM -0600, Eric Blake wrote: >According to Christopher Faylor on 4/4/2009 12:24 AM: >>> Because our stdint.h types are divergent from Linux, and changing them >>> instead could cause yet another ABI break. >> >>Why would changing

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-07 Thread Christopher Faylor
On Sat, Apr 04, 2009 at 08:23:49AM +0100, Dave Korn wrote: >Christopher Faylor wrote: > > Ah, I could address a bit more to these two questions as well: > >> Isn't a long 32 bits? What would be the ABI breakage in changing that >> one typedef rather than lots of #d

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-03 Thread Christopher Faylor
On Sat, Apr 04, 2009 at 02:24:59AM -0400, Christopher Faylor wrote: >On Sat, Apr 04, 2009 at 05:11:09AM +0100, Dave Korn wrote: >>Christopher Faylor wrote: >> >>>> The attached patch fixes all these by adjusting only the suffix letters. >>>> OK >>&

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-03 Thread Christopher Faylor
On Sat, Apr 04, 2009 at 05:11:09AM +0100, Dave Korn wrote: >Christopher Faylor wrote: > >>> The attached patch fixes all these by adjusting only the suffix letters. >>> OK >>> for head? >>> >>> winsup/cygwin/ChangeLog >>> >>>

Re: [PATCH] Fix type inconsistencies in stdint.h

2009-04-03 Thread Christopher Faylor
On Sat, Apr 04, 2009 at 02:33:11AM +0100, Dave Korn wrote: > >Hi team, > > Upstream GCC just gained the ability to know all about the stdint.h types >and limits internally. If you're interested in the background, see > >http://gcc.gnu.org/ml/gcc/2009-04/msg0.html > >and thread for fur

Re: errno.h: ESTRPIPE

2009-03-14 Thread Christopher Faylor
On Sat, Mar 14, 2009 at 10:25:59AM +0100, Corinna Vinschen wrote: >On Mar 13 17:47, Christopher Faylor wrote: >>On Fri, Mar 13, 2009 at 09:59:49PM +0100, Corinna Vinschen wrote: >>>On Mar 13 10:50, Christopher Faylor wrote: >>>>Defining a unique value means that, if

Re: errno.h: ESTRPIPE

2009-03-13 Thread Christopher Faylor
On Fri, Mar 13, 2009 at 09:59:49PM +0100, Corinna Vinschen wrote: >On Mar 13 10:50, Christopher Faylor wrote: >> On Fri, Mar 13, 2009 at 06:10:48AM -0600, Warren Young wrote: >> > Corinna Vinschen wrote: >> >> This is very Linux device specific and this never occu

Re: errno.h: ESTRPIPE

2009-03-13 Thread Christopher Faylor
On Fri, Mar 13, 2009 at 06:10:48AM -0600, Warren Young wrote: > Corinna Vinschen wrote: >> This is very Linux device specific and this never occurs on Cygwin. >> What about just defining this error code to some arbitrary value like >> #ifdef __CYGWIN__ >> #define ESTRPIPE >> #endif > > I

Re: [Patch] gethostbyname2 again

2009-03-06 Thread Christopher Faylor
On Fri, Mar 06, 2009 at 09:41:00AM -0500, Pierre A. Humblet wrote: > >- Original Message - >[snip] I see you've joined the throng of people who duplicate bits from the header in the body of a message. Do you really need to do this? > >| On Tue, Mar 03, 2009 at 12:50:21PM -0500, Pierre A

Re: [Patch] gethostbyname2 again

2009-03-05 Thread Christopher Faylor
On Tue, Mar 03, 2009 at 12:50:21PM -0500, Pierre A. Humblet wrote: > >- Original Message - >From: "Christopher Faylor" <> >To: >Sent: Tuesday, March 03, 2009 10:38 AM >Subject: Re: [Patch] gethostbyname2 again > > >| On Mon, Mar 02, 2009 a

Re: [Patch] gethostbyname2 again

2009-03-03 Thread Christopher Faylor
On Mon, Mar 02, 2009 at 08:36:55PM -0500, Pierre A. Humblet wrote: >realloc_ent function, and call it from both dup_ent and the helper. That > caused minor >changes in the 4 versions of dup_ent, and I don't know exactly what > format to use in the ChangeLog I would rather that you keep d

Re: [PATCH] w32api fixes commctrl.h listview

2009-02-24 Thread Christopher Faylor
On Tue, Feb 24, 2009 at 03:38:56PM -0800, Michael James wrote: >A simple patch. My application was misbehaving only when built with >mingw. It turned out that this incorrect header value was at fault. I >am also submitting this patch to the mingw patch tracker on >sourceforge. > >Does anyone have a

Re: [PATCH/libiberty] Fix PR38903 Cygwin GCC bootstrap failure [was Re: Libiberty issue vs cygwin [was Re: This is a Cygwin failure yeah?]]

2009-01-17 Thread Christopher Faylor
On Sun, Jan 18, 2009 at 12:52:14AM +, Dave Korn wrote: >DJ Delorie wrote: >>IIRC, that whole clause was because cygwin's dll itself linked with >>libiberty, so the auto-detect stuff needed an override to make sure the >>right files were there when you build cygwin1.dll. Otherwise, it would >>d

Re: [Patch] Make cygcheck handle Windows paths with spaces

2009-01-05 Thread Christopher Faylor
On Mon, Jan 05, 2009 at 10:19:59AM -0500, Pierre A. Humblet wrote: >Oops, I didn't notice that one line required a double fix. > >Pierre > >2009-01-05 Pierre Humblet > >* cygcheck.cc (dump_sysinfo_services): Quote the path for popen. Looks good. Please check in. Thanks. cgf

Re: [Patch] Make cygcheck handle Window paths with spaces

2008-12-30 Thread Christopher Faylor
On Tue, Dec 30, 2008 at 03:14:30PM -0500, Pierre A. Humblet wrote: >Formatting is more likely to be preserved in the attached files. > >Pierre > >2008-12-30 Pierre Humblet > >* cygcheck.cc (pretty_id): Quote the path for popen. >(dump_sysinfo_services): Ditto. Looks good. Plea

Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?

2008-11-28 Thread Christopher Faylor
On Fri, Nov 28, 2008 at 10:32:55PM +0100, Christian Franke wrote: >Attn maintainers: >If package with dirent.d_type support is rebuild with new sys/dirent.h, >it is no longer backward compatible with older Cygwin releases. This >is IMO no problem for packages rebuild for 1.7. We never guarantee t

Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?

2008-11-27 Thread Christopher Faylor
On Thu, Nov 27, 2008 at 10:41:56PM +0100, Christian Franke wrote: > Corinna Vinschen wrote: >> The logic sounds ok to me. I just don't think we need a warning and the >> condition could be simplified accordingly. >> >> > > New patch below. Conditionals removed as suggested by cgf. > > Define o

Re: [Patch] Add dirent.d_type support to Cygwin 1.7 ?

2008-11-26 Thread Christopher Faylor
On Wed, Nov 26, 2008 at 10:24:14PM +0100, Christian Franke wrote: > This is an experimental patch to add dirent.d_type support to readdir(). It > sets d_type to DT_DIR/REG for normal disk directories/files and DT_UNKNOWN > in all other cases. > > Test result with original find (4.4.0-3) vs. same

Re: strerrno and new errno values

2008-09-19 Thread Christopher Faylor
On Fri, Sep 19, 2008 at 04:06:36PM -0600, Eric Blake wrote: >-BEGIN PGP SIGNED MESSAGE- >Hash: SHA1 > >OK to apply, to match newlib and in preparation for POSIX 200x? > >2008-09-19 Eric Blake <[EMAIL PROTECTED]> > > * errno.cc (_sys_errlist): Add ECANCELED, ENOTRECOVERABLE, >

Re: [PATCH] fix unlink for Cygwin 1.5.25-15 -- unintended data loss with symbolic file links

2008-09-15 Thread Christopher Faylor
On Mon, Sep 15, 2008 at 02:31:07PM -0700, Jason wrote: >Please consider the patch below for inclusion in the Cygwin 1.5 branch which >corrects the deletion of symbolic link file types (Vista file reparse >points). > >The problem is that CreateFile will open the target and not the link. See >the MS

Re: [PATCH] fix profiling

2008-08-05 Thread Christopher Faylor
On Mon, Aug 04, 2008 at 10:11:04PM -0700, Brian Dessent wrote: >2008-08-04 Brian Dessent > > * config/i386/profile.h (mcount): Mark asms volatile. Go ahead and check this in and I'll roll a new release. Please use your best judgement about the +r/=r thing given Dave's comments. cgf

Re: Patch for pformat.c in winsup/mingw CVS

2008-08-01 Thread Christopher Faylor
On Fri, Aug 01, 2008 at 02:53:53PM +0100, Colin Harrison wrote: >The latest CVS winsup/mingw runtime caused a crash, for me, in strlen() >when testing previously 'good' code built with it in the toolchain. I >found this patch fixed the problem for me, so it may be of help to >others... You should

Re: cygcheck linking without libz

2008-07-29 Thread Christopher Faylor
On Wed, Jul 30, 2008 at 12:57:26AM -0500, Yaakov (Cygwin Ports) wrote: >+2008-07-30 Yaakov Selkowitz <[EMAIL PROTECTED]> >+ >+ * Makefile.in: Link cygcheck with -lntdll even without mingw-zlib. Applied. Thanks. (Btw, minor nit: Please don't post ChangeLog entries as a patch. Just send th

Re: use volatile when replacing Interlocked*

2008-07-12 Thread Christopher Faylor
On Sat, Jul 12, 2008 at 10:07:59AM -0600, Eric Blake wrote: > |> 2008-07-12 Eric Blake <[EMAIL PROTECTED]> > |> > |>Fix usage of recently fixed Interlocked* functions. > |>* winbase.h (ilockincr, ilockdecr, ilockexch, ilockcmpexch): Add > |>volatile qualifier, to match Interlocked* fu

Re: abort() bug

2008-06-09 Thread Christopher Faylor
On Mon, Jun 09, 2008 at 06:11:53AM -0600, Eric Blake wrote: > 2008-06-09 Eric Blake <[EMAIL PROTECTED]> > > * signal.cc (abort): Only flush streams after signal handler. Applied. Thank you! cgf

Re: [patch] recognise when an exec()d process terminates due to unhandled exception

2008-03-23 Thread Christopher Faylor
On Sun, Mar 23, 2008 at 08:09:06PM -0400, Christopher Faylor wrote: >On Sun, Mar 23, 2008 at 01:48:15PM -0700, Brian Dessent wrote: >>Christopher Faylor wrote: >>>After poking at this a little, I think it would be better to issue a >>>linux-like error message. >>&g

Re: [patch] recognise when an exec()d process terminates due to unhandled exception

2008-03-23 Thread Christopher Faylor
On Sun, Mar 23, 2008 at 01:48:15PM -0700, Brian Dessent wrote: >Christopher Faylor wrote: >>After poking at this a little, I think it would be better to issue a >>linux-like error message. >> >>In my sandbox, I now have this: >> >>bash-3.2$ ./libtest /c

Re: [patch] recognise when an exec()d process terminates due to unhandled exception

2008-03-22 Thread Christopher Faylor
On Fri, Mar 14, 2008 at 04:08:46AM -0700, Brian Dessent wrote: >Brian Dessent wrote: > >> isn't present, etc. I was really hoping to figure out a cool way to get >> that info, perhaps by poking around in the TEB or PEB somewhere, but I >> haven't gotten that far. If anyone has any general ideas w

Re: [patch] recognise when an exec()d process terminates due to unhandled exception

2008-03-22 Thread Christopher Faylor
On Fri, Mar 14, 2008 at 11:11:43PM -0700, Brian Dessent wrote: >Christopher Faylor wrote: >>That was going to be my first observation, actually. I'm still trying >>to digest the patch but it seems like it wouldn't work well with the >>fork retry code. > >

Re: [PATCH] QueryDosDevice in handle_to_fn

2008-03-22 Thread Christopher Faylor
On Sat, Mar 22, 2008 at 05:05:28PM -0400, Christopher Faylor wrote: >On Sun, Mar 16, 2008 at 11:36:07AM -0400, Christopher Faylor wrote: >>This is basically my function. I'll try to convert it to use Unicode >>today. > >I've checked in changes which move handle_to

Re: [PATCH] QueryDosDevice in handle_to_fn

2008-03-22 Thread Christopher Faylor
On Sun, Mar 16, 2008 at 11:36:07AM -0400, Christopher Faylor wrote: >This is basically my function. I'll try to convert it to use Unicode >today. I've checked in changes which move handle_to_fn closer to being totally 32-bit aware and fixed one pipe and one tty problem in the process. cgf

Re: addr2line [ Was: better stackdumps ]

2008-03-20 Thread Christopher Faylor
binutils and installed that in the first place. > >And that is what I think makes this worthwhile, and worth putting in the >DLL itself: the ability to get some useful info about the fault without >requiring any developer tools or setup. Even if the user has no idea >how to use a debu

Re: [PATCH] better stackdumps

2008-03-20 Thread Christopher Faylor
On Thu, Mar 20, 2008 at 11:35:32AM +0100, Corinna Vinschen wrote: >On Mar 19 08:56, Brian Dessent wrote: >> Christopher Faylor wrote: >> >> > Sorry, but I don't like this concept. This bloats the cygwin DLL for a >> > condition that would be better served by

Re: [PATCH] better stackdumps

2008-03-18 Thread Christopher Faylor
On Tue, Mar 18, 2008 at 05:24:20PM -0700, Brian Dessent wrote: > >This patch adds the ability to see functions/symbols in the .stackdump >files generated when there's a fault. It parses the export sections of >each loaded module and finds the closest exported address for each stack >frame address.

Re: [PATCH] QueryDosDevice in handle_to_fn

2008-03-16 Thread Christopher Faylor
On Sun, Mar 16, 2008 at 04:22:13PM +0100, Corinna Vinschen wrote: >On Mar 16 03:14, Brian Dessent wrote: >> I debugged this and found the >> strangest thing, when you call QueryDosDevice (NULL, fnbuf, len) to get >> the list of all DOS devices and len >= 65536, Win32 always returns 0 >> with GetL

Re: [PATCH] QueryDosDevice in handle_to_fn

2008-03-16 Thread Christopher Faylor
On Sun, Mar 16, 2008 at 03:14:40AM -0700, Brian Dessent wrote: > >It looks like handle_to_fn is again acting up for named pipes. A >representative strace snippet looks something like this: > > 428 108008 [main] readlink 3048 handle_to_fn: nt name >'\Device\NamedPipe\Win32Pipes.082c.0003'

Re: [patch] recognise when an exec()d process terminates due to unhandled exception

2008-03-14 Thread Christopher Faylor
On Thu, Mar 13, 2008 at 07:46:37PM -0700, Brian Dessent wrote: >Brian Dessent wrote: > >> As we all know, Cygwin calls SetErrorMode (SEM_FAILCRITICALERRORS) to >> suppress those pop up GUI messageboxes from the operating system when > >Oh, I forgot to mention: > >In the course of testing this I ca

Re: [patch] cygcheck.cc update for cygpath()

2008-03-10 Thread Christopher Faylor
On Mon, Mar 10, 2008 at 11:34:44AM +0100, Corinna Vinschen wrote: >On Mar 9 19:20, Christopher Faylor wrote: >> On Sun, Mar 09, 2008 at 08:55:09PM +0100, Corinna Vinschen wrote: >> >On Mar 9 11:03, Brian Dessent wrote: >> >> Christopher Faylor wrote: >> >

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 08:55:09PM +0100, Corinna Vinschen wrote: >On Mar 9 11:03, Brian Dessent wrote: >> Christopher Faylor wrote: >> >> > I guess I misunderstood. I thought that the current working directory >> > could be derived through some complicated com

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 04:14:40PM +0100, Corinna Vinschen wrote: >On Mar 9 10:38, Christopher Faylor wrote: >> On Sun, Mar 09, 2008 at 10:28:06AM +0100, Corinna Vinschen wrote: >> >Bash as well as tcsh, as well as zsh (and probbaly pdksh, too) create an >> >enviro

Re: [patch] utils/path.cc fixes and testsuite

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 12:55:13AM -0800, Brian Dessent wrote: >Corinna Vinschen wrote: > >> Doesn't that install testsuite.exe at `make install' time? > >Ack, how about the attached? > >Brian >2008-03-09 Brian Dessent <[EMAIL PROTECTED]> > > * Makefile.in (install): Don't install the tests

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 10:28:06AM +0100, Corinna Vinschen wrote: >Hi Brian, > >Thanks for your patch. I have a few nits, sorry. > >On Mar 8 20:13, Brian Dessent wrote: >> Index: cygcheck.cc >> === >> RCS file: /cvs/src/src/winsup/ut

Re: [patch] utils/path.cc fixes and testsuite

2008-03-08 Thread Christopher Faylor
On Sat, Mar 08, 2008 at 07:10:03PM -0800, Brian Dessent wrote: >Christopher Faylor wrote: > >> Would it be possible to uncollapse this if block and make it a little >> clearer? The "else" nine lines away makes it a little hard to follow. >> So, wouldn't

Re: [patch] utils/path.cc fixes and testsuite

2008-03-08 Thread Christopher Faylor
On Sat, Mar 08, 2008 at 11:01:32AM -0800, Brian Dessent wrote: > >The winsup/utils/path.cc file implements a primative POSIX->Win32 path >conversion API that is independant of the real one in Cygwin. This is >used by cygcheck as well as strace (for opening the -o parameter). >Currently this code

Re: [patch] reorganize utils/Makefile.in

2008-03-08 Thread Christopher Faylor
On Sat, Mar 08, 2008 at 07:28:52AM -0800, Brian Dessent wrote: >2008-03-08 Brian Dessent <[EMAIL PROTECTED]> > > * Makefile.in: Reorganize considerably, using GNU make's > static pattern rules and target-specific variables. Looks good. Please check in. Thanks. cgf

Re: [patch] handle_to_fn: null terminate

2008-03-07 Thread Christopher Faylor
On Fri, Mar 07, 2008 at 05:38:58PM -0800, Brian Dessent wrote: > >I noticed in strace some lines like: > >fhandler_base::close: closing >'/Device/NamedPipe/Win32Pipes.08e0.0002' >handle 0x740 > >This was caused by handle_to_fn simply forgetting to add a \0 when >converting, as in the attach

Re: PATCH: avoid system shared memory version mismatch detected by versioning shared memory name

2008-02-21 Thread Christopher Faylor
On Thu, Feb 21, 2008 at 05:01:20PM -0800, Noel Burton-Krahn wrote: >This is a patch to avoid the "system shared memory version mismatch >detected" problem when two applications use different versions of >Cygwin. My solution is to append the Cygwin version number to the >name of the shared memory s

Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

2008-01-16 Thread Christopher Faylor
On Wed, Jan 16, 2008 at 12:19:39PM +0100, Corinna Vinschen wrote: >On Jan 11 10:58, Christopher Faylor wrote: >> On Mon, Jan 07, 2008 at 08:12:32AM -0500, Christopher Faylor wrote: >> >On Mon, Jan 07, 2008 at 02:11:02PM +0100, Corinna Vinschen wrote: >> >>On Dec 23

Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

2008-01-11 Thread Christopher Faylor
On Mon, Jan 07, 2008 at 08:12:32AM -0500, Christopher Faylor wrote: >On Mon, Jan 07, 2008 at 02:11:02PM +0100, Corinna Vinschen wrote: >>Hi Chris, >> >>On Dec 23 10:28, Corinna Vinschen wrote: >>> On Dec 22 11:08, Christopher Faylor wrote: >>> > On Sat,

Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

2008-01-07 Thread Christopher Faylor
On Mon, Jan 07, 2008 at 02:11:02PM +0100, Corinna Vinschen wrote: >Hi Chris, > >On Dec 23 10:28, Corinna Vinschen wrote: >> On Dec 22 11:08, Christopher Faylor wrote: >> > On Sat, Dec 22, 2007 at 10:48:51AM +0100, Corinna Vinschen wrote: >> > >

Re: BLODA FAQ entry.

2008-01-02 Thread Christopher Faylor
On Wed, Jan 02, 2008 at 07:46:16PM -, Dave Korn wrote: >On 02 January 2008 19:08, Christopher Faylor wrote: > >> On Wed, Jan 02, 2008 at 06:59:03PM -, Dave Korn wrote: >>> On 29 December 2007 18:06, Christopher Faylor wrote: >>> >>>> On Sat, D

Re: BLODA FAQ entry.

2008-01-02 Thread Christopher Faylor
On Wed, Jan 02, 2008 at 06:59:03PM -, Dave Korn wrote: >On 29 December 2007 18:06, Christopher Faylor wrote: > >> On Sat, Dec 29, 2007 at 05:43:09PM -, Dave Korn wrote: >>> >>> The long-promised FAQ entry. >>> >>> winsup/doc/ChangeLog >

Re: Export fast *rint* functions

2007-12-30 Thread Christopher Faylor
On Sun, Dec 30, 2007 at 08:11:43PM -, Dave Korn wrote: >On 29 December 2007 18:16, Dave Korn wrote: > >> On 29 December 2007 18:10, Christopher Faylor wrote: > >>> So check this in but you do also have to bump CYGWIN_VERSION_API_MINOR >>> and document what y

Re: BLODA update for bmnet.dll detect

2007-12-29 Thread Christopher Faylor
On Sat, Dec 29, 2007 at 06:36:43PM -, Dave Korn wrote: >Here's an update that adds BLODA detection for the ByteMobile laptop >optimisation client that Corinna discovered causing problems. > > >winsup/utils/ChangeLog > >2007-12-29 Dave Korn <[EMAIL PROTECTED]> > >* bloda.cc (enum bad_app): Add B

Re: Export fast *rint* functions

2007-12-29 Thread Christopher Faylor
On Sat, Dec 29, 2007 at 05:57:51PM -, Dave Korn wrote: >On 29 December 2007 17:30, Christopher Faylor wrote: > >> On Sat, Dec 29, 2007 at 05:22:31PM -, Dave Korn wrote: >>> On 29 December 2007 17:04, Christopher Faylor wrote: >>> >>>> I assume t

Re: BLODA FAQ entry.

2007-12-29 Thread Christopher Faylor
On Sat, Dec 29, 2007 at 05:43:09PM -, Dave Korn wrote: > > The long-promised FAQ entry. > >winsup/doc/ChangeLog > >2007-29-12 Dave Korn <[EMAIL PROTECTED]> > > * faq-using.xml (faq.using.bloda): New entry. > (faq.using.firewall, faq.using.anti-virus): Link to faq.using.bloda. >

Re: Export fast *rint* functions

2007-12-29 Thread Christopher Faylor
On Sat, Dec 29, 2007 at 05:22:31PM -, Dave Korn wrote: >On 29 December 2007 17:04, Christopher Faylor wrote: > >> I assume that the above comment about aliasing needs to know right? > > Sorry, can't parse that. ENOCOFFEE? ;-) I meant "go" above. I got d

Re: Export fast *rint* functions

2007-12-29 Thread Christopher Faylor
On Sat, Dec 29, 2007 at 11:26:45AM -, Dave Korn wrote: > > One quick Christmas break later hope everyone's had a nice week... > > >On 21 December 2007 23:41, Christopher Faylor wrote: > >> Unless I don't know something about these functions, I don'

Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

2007-12-22 Thread Christopher Faylor
On Sat, Dec 22, 2007 at 10:48:51AM +0100, Corinna Vinschen wrote: >On Dec 20 19:35, Brian Dessent wrote: >> Christopher Faylor wrote: >> >> > Unless Corinna says differently, I think she wants to be in control of >> > what goes into the branch so I don't want

Re: Export fast *rint* functions

2007-12-21 Thread Christopher Faylor
On Fri, Dec 21, 2007 at 06:46:06PM -, Dave Korn wrote: > >Hi gang, > > This patch exports all the new _f_*rint* functions from newlib, adds aliases > for >the non-_f_* names, and redirects the exports for the existing functions >(rint/rintf/lrint/lrintf) away from the current slow soft f

Re: [patch] un-NT-ify cygcheck (was: cygwin 1.5.25-7: cygcheck does not work?)

2007-12-20 Thread Christopher Faylor
On Fri, Dec 21, 2007 at 01:59:54AM -, Dave Korn wrote: >On 20 December 2007 21:12, Christopher Faylor wrote: > >> On Thu, Dec 20, 2007 at 07:15:53AM -0800, Brian Dessent wrote: >>> The attached patch un-NT-ifies bloda.cc but sadly a similar cleanup is >>> still r

<    1   2   3   4   5   6   7   8   9   10   >