Re: [PATCH 1/1] Keep the denormal-operand exception masked; modify FE_ALL_EXCEPT accordingly.

2018-08-15 Thread Houder
On 2018-08-15 17:26, Corinna Vinschen wrote: On Aug 15 17:01, Houder wrote: On 2018-08-15 16:54, Corinna Vinschen wrote: > On Aug 15 12:59, J.H. van de Water wrote: > > By excluding the denormal-operand exception from FE_ALL_EXCEPT, it > > will not > > be possi

Re: [PATCH 1/1] Keep the denormal-operand exception masked; modify FE_ALL_EXCEPT accordingly.

2018-08-15 Thread Houder
On 2018-08-15 16:59, Corinna Vinschen wrote: On Aug 15 16:54, Corinna Vinschen wrote: On Aug 15 12:59, J.H. van de Water wrote: > By excluding the denormal-operand exception from FE_ALL_EXCEPT, it will not > be possible anymore to UNmask this exception by means of the API defined by >

Re: [PATCH 1/1] Keep the denormal-operand exception masked; modify FE_ALL_EXCEPT accordingly.

2018-08-15 Thread Houder
On 2018-08-15 16:54, Corinna Vinschen wrote: On Aug 15 12:59, J.H. van de Water wrote: By excluding the denormal-operand exception from FE_ALL_EXCEPT, it will not be possible anymore to UNmask this exception by means of the API defined by /usr/include/fenv.h Note: terminology has changed

Re: [PATCH 1/1] Keep the denormal-operand exception masked; modify FE_ALL_EXCEPT accordingly.

2018-08-15 Thread Houder
On 2018-08-15 13:52, Corinna Vinschen wrote: Hi J.H., thanks for the patch. Only problem, this patch is non-trivial enough to require the BSD waiver per https://cygwin.com/contrib.html, see the "Before you get started" section. I add you to the winsup/CONTRIBUTORS file then. That ok with

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-05 Thread Houder
On 2018-08-03 14:00, Houder wrote: On 2018-08-03 12:39, Corinna Vinschen wrote: On Aug 3 11:27, Houder wrote: On 2018-08-03 09:36, Corinna Vinschen wrote: [snip] > In terms of x86_64, do we have to change the fenv stuff completely > to use only SSE opcodes? Does that make sense

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 14:00, Houder wrote: [snip] As far as I tell, it is neither the machine nor "fenv" that devices to switch from x87 FPU to SSE ... s/devices/decides/ Sorry.

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 12:39, Corinna Vinschen wrote: On Aug 3 11:27, Houder wrote: On 2018-08-03 09:36, Corinna Vinschen wrote: [snip] > In terms of x86_64, do we have to change the fenv stuff completely > to use only SSE opcodes? Does that make sense at all? Ho! I have to disappoint you h

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 11:27, Houder wrote: I discovered a difference in behaviour between the x87 FPU and SSE. When an exception is masked, a "default action" is carried out when an exception occurs. At the same time the associated status flag is set. (the manual speaks about a "reas

Re: [PATCH] Cygwin: fegetenv() in winsup/cygwin/fenv.cc should not disable exceptions!

2018-08-03 Thread Houder
On 2018-08-03 09:36, Corinna Vinschen wrote: Hi J.H., Pushed with tweaks. The string in __asm__ statements works a Bah! Must be the heat! I did a compare (sdiff), but missed it. You are correct: the '\n' is required. bit different and I made a slight change to the commit message. No