Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Corinna Vinschen
On Feb 26 12:14, Christian Franke wrote: > Corinna Vinschen wrote: > > Why so many? I used winerror.h to populate the list not too long ago, > > so I wonder why it suddenly has so many more error codes? > > "Required for mozilla-central." - 850 insertions: >

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Christian Franke
Corinna Vinschen wrote: On Feb 25 10:12, Christian Franke wrote: Corinna Vinschen wrote: So the default was EPERM at first and has been changed to EACCES because it "is better for the unknown error case". I'm open to ideas for an improved error mapping. I have no better suggestion for a

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-26 Thread Corinna Vinschen
On Feb 25 10:12, Christian Franke wrote: > Corinna Vinschen wrote: > > So the default was EPERM at first and has been changed to EACCES > > because it "is better for the unknown error case". > > > > I'm open to ideas for an improved error mapping. > > I have no better suggestion for a default

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-25 Thread Christian Franke
Corinna Vinschen wrote: On Feb 23 19:14, Christian Franke wrote: Experiments with damaged USB flash drives and ddrescue revealed that the current mapping of these Win32 errors to the fallback EACCES could be improved. BTW: I wonder why EACCES was selected as the fallback. Source code control

Re: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-24 Thread Corinna Vinschen
an improved error mapping. > From 8aa19c7fd13dc3790dc271dede8954539bffcd4d Mon Sep 17 00:00:00 2001 > From: Christian Franke > Date: Fri, 23 Feb 2024 19:01:09 +0100 > Subject: [PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to > ENODEV > > If a removable (USB

[PATCH] Cygwin: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV

2024-02-23 Thread Christian Franke
: Map ERROR_NO_SUCH_DEVICE and ERROR_MEDIA_CHANGED to ENODEV If a removable (USB) device is disconnected after opening its raw device, R/W attempts fail with ERROR_NO_SUCH_DEVICE(433). If the raw device of a partition is used, ERROR_MEDIA_CHANGED(1110) is returned instead. Both are mapped to ENODEV