Re: [PATCH] Cygwin: mmap: Remove AT_ROUND_TO_PAGE workaround

2020-07-21 Thread Corinna Vinschen
Hi Ken, On Jul 20 17:26, Ken Brown via Cygwin-patches wrote: > Hi Corinna, > > On 7/20/2020 2:55 PM, Corinna Vinschen wrote: > > From: Corinna Vinschen > > [...] > > @@ -1089,6 +1073,7 @@ go_ahead: > > } > > #ifdef __x86_64__ > > + orig_len = roundup2 (orig_len, pagesize); Urgh, this l

Re: [PATCH] Cygwin: mmap: Remove AT_ROUND_TO_PAGE workaround

2020-07-20 Thread Ken Brown via Cygwin-patches
+#ifdef __x86_64__ if (!wincap.has_extended_mem_api ()) addr = mmap_alloc.alloc (addr, orig_len ?: len, fixed (flags)); #else I'm attaching an amended commit. I could easily have missed something, and I don't have a 32 bit OS to test on, so just ignore my changes if I'm wron

[PATCH] Cygwin: mmap: Remove AT_ROUND_TO_PAGE workaround

2020-07-20 Thread Corinna Vinschen
From: Corinna Vinschen It's working on 32 bit OSes only anyway. It even fails on WOW64. Signed-off-by: Corinna Vinschen --- Notes: Hi Ken, can you please review this patch and check if it doesn't break your testcase again? Thanks, Corinna winsup/cygwin/mmap.cc |