Re: [PATCH] Cygwin: pipe: Suppress unnecessary set_pipe_non_blocking() call.

2021-11-17 Thread Corinna Vinschen
On Nov 17 10:09, Ken Brown wrote: > On 11/17/2021 3:08 AM, Takashi Yano wrote: > > - Call set_pipe_non_blocking(false) only if the pipe will be really > >inherited to non-cygwin process. > > LGTM, but Corinna should probably take a quick look too, since I'm not very > familiar with this part

Re: [PATCH] Cygwin: pipe: Suppress unnecessary set_pipe_non_blocking() call.

2021-11-17 Thread Ken Brown
On 11/17/2021 3:08 AM, Takashi Yano wrote: - Call set_pipe_non_blocking(false) only if the pipe will be really inherited to non-cygwin process. LGTM, but Corinna should probably take a quick look too, since I'm not very familiar with this part of the code. Ken

[PATCH] Cygwin: pipe: Suppress unnecessary set_pipe_non_blocking() call.

2021-11-17 Thread Takashi Yano
- Call set_pipe_non_blocking(false) only if the pipe will be really inherited to non-cygwin process. --- winsup/cygwin/spawn.cc | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc index 6b2026776..e160fa3bb 100644 ---