Re: [PATCH] Fix potentially uninitialized variable p

2014-01-08 Thread Ray Donnelly
On Wed, Jan 8, 2014 at 2:38 PM, Christopher Faylor wrote: > On Wed, Jan 08, 2014 at 11:00:14AM +, Ray Donnelly wrote: >>On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: >>> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: - PWCHAR p; + PWCHAR p = NULL; >

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-08 Thread Christopher Faylor
On Wed, Jan 08, 2014 at 11:00:14AM +, Ray Donnelly wrote: >On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: >> On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: >>>- PWCHAR p; >>>+ PWCHAR p = NULL; >> >> AFAICT, that would result in a NULL dereference. I've chec

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-08 Thread Ray Donnelly
On Sun, Dec 22, 2013 at 7:11 AM, Christopher Faylor wrote: > On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: >>- PWCHAR p; >>+ PWCHAR p = NULL; > > AFAICT, that would result in a NULL dereference. I've checked in > a different change to handle this. Thanks, A NULL derefer

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-07 Thread Christopher Faylor
On Sun, Dec 22, 2013 at 12:40:20AM +, Ray Donnelly wrote: >- PWCHAR p; >+ PWCHAR p = NULL; AFAICT, that would result in a NULL dereference. I've checked in a different change to handle this. cgf

Re: [PATCH] Fix potentially uninitialized variable p

2014-01-07 Thread Corinna Vinschen
On Dec 22 00:40, Ray Donnelly wrote: > [PATCH 2/3] * winsup/cygwin/strace.cc (strace::vsprntf): Fix potentially > uninitialized variable p p is never uninitialized in this code. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

[PATCH] Fix potentially uninitialized variable p

2013-12-21 Thread Ray Donnelly
0002-winsup-cygwin-strace.cc-strace-vsprntf-Fix-potential.patch Description: Binary data